mirror of
https://github.com/wpilibsuite/allwpilib
synced 2026-06-29 02:21:44 +00:00
Update for C++17 and fix MSVC warnings (#1694)
* Update MSVC arguments * Fix json allocator * Fix simulation diamond * Bump gtest * Remove empty varargs in unit tests * Replace test case with test suite * Remove deprecation warning in optional * Remove need for NOMIXMAX to be defined in wpilib headers
This commit is contained in:
committed by
Peter Johnson
parent
fb1239a2ad
commit
221011494d
@@ -183,7 +183,7 @@ public:
|
||||
/// Move-construct an error value. The newly constructed error is considered
|
||||
/// unchecked, even if the source error had been checked. The original error
|
||||
/// becomes a checked Success value, regardless of its original state.
|
||||
Error(Error &&Other) {
|
||||
Error(Error &&Other) noexcept {
|
||||
setChecked(true);
|
||||
*this = std::move(Other);
|
||||
}
|
||||
@@ -202,7 +202,7 @@ public:
|
||||
/// you cannot overwrite an unhandled error. The current error is then
|
||||
/// considered unchecked. The source error becomes a checked success value,
|
||||
/// regardless of its original state.
|
||||
Error &operator=(Error &&Other) {
|
||||
Error &operator=(Error &&Other) noexcept {
|
||||
// Don't allow overwriting of unchecked values.
|
||||
assertIsChecked();
|
||||
setPtr(Other.getPtr());
|
||||
|
||||
Reference in New Issue
Block a user