Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-27 02:01:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ntcore] ClientImpl3: Store Entry by value

Browse Source
This commit is contained in:
Peter Johnson
2024-10-25 13:57:07 -07:00
parent e49d452e46
commit 27e07d6787
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
ntcore/src/main/native/cpp/net3/ClientImpl3.h
View File

@@ -160,18 +160,14 @@ class ClientImpl3 final : private MessageHandler3 {
std::vector<std::pair<unsigned int, unsigned int>> m_outgoingFlags;
using NameMap = wpi::StringMap<std::unique_ptr<Entry>>;
using NameMap = wpi::StringMap<Entry>;
using IdMap = std::vector<Entry*>;
NameMap m_nameMap;
IdMap m_idMap;
Entry* GetOrNewEntry(std::string_view name) {
auto& entry = m_nameMap[name];
if (!entry) {
entry = std::make_unique<Entry>(name);
}
return entry.get();
return &m_nameMap.try_emplace(name, name).first->second;
}
Entry* LookupId(unsigned int id) {
return id < m_idMap.size() ? m_idMap[id] : nullptr;