Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-22 01:11:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

[wpilib] Add X and Y component getters to Pose2d and Transform2d (#2563)

Browse Source 
pose.Translation().X() and pose.Translation.Y() are common operations,
so shortening them to pose.X() and pose.Y() would be convenient.

Java uses the getX() convention so that is used instead of X() for Java.
This commit is contained in:
Tyler Veness
2020-07-02 18:09:36 -07:00
committed by GitHub
parent 5ccc98bc14
commit 2a0f79b90f
39 changed files with 228 additions and 192 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/MecanumControllerCommand.java
View File

@@ -260,12 +260,12 @@ public class MecanumControllerCommand extends CommandBase {
var poseError = desiredPose.relativeTo(m_pose.get());
double targetXVel = m_xController.calculate(
m_pose.get().getTranslation().getX(),
desiredPose.getTranslation().getX());
m_pose.get().getX(),
desiredPose.getX());
double targetYVel = m_yController.calculate(
m_pose.get().getTranslation().getY(),
desiredPose.getTranslation().getY());
m_pose.get().getY(),
desiredPose.getY());
// The robot will go to the desired rotation of the final pose in the trajectory,
// not following the poses at individual states.

8
wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/SwerveControllerCommand.java
View File

@@ -120,12 +120,12 @@ public class SwerveControllerCommand extends CommandBase {
var poseError = desiredPose.relativeTo(m_pose.get());
double targetXVel = m_xController.calculate(
m_pose.get().getTranslation().getX(),
desiredPose.getTranslation().getX());
m_pose.get().getX(),
desiredPose.getX());
double targetYVel = m_yController.calculate(
m_pose.get().getTranslation().getY(),
desiredPose.getTranslation().getY());
m_pose.get().getY(),
desiredPose.getY());
// The robot will go to the desired rotation of the final pose in the trajectory,
// not following the poses at individual states.