Add braces to C++ single-line loops and conditionals (NFC) (#2973)

This makes code easier to read and more consistent between C++ and Java.
Also update clang-format settings to always add a line break (even if no braces are used).
This commit is contained in:
Peter Johnson
2020-12-28 12:58:06 -08:00
committed by GitHub
parent 0291a3ff56
commit 2aed432b4b
634 changed files with 10716 additions and 3938 deletions

View File

@@ -98,13 +98,15 @@ bool remapDigitalSource(HAL_Handle digitalSourceHandle,
*/
constexpr int32_t remapDigitalChannelToBitfieldChannel(int32_t channel) {
// First 10 are headers
if (channel < kNumDigitalHeaders) return channel;
// 2nd group of 16 are mxp. So if mxp port, add 6, since they start at 10
else if (channel < kNumDigitalMXPChannels)
if (channel < kNumDigitalHeaders) {
return channel;
// 2nd group of 16 are mxp. So if mxp port, add 6, since they start at 10
} else if (channel < kNumDigitalMXPChannels) {
return channel + 6;
// Assume SPI, so remove MXP channels
else
// Assume SPI, so remove MXP channels
} else {
return channel - kNumDigitalMXPChannels;
}
}
/**