Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-19 00:41:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add braces to C++ single-line loops and conditionals (NFC) (#2973)

Browse Source 
This makes code easier to read and more consistent between C++ and Java.
Also update clang-format settings to always add a line break (even if no braces are used).
This commit is contained in:
Peter Johnson
2020-12-28 12:58:06 -08:00
committed by GitHub
parent 0291a3ff56
commit 2aed432b4b
634 changed files with 10716 additions and 3938 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
simulation/halsim_gui/src/main/native/cpp/SimDeviceGui.cpp
View File

@@ -25,7 +25,9 @@ class SimValueSource : public glass::DataSource {
m_callback{HALSIM_RegisterSimValueChangedCallback(
handle, this, CallbackFunc, true)} {}
~SimValueSource() {
if (m_callback != 0) HALSIM_CancelSimValueChangedCallback(m_callback);
if (m_callback != 0) {
HALSIM_CancelSimValueChangedCallback(m_callback);
}
}
private:
@@ -136,7 +138,9 @@ static void DisplaySimDevice(const char* name, void* data,
HAL_SimDeviceHandle handle) {
// only show "Foo" portion of "Accel:Foo"
auto [type, id] = wpi::StringRef{name}.split(':');
if (id.empty()) id = type;
if (id.empty()) {
id = type;
}
if (glass::BeginDevice(id.data())) {
HALSIM_EnumerateSimValues(handle, data, DisplaySimValue);
glass::EndDevice();