Add braces to C++ single-line loops and conditionals (NFC) (#2973)

This makes code easier to read and more consistent between C++ and Java.
Also update clang-format settings to always add a line break (even if no braces are used).
This commit is contained in:
Peter Johnson
2020-12-28 12:58:06 -08:00
committed by GitHub
parent 0291a3ff56
commit 2aed432b4b
634 changed files with 10716 additions and 3938 deletions

View File

@@ -17,7 +17,9 @@
using namespace frc2;
Command::~Command() { CommandScheduler::GetInstance().Cancel(this); }
Command::~Command() {
CommandScheduler::GetInstance().Cancel(this);
}
Command::Command(const Command& rhs) : ErrorBase(rhs) {}
@@ -83,13 +85,17 @@ PerpetualCommand Command::Perpetually() && {
return PerpetualCommand(std::move(*this).TransferOwnership());
}
ProxyScheduleCommand Command::AsProxy() { return ProxyScheduleCommand(this); }
ProxyScheduleCommand Command::AsProxy() {
return ProxyScheduleCommand(this);
}
void Command::Schedule(bool interruptible) {
CommandScheduler::GetInstance().Schedule(interruptible, this);
}
void Command::Cancel() { CommandScheduler::GetInstance().Cancel(this); }
void Command::Cancel() {
CommandScheduler::GetInstance().Cancel(this);
}
bool Command::IsScheduled() const {
return CommandScheduler::GetInstance().IsScheduled(this);
@@ -103,11 +109,17 @@ bool Command::HasRequirement(Subsystem* requirement) const {
return hasRequirement;
}
std::string Command::GetName() const { return GetTypeName(*this); }
std::string Command::GetName() const {
return GetTypeName(*this);
}
bool Command::IsGrouped() const { return m_isGrouped; }
bool Command::IsGrouped() const {
return m_isGrouped;
}
void Command::SetGrouped(bool grouped) { m_isGrouped = grouped; }
void Command::SetGrouped(bool grouped) {
m_isGrouped = grouped;
}
namespace frc2 {
bool RequirementsDisjoint(Command* first, Command* second) {