Add braces to C++ single-line loops and conditionals (NFC) (#2973)

This makes code easier to read and more consistent between C++ and Java.
Also update clang-format settings to always add a line break (even if no braces are used).
This commit is contained in:
Peter Johnson
2020-12-28 12:58:06 -08:00
committed by GitHub
parent 0291a3ff56
commit 2aed432b4b
634 changed files with 10716 additions and 3938 deletions

View File

@@ -72,19 +72,29 @@ PIDCommand::PIDCommand(double p, double i, double d, double period,
m_controller = std::make_shared<PIDController>(p, i, d, this, this, period);
}
void PIDCommand::_Initialize() { m_controller->Enable(); }
void PIDCommand::_Initialize() {
m_controller->Enable();
}
void PIDCommand::_End() { m_controller->Disable(); }
void PIDCommand::_End() {
m_controller->Disable();
}
void PIDCommand::_Interrupted() { _End(); }
void PIDCommand::_Interrupted() {
_End();
}
void PIDCommand::SetSetpointRelative(double deltaSetpoint) {
SetSetpoint(GetSetpoint() + deltaSetpoint);
}
void PIDCommand::PIDWrite(double output) { UsePIDOutput(output); }
void PIDCommand::PIDWrite(double output) {
UsePIDOutput(output);
}
double PIDCommand::PIDGet() { return ReturnPIDInput(); }
double PIDCommand::PIDGet() {
return ReturnPIDInput();
}
std::shared_ptr<PIDController> PIDCommand::GetPIDController() const {
return m_controller;
@@ -94,9 +104,13 @@ void PIDCommand::SetSetpoint(double setpoint) {
m_controller->SetSetpoint(setpoint);
}
double PIDCommand::GetSetpoint() const { return m_controller->GetSetpoint(); }
double PIDCommand::GetSetpoint() const {
return m_controller->GetSetpoint();
}
double PIDCommand::GetPosition() { return ReturnPIDInput(); }
double PIDCommand::GetPosition() {
return ReturnPIDInput();
}
void PIDCommand::InitSendable(SendableBuilder& builder) {
m_controller->InitSendable(builder);