Add braces to C++ single-line loops and conditionals (NFC) (#2973)

This makes code easier to read and more consistent between C++ and Java.
Also update clang-format settings to always add a line break (even if no braces are used).
This commit is contained in:
Peter Johnson
2020-12-28 12:58:06 -08:00
committed by GitHub
parent 0291a3ff56
commit 2aed432b4b
634 changed files with 10716 additions and 3938 deletions

View File

@@ -6,4 +6,6 @@
using namespace frc;
wpi::StringRef LayoutType::GetLayoutName() const { return m_layoutName; }
wpi::StringRef LayoutType::GetLayoutName() const {
return m_layoutName;
}

View File

@@ -10,13 +10,17 @@
using namespace frc;
void Shuffleboard::Update() { GetInstance().Update(); }
void Shuffleboard::Update() {
GetInstance().Update();
}
ShuffleboardTab& Shuffleboard::GetTab(wpi::StringRef title) {
return GetInstance().GetTab(title);
}
void Shuffleboard::SelectTab(int index) { GetInstance().SelectTab(index); }
void Shuffleboard::SelectTab(int index) {
GetInstance().SelectTab(index);
}
void Shuffleboard::SelectTab(wpi::StringRef title) {
GetInstance().SelectTab(title);
@@ -36,7 +40,9 @@ void Shuffleboard::StartRecording() {
GetRecordingController().StartRecording();
}
void Shuffleboard::StopRecording() { GetRecordingController().StopRecording(); }
void Shuffleboard::StopRecording() {
GetRecordingController().StopRecording();
}
void Shuffleboard::SetRecordingFileNameFormat(wpi::StringRef format) {
GetRecordingController().SetRecordingFileNameFormat(format);

View File

@@ -65,7 +65,9 @@ ShuffleboardContainer& ShuffleboardComponentBase::GetParent() {
return m_parent;
}
const std::string& ShuffleboardComponentBase::GetType() const { return m_type; }
const std::string& ShuffleboardComponentBase::GetType() const {
return m_type;
}
const wpi::StringMap<std::shared_ptr<nt::Value>>&
ShuffleboardComponentBase::GetProperties() const {

View File

@@ -9,7 +9,9 @@ using namespace frc;
ShuffleboardTab::ShuffleboardTab(ShuffleboardRoot& root, wpi::StringRef title)
: ShuffleboardValue(title), ShuffleboardContainer(title), m_root(root) {}
ShuffleboardRoot& ShuffleboardTab::GetRoot() { return m_root; }
ShuffleboardRoot& ShuffleboardTab::GetRoot() {
return m_root;
}
void ShuffleboardTab::BuildInto(std::shared_ptr<nt::NetworkTable> parentTable,
std::shared_ptr<nt::NetworkTable> metaTable) {

View File

@@ -6,4 +6,6 @@
using namespace frc;
wpi::StringRef WidgetType::GetWidgetName() const { return m_widgetName; }
wpi::StringRef WidgetType::GetWidgetName() const {
return m_widgetName;
}