diff --git a/cscore/src/main/native/windows/ComPtr.h b/cscore/src/main/native/windows/ComPtr.h index 1449ad0fd7..ac79bb3adb 100644 --- a/cscore/src/main/native/windows/ComPtr.h +++ b/cscore/src/main/native/windows/ComPtr.h @@ -24,7 +24,7 @@ class ComPtr { template friend class ComPtr; - ComPtr(std::nullptr_t = nullptr) noexcept {} // NOLINT(runtime/explicit) + ComPtr(std::nullptr_t = nullptr) noexcept {} // NOLINT ComPtr(const ComPtr& other) noexcept : m_ptr(other.m_ptr) { InternalAddRef(); } diff --git a/hal/src/main/native/include/hal/SimDevice.h b/hal/src/main/native/include/hal/SimDevice.h index 22c0576450..0808880cb7 100644 --- a/hal/src/main/native/include/hal/SimDevice.h +++ b/hal/src/main/native/include/hal/SimDevice.h @@ -306,7 +306,7 @@ class SimValue { * * @param handle simulated value handle */ - /*implicit*/ SimValue(HAL_SimValueHandle val) // NOLINT(runtime/explicit) + /*implicit*/ SimValue(HAL_SimValueHandle val) // NOLINT : m_handle(val) {} /** @@ -358,7 +358,7 @@ class SimDouble : public SimValue { * * @param handle simulated value handle */ - /*implicit*/ SimDouble(HAL_SimValueHandle val) // NOLINT(runtime/explicit) + /*implicit*/ SimDouble(HAL_SimValueHandle val) // NOLINT : SimValue(val) {} /** @@ -392,7 +392,7 @@ class SimEnum : public SimValue { * * @param handle simulated value handle */ - /*implicit*/ SimEnum(HAL_SimValueHandle val) // NOLINT(runtime/explicit) + /*implicit*/ SimEnum(HAL_SimValueHandle val) // NOLINT : SimValue(val) {} /** @@ -426,7 +426,7 @@ class SimBoolean : public SimValue { * * @param handle simulated value handle */ - /*implicit*/ SimBoolean(HAL_SimValueHandle val) // NOLINT(runtime/explicit) + /*implicit*/ SimBoolean(HAL_SimValueHandle val) // NOLINT : SimValue(val) {} /** diff --git a/hal/src/main/native/include/hal/Types.h b/hal/src/main/native/include/hal/Types.h index 672fa649c9..8ca0494160 100644 --- a/hal/src/main/native/include/hal/Types.h +++ b/hal/src/main/native/include/hal/Types.h @@ -83,7 +83,7 @@ template class Handle { public: Handle() = default; - /*implicit*/ Handle(CType val) : m_handle(val) {} // NOLINT(runtime/explicit) + /*implicit*/ Handle(CType val) : m_handle(val) {} // NOLINT Handle(const Handle&) = delete; Handle& operator=(const Handle&) = delete; diff --git a/wpimath/src/main/native/include/frc/geometry/Rotation2d.h b/wpimath/src/main/native/include/frc/geometry/Rotation2d.h index 2bbb59db81..4a69124b21 100644 --- a/wpimath/src/main/native/include/frc/geometry/Rotation2d.h +++ b/wpimath/src/main/native/include/frc/geometry/Rotation2d.h @@ -28,14 +28,14 @@ class Rotation2d { * * @param value The value of the angle in radians. */ - Rotation2d(units::radian_t value); // NOLINT(runtime/explicit) + Rotation2d(units::radian_t value); // NOLINT /** * Constructs a Rotation2d with the given degree value. * * @param value The value of the angle in degrees. */ - Rotation2d(units::degree_t value); // NOLINT(runtime/explicit) + Rotation2d(units::degree_t value); // NOLINT /** * Constructs a Rotation2d with the given x and y (cosine and sine) diff --git a/wpiutil/src/main/native/include/wpi/HttpUtil.h b/wpiutil/src/main/native/include/wpi/HttpUtil.h index 0df8286dcc..84bb19f147 100644 --- a/wpiutil/src/main/native/include/wpi/HttpUtil.h +++ b/wpiutil/src/main/native/include/wpi/HttpUtil.h @@ -228,7 +228,7 @@ class HttpPath { class HttpPathRef { public: HttpPathRef() = default; - /*implicit*/ HttpPathRef(const HttpPath& path, // NOLINT(runtime/explicit) + /*implicit*/ HttpPathRef(const HttpPath& path, // NOLINT size_t start = 0) : m_path(&path), m_start(start) {} diff --git a/wpiutil/src/main/native/include/wpi/uv/Buffer.h b/wpiutil/src/main/native/include/wpi/uv/Buffer.h index 7ff8df63f1..3a790bd175 100644 --- a/wpiutil/src/main/native/include/wpi/uv/Buffer.h +++ b/wpiutil/src/main/native/include/wpi/uv/Buffer.h @@ -27,13 +27,13 @@ class Buffer : public uv_buf_t { base = nullptr; len = 0; } - /*implicit*/ Buffer(const uv_buf_t& oth) { // NOLINT(runtime/explicit) + /*implicit*/ Buffer(const uv_buf_t& oth) { // NOLINT base = oth.base; len = oth.len; } - /*implicit*/ Buffer(StringRef str) // NOLINT(runtime/explicit) + /*implicit*/ Buffer(StringRef str) // NOLINT : Buffer{str.data(), str.size()} {} - /*implicit*/ Buffer(ArrayRef arr) // NOLINT(runtime/explicit) + /*implicit*/ Buffer(ArrayRef arr) // NOLINT : Buffer{reinterpret_cast(arr.data()), arr.size()} {} Buffer(char* base_, size_t len_) { base = base_; diff --git a/wpiutil/src/main/native/include/wpi/uv/Process.h b/wpiutil/src/main/native/include/wpi/uv/Process.h index 010219f12f..9b387157ba 100644 --- a/wpiutil/src/main/native/include/wpi/uv/Process.h +++ b/wpiutil/src/main/native/include/wpi/uv/Process.h @@ -58,26 +58,25 @@ class Process final : public HandleImpl { Option() : m_type(kNone) {} - /*implicit*/ Option(const char* arg) { // NOLINT(runtime/explicit) + /*implicit*/ Option(const char* arg) { // NOLINT m_data.str = arg; } - /*implicit*/ Option(const std::string& arg) { // NOLINT(runtime/explicit) + /*implicit*/ Option(const std::string& arg) { // NOLINT m_data.str = arg.data(); } - /*implicit*/ Option(StringRef arg) // NOLINT(runtime/explicit) + /*implicit*/ Option(StringRef arg) // NOLINT : m_strData(arg) { m_data.str = m_strData.c_str(); } - /*implicit*/ Option( - const SmallVectorImpl& arg) // NOLINT(runtime/explicit) + /*implicit*/ Option(const SmallVectorImpl& arg) // NOLINT : m_strData(arg.data(), arg.size()) { m_data.str = m_strData.c_str(); } - /*implicit*/ Option(const Twine& arg) // NOLINT(runtime/explicit) + /*implicit*/ Option(const Twine& arg) // NOLINT : m_strData(arg.str()) { m_data.str = m_strData.c_str(); } diff --git a/wpiutil/src/test/native/cpp/sigslot/recursive.cpp b/wpiutil/src/test/native/cpp/sigslot/recursive.cpp index 44e7284f22..726361b800 100644 --- a/wpiutil/src/test/native/cpp/sigslot/recursive.cpp +++ b/wpiutil/src/test/native/cpp/sigslot/recursive.cpp @@ -39,7 +39,7 @@ namespace { template struct object { - object(T i) : v{i} {} // NOLINT(runtime/explicit) + object(T i) : v{i} {} // NOLINT void inc_val(const T& i) { if (i != v) { diff --git a/wpiutil/src/test/native/cpp/sigslot/signal.cpp b/wpiutil/src/test/native/cpp/sigslot/signal.cpp index af0e646c6d..c0f9641ef3 100644 --- a/wpiutil/src/test/native/cpp/sigslot/signal.cpp +++ b/wpiutil/src/test/native/cpp/sigslot/signal.cpp @@ -507,7 +507,7 @@ TEST(Signal, SignalMoving) { template struct object { object(); - object(T i) : v{i} {} // NOLINT(runtime/explicit) + object(T i) : v{i} {} // NOLINT const T& val() const { return v; } T& val() { return v; }