Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-07-05 03:21:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Replace NOLINT(runtime/explicit) comments with NOLINT (NFC) (#2992)

Browse Source 
cpplint.py can accept either, but clang-tidy requires NOLINT.
This commit is contained in:
Tyler Veness
2020-12-28 15:10:31 -08:00
committed by GitHub
parent 1c3011ba4b
commit 2b4317452b
9 changed files with 19 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
hal/src/main/native/include/hal/SimDevice.h
View File

@@ -306,7 +306,7 @@ class SimValue {
*
* @param handle simulated value handle
*/
/*implicit*/ SimValue(HAL_SimValueHandle val) // NOLINT(runtime/explicit)
/*implicit*/ SimValue(HAL_SimValueHandle val) // NOLINT
: m_handle(val) {}
/**
@@ -358,7 +358,7 @@ class SimDouble : public SimValue {
*
* @param handle simulated value handle
*/
/*implicit*/ SimDouble(HAL_SimValueHandle val) // NOLINT(runtime/explicit)
/*implicit*/ SimDouble(HAL_SimValueHandle val) // NOLINT
: SimValue(val) {}
/**
@@ -392,7 +392,7 @@ class SimEnum : public SimValue {
*
* @param handle simulated value handle
*/
/*implicit*/ SimEnum(HAL_SimValueHandle val) // NOLINT(runtime/explicit)
/*implicit*/ SimEnum(HAL_SimValueHandle val) // NOLINT
: SimValue(val) {}
/**
@@ -426,7 +426,7 @@ class SimBoolean : public SimValue {
*
* @param handle simulated value handle
*/
/*implicit*/ SimBoolean(HAL_SimValueHandle val) // NOLINT(runtime/explicit)
/*implicit*/ SimBoolean(HAL_SimValueHandle val) // NOLINT
: SimValue(val) {}
/**

2
hal/src/main/native/include/hal/Types.h
View File

@@ -83,7 +83,7 @@ template <typename CType, int32_t CInvalid = HAL_kInvalidHandle>
class Handle {
public:
Handle() = default;
/*implicit*/ Handle(CType val) : m_handle(val) {} // NOLINT(runtime/explicit)
/*implicit*/ Handle(CType val) : m_handle(val) {} // NOLINT
Handle(const Handle&) = delete;
Handle& operator=(const Handle&) = delete;