Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-29 02:21:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Replace NOLINT(runtime/explicit) comments with NOLINT (NFC) (#2992)

Browse Source 
cpplint.py can accept either, but clang-tidy requires NOLINT.
This commit is contained in:
Tyler Veness
2020-12-28 15:10:31 -08:00
committed by GitHub
parent 1c3011ba4b
commit 2b4317452b
9 changed files with 19 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
wpiutil/src/main/native/include/wpi/HttpUtil.h
View File

@@ -228,7 +228,7 @@ class HttpPath {
class HttpPathRef {
public:
HttpPathRef() = default;
/*implicit*/ HttpPathRef(const HttpPath& path, // NOLINT(runtime/explicit)
/*implicit*/ HttpPathRef(const HttpPath& path, // NOLINT
size_t start = 0)
: m_path(&path), m_start(start) {}

6
wpiutil/src/main/native/include/wpi/uv/Buffer.h
View File

@@ -27,13 +27,13 @@ class Buffer : public uv_buf_t {
base = nullptr;
len = 0;
}
/*implicit*/ Buffer(const uv_buf_t& oth) { // NOLINT(runtime/explicit)
/*implicit*/ Buffer(const uv_buf_t& oth) { // NOLINT
base = oth.base;
len = oth.len;
}
/*implicit*/ Buffer(StringRef str) // NOLINT(runtime/explicit)
/*implicit*/ Buffer(StringRef str) // NOLINT
: Buffer{str.data(), str.size()} {}
/*implicit*/ Buffer(ArrayRef<uint8_t> arr) // NOLINT(runtime/explicit)
/*implicit*/ Buffer(ArrayRef<uint8_t> arr) // NOLINT
: Buffer{reinterpret_cast<const char*>(arr.data()), arr.size()} {}
Buffer(char* base_, size_t len_) {
base = base_;

11
wpiutil/src/main/native/include/wpi/uv/Process.h
View File

@@ -58,26 +58,25 @@ class Process final : public HandleImpl<Process, uv_process_t> {
Option() : m_type(kNone) {}
/*implicit*/ Option(const char* arg) { // NOLINT(runtime/explicit)
/*implicit*/ Option(const char* arg) { // NOLINT
m_data.str = arg;
}
/*implicit*/ Option(const std::string& arg) { // NOLINT(runtime/explicit)
/*implicit*/ Option(const std::string& arg) { // NOLINT
m_data.str = arg.data();
}
/*implicit*/ Option(StringRef arg) // NOLINT(runtime/explicit)
/*implicit*/ Option(StringRef arg) // NOLINT
: m_strData(arg) {
m_data.str = m_strData.c_str();
}
/*implicit*/ Option(
const SmallVectorImpl<char>& arg) // NOLINT(runtime/explicit)
/*implicit*/ Option(const SmallVectorImpl<char>& arg) // NOLINT
: m_strData(arg.data(), arg.size()) {
m_data.str = m_strData.c_str();
}
/*implicit*/ Option(const Twine& arg) // NOLINT(runtime/explicit)
/*implicit*/ Option(const Twine& arg) // NOLINT
: m_strData(arg.str()) {
m_data.str = m_strData.c_str();
}