Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-24 01:31:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

[wpilibc] Fix uninitialized variable in Trajectory class (#2495)

Browse Source 
Valgrind caught this one. If you default initialize a Trajectory, it
doesn't initialize m_totalTime. This means a subsequent call to
Trajectory::TotalTime() returns the value of an uninitialized variable.
3512's software was using 0_s as a sentinel value for when a trajectory
was empty. We didn't notice a problem before because Linux zero-inits
memory.
This commit is contained in:
Tyler Veness
2020-04-26 08:03:17 -07:00
committed by GitHub
parent 4b77b0773e
commit 3011ebe547
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
wpilibc/src/main/native/include/frc/trajectory/Trajectory.h
View File

@@ -129,7 +129,7 @@ class Trajectory {
private:
std::vector<State> m_states;
units::second_t m_totalTime;
units::second_t m_totalTime = 0_s;
/**
* Linearly interpolates between two values.