Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-19 00:41:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't force public variables to use Hungarian notation (#8774)

Browse Source 
People generally have expressed a dislike for the Hungarian notation
used in member variables, especially in examples/templates, and our
styleguide shouldn't be forced on downstream consumers, so this removes
all Hungarian notation from the examples/templates.

There are _some_ benefits to Hungarian for private member variables
(like knowing what's a member vs. local in a PR review) so we'll keep
private member variables the same for now, but public variables should
no longer use Hungarian notation, since it looks much worse. A new PMD
XPath rule has been added to accomplish this goal. Some other
non-compliant variables were fixed for the new rule.
This commit is contained in:
Gold856
2026-04-25 14:32:08 -04:00
committed by GitHub
parent e7e51c9c05
commit 35e8abedeb
443 changed files with 4584 additions and 4789 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
hal/src/main/java/org/wpilib/hardware/hal/CANAPITypes.java
View File

@@ -55,7 +55,6 @@ public final class CANAPITypes {
FIRMWARE_UPDATE(31);
/** The device type ID. */
@SuppressWarnings("MemberName")
public final int id;
CANDeviceType(int id) {
@@ -118,7 +117,6 @@ public final class CANAPITypes {
BRUSHLAND_LABS(20);
/** The manufacturer ID. */
@SuppressWarnings("MemberName")
public final int id;
CANManufacturer(int id) {

1
hal/src/main/java/org/wpilib/hardware/hal/MatchInfoData.java
View File

@@ -5,7 +5,6 @@
package org.wpilib.hardware.hal;
/** Structure for holding the match info data request. */
@SuppressWarnings("MemberName")
public class MatchInfoData {
/** Stores the event name. */
public String eventName = "";

6
hal/src/main/java/org/wpilib/hardware/hal/OpModeOption.java
View File

@@ -7,22 +7,16 @@ package org.wpilib.hardware.hal;
/** An individual opmode option. */
public class OpModeOption {
/** Unique id. Encodes robot mode in bits 57-56, LSB 56 bits is hash of name. */
@SuppressWarnings("MemberName")
public final long id;
@SuppressWarnings("MemberName")
public final String name;
@SuppressWarnings("MemberName")
public final String group;
@SuppressWarnings("MemberName")
public final String description;
@SuppressWarnings("MemberName")
public final int textColor;
@SuppressWarnings("MemberName")
public final int backgroundColor;
/**

157
hal/src/main/java/org/wpilib/hardware/hal/PowerDistributionFaults.java
View File

@@ -8,88 +8,87 @@ package org.wpilib.hardware.hal;
* Faults for a PowerDistribution device. These faults are only active while the condition is
* active.
*/
@SuppressWarnings("MemberName")
public class PowerDistributionFaults {
/** Breaker fault on channel 0. */
public final boolean Channel0BreakerFault;
public final boolean channel0BreakerFault;
/** Breaker fault on channel 1. */
public final boolean Channel1BreakerFault;
public final boolean channel1BreakerFault;
/** Breaker fault on channel 2. */
public final boolean Channel2BreakerFault;
public final boolean channel2BreakerFault;
/** Breaker fault on channel 3. */
public final boolean Channel3BreakerFault;
public final boolean channel3BreakerFault;
/** Breaker fault on channel 4. */
public final boolean Channel4BreakerFault;
public final boolean channel4BreakerFault;
/** Breaker fault on channel 5. */
public final boolean Channel5BreakerFault;
public final boolean channel5BreakerFault;
/** Breaker fault on channel 6. */
public final boolean Channel6BreakerFault;
public final boolean channel6BreakerFault;
/** Breaker fault on channel 7. */
public final boolean Channel7BreakerFault;
public final boolean channel7BreakerFault;
/** Breaker fault on channel 8. */
public final boolean Channel8BreakerFault;
public final boolean channel8BreakerFault;
/** Breaker fault on channel 9. */
public final boolean Channel9BreakerFault;
public final boolean channel9BreakerFault;
/** Breaker fault on channel 10. */
public final boolean Channel10BreakerFault;
public final boolean channel10BreakerFault;
/** Breaker fault on channel 11. */
public final boolean Channel11BreakerFault;
public final boolean channel11BreakerFault;
/** Breaker fault on channel 12. */
public final boolean Channel12BreakerFault;
public final boolean channel12BreakerFault;
/** Breaker fault on channel 13. */
public final boolean Channel13BreakerFault;
public final boolean channel13BreakerFault;
/** Breaker fault on channel 14. */
public final boolean Channel14BreakerFault;
public final boolean channel14BreakerFault;
/** Breaker fault on channel 15. */
public final boolean Channel15BreakerFault;
public final boolean channel15BreakerFault;
/** Breaker fault on channel 16. */
public final boolean Channel16BreakerFault;
public final boolean channel16BreakerFault;
/** Breaker fault on channel 17. */
public final boolean Channel17BreakerFault;
public final boolean channel17BreakerFault;
/** Breaker fault on channel 18. */
public final boolean Channel18BreakerFault;
public final boolean channel18BreakerFault;
/** Breaker fault on channel 19. */
public final boolean Channel19BreakerFault;
public final boolean channel19BreakerFault;
/** Breaker fault on channel 20. */
public final boolean Channel20BreakerFault;
public final boolean channel20BreakerFault;
/** Breaker fault on channel 21. */
public final boolean Channel21BreakerFault;
public final boolean channel21BreakerFault;
/** Breaker fault on channel 22. */
public final boolean Channel22BreakerFault;
public final boolean channel22BreakerFault;
/** Breaker fault on channel 23. */
public final boolean Channel23BreakerFault;
public final boolean channel23BreakerFault;
/** The input voltage is below the minimum voltage. */
public final boolean Brownout;
public final boolean brownout;
/** A warning was raised by the device's CAN controller. */
public final boolean CanWarning;
public final boolean canWarning;
/** The hardware on the device has malfunctioned. */
public final boolean HardwareFault;
public final boolean hardwareFault;
/**
* Gets whether there is a breaker fault at the specified channel.
@@ -101,30 +100,30 @@ public class PowerDistributionFaults {
*/
public final boolean getBreakerFault(int channel) {
return switch (channel) {
case 0 -> Channel0BreakerFault;
case 1 -> Channel1BreakerFault;
case 2 -> Channel2BreakerFault;
case 3 -> Channel3BreakerFault;
case 4 -> Channel4BreakerFault;
case 5 -> Channel5BreakerFault;
case 6 -> Channel6BreakerFault;
case 7 -> Channel7BreakerFault;
case 8 -> Channel8BreakerFault;
case 9 -> Channel9BreakerFault;
case 10 -> Channel10BreakerFault;
case 11 -> Channel11BreakerFault;
case 12 -> Channel12BreakerFault;
case 13 -> Channel13BreakerFault;
case 14 -> Channel14BreakerFault;
case 15 -> Channel15BreakerFault;
case 16 -> Channel16BreakerFault;
case 17 -> Channel17BreakerFault;
case 18 -> Channel18BreakerFault;
case 19 -> Channel19BreakerFault;
case 20 -> Channel20BreakerFault;
case 21 -> Channel21BreakerFault;
case 22 -> Channel22BreakerFault;
case 23 -> Channel23BreakerFault;
case 0 -> channel0BreakerFault;
case 1 -> channel1BreakerFault;
case 2 -> channel2BreakerFault;
case 3 -> channel3BreakerFault;
case 4 -> channel4BreakerFault;
case 5 -> channel5BreakerFault;
case 6 -> channel6BreakerFault;
case 7 -> channel7BreakerFault;
case 8 -> channel8BreakerFault;
case 9 -> channel9BreakerFault;
case 10 -> channel10BreakerFault;
case 11 -> channel11BreakerFault;
case 12 -> channel12BreakerFault;
case 13 -> channel13BreakerFault;
case 14 -> channel14BreakerFault;
case 15 -> channel15BreakerFault;
case 16 -> channel16BreakerFault;
case 17 -> channel17BreakerFault;
case 18 -> channel18BreakerFault;
case 19 -> channel19BreakerFault;
case 20 -> channel20BreakerFault;
case 21 -> channel21BreakerFault;
case 22 -> channel22BreakerFault;
case 23 -> channel23BreakerFault;
default ->
throw new IndexOutOfBoundsException("Power distribution fault channel out of bounds!");
};
@@ -136,32 +135,32 @@ public class PowerDistributionFaults {
* @param faults faults
*/
public PowerDistributionFaults(int faults) {
Channel0BreakerFault = (faults & 0x1) != 0;
Channel1BreakerFault = (faults & 0x2) != 0;
Channel2BreakerFault = (faults & 0x4) != 0;
Channel3BreakerFault = (faults & 0x8) != 0;
Channel4BreakerFault = (faults & 0x10) != 0;
Channel5BreakerFault = (faults & 0x20) != 0;
Channel6BreakerFault = (faults & 0x40) != 0;
Channel7BreakerFault = (faults & 0x80) != 0;
Channel8BreakerFault = (faults & 0x100) != 0;
Channel9BreakerFault = (faults & 0x200) != 0;
Channel10BreakerFault = (faults & 0x400) != 0;
Channel11BreakerFault = (faults & 0x800) != 0;
Channel12BreakerFault = (faults & 0x1000) != 0;
Channel13BreakerFault = (faults & 0x2000) != 0;
Channel14BreakerFault = (faults & 0x4000) != 0;
Channel15BreakerFault = (faults & 0x8000) != 0;
Channel16BreakerFault = (faults & 0x10000) != 0;
Channel17BreakerFault = (faults & 0x20000) != 0;
Channel18BreakerFault = (faults & 0x40000) != 0;
Channel19BreakerFault = (faults & 0x80000) != 0;
Channel20BreakerFault = (faults & 0x100000) != 0;
Channel21BreakerFault = (faults & 0x200000) != 0;
Channel22BreakerFault = (faults & 0x400000) != 0;
Channel23BreakerFault = (faults & 0x800000) != 0;
Brownout = (faults & 0x1000000) != 0;
CanWarning = (faults & 0x2000000) != 0;
HardwareFault = (faults & 0x4000000) != 0;
channel0BreakerFault = (faults & 0x1) != 0;
channel1BreakerFault = (faults & 0x2) != 0;
channel2BreakerFault = (faults & 0x4) != 0;
channel3BreakerFault = (faults & 0x8) != 0;
channel4BreakerFault = (faults & 0x10) != 0;
channel5BreakerFault = (faults & 0x20) != 0;
channel6BreakerFault = (faults & 0x40) != 0;
channel7BreakerFault = (faults & 0x80) != 0;
channel8BreakerFault = (faults & 0x100) != 0;
channel9BreakerFault = (faults & 0x200) != 0;
channel10BreakerFault = (faults & 0x400) != 0;
channel11BreakerFault = (faults & 0x800) != 0;
channel12BreakerFault = (faults & 0x1000) != 0;
channel13BreakerFault = (faults & 0x2000) != 0;
channel14BreakerFault = (faults & 0x4000) != 0;
channel15BreakerFault = (faults & 0x8000) != 0;
channel16BreakerFault = (faults & 0x10000) != 0;
channel17BreakerFault = (faults & 0x20000) != 0;
channel18BreakerFault = (faults & 0x40000) != 0;
channel19BreakerFault = (faults & 0x80000) != 0;
channel20BreakerFault = (faults & 0x100000) != 0;
channel21BreakerFault = (faults & 0x200000) != 0;
channel22BreakerFault = (faults & 0x400000) != 0;
channel23BreakerFault = (faults & 0x800000) != 0;
brownout = (faults & 0x1000000) != 0;
canWarning = (faults & 0x2000000) != 0;
hardwareFault = (faults & 0x4000000) != 0;
}
}

169
hal/src/main/java/org/wpilib/hardware/hal/PowerDistributionStickyFaults.java
View File

@@ -8,97 +8,96 @@ package org.wpilib.hardware.hal;
* Sticky faults for a PowerDistribution device. These faults will remain active until they are
* reset by the user.
*/
@SuppressWarnings("MemberName")
public class PowerDistributionStickyFaults {
/** Breaker fault on channel 0. */
public final boolean Channel0BreakerFault;
public final boolean channel0BreakerFault;
/** Breaker fault on channel 1. */
public final boolean Channel1BreakerFault;
public final boolean channel1BreakerFault;
/** Breaker fault on channel 2. */
public final boolean Channel2BreakerFault;
public final boolean channel2BreakerFault;
/** Breaker fault on channel 3. */
public final boolean Channel3BreakerFault;
public final boolean channel3BreakerFault;
/** Breaker fault on channel 4. */
public final boolean Channel4BreakerFault;
public final boolean channel4BreakerFault;
/** Breaker fault on channel 5. */
public final boolean Channel5BreakerFault;
public final boolean channel5BreakerFault;
/** Breaker fault on channel 6. */
public final boolean Channel6BreakerFault;
public final boolean channel6BreakerFault;
/** Breaker fault on channel 7. */
public final boolean Channel7BreakerFault;
public final boolean channel7BreakerFault;
/** Breaker fault on channel 8. */
public final boolean Channel8BreakerFault;
public final boolean channel8BreakerFault;
/** Breaker fault on channel 9. */
public final boolean Channel9BreakerFault;
public final boolean channel9BreakerFault;
/** Breaker fault on channel 10. */
public final boolean Channel10BreakerFault;
public final boolean channel10BreakerFault;
/** Breaker fault on channel 11. */
public final boolean Channel11BreakerFault;
public final boolean channel11BreakerFault;
/** Breaker fault on channel 12. */
public final boolean Channel12BreakerFault;
public final boolean channel12BreakerFault;
/** Breaker fault on channel 13. */
public final boolean Channel13BreakerFault;
public final boolean channel13BreakerFault;
/** Breaker fault on channel 14. */
public final boolean Channel14BreakerFault;
public final boolean channel14BreakerFault;
/** Breaker fault on channel 15. */
public final boolean Channel15BreakerFault;
public final boolean channel15BreakerFault;
/** Breaker fault on channel 16. */
public final boolean Channel16BreakerFault;
public final boolean channel16BreakerFault;
/** Breaker fault on channel 17. */
public final boolean Channel17BreakerFault;
public final boolean channel17BreakerFault;
/** Breaker fault on channel 18. */
public final boolean Channel18BreakerFault;
public final boolean channel18BreakerFault;
/** Breaker fault on channel 19. */
public final boolean Channel19BreakerFault;
public final boolean channel19BreakerFault;
/** Breaker fault on channel 20. */
public final boolean Channel20BreakerFault;
public final boolean channel20BreakerFault;
/** Breaker fault on channel 21. */
public final boolean Channel21BreakerFault;
public final boolean channel21BreakerFault;
/** Breaker fault on channel 22. */
public final boolean Channel22BreakerFault;
public final boolean channel22BreakerFault;
/** Breaker fault on channel 23. */
public final boolean Channel23BreakerFault;
public final boolean channel23BreakerFault;
/** The input voltage was below the minimum voltage. */
public final boolean Brownout;
public final boolean brownout;
/** A warning was raised by the device's CAN controller. */
public final boolean CanWarning;
public final boolean canWarning;
/** The device's CAN controller experienced a "Bus Off" event. */
public final boolean CanBusOff;
public final boolean canBusOff;
/** The hardware on the device has malfunctioned. */
public final boolean HardwareFault;
public final boolean hardwareFault;
/** The firmware on the device has malfunctioned. */
public final boolean FirmwareFault;
public final boolean firmwareFault;
/** The device has rebooted. */
public final boolean HasReset;
public final boolean hasReset;
/**
* Gets whether there is a sticky breaker fault at the specified channel.
@@ -110,30 +109,30 @@ public class PowerDistributionStickyFaults {
*/
public final boolean getBreakerFault(int channel) {
return switch (channel) {
case 0 -> Channel0BreakerFault;
case 1 -> Channel1BreakerFault;
case 2 -> Channel2BreakerFault;
case 3 -> Channel3BreakerFault;
case 4 -> Channel4BreakerFault;
case 5 -> Channel5BreakerFault;
case 6 -> Channel6BreakerFault;
case 7 -> Channel7BreakerFault;
case 8 -> Channel8BreakerFault;
case 9 -> Channel9BreakerFault;
case 10 -> Channel10BreakerFault;
case 11 -> Channel11BreakerFault;
case 12 -> Channel12BreakerFault;
case 13 -> Channel13BreakerFault;
case 14 -> Channel14BreakerFault;
case 15 -> Channel15BreakerFault;
case 16 -> Channel16BreakerFault;
case 17 -> Channel17BreakerFault;
case 18 -> Channel18BreakerFault;
case 19 -> Channel19BreakerFault;
case 20 -> Channel20BreakerFault;
case 21 -> Channel21BreakerFault;
case 22 -> Channel22BreakerFault;
case 23 -> Channel23BreakerFault;
case 0 -> channel0BreakerFault;
case 1 -> channel1BreakerFault;
case 2 -> channel2BreakerFault;
case 3 -> channel3BreakerFault;
case 4 -> channel4BreakerFault;
case 5 -> channel5BreakerFault;
case 6 -> channel6BreakerFault;
case 7 -> channel7BreakerFault;
case 8 -> channel8BreakerFault;
case 9 -> channel9BreakerFault;
case 10 -> channel10BreakerFault;
case 11 -> channel11BreakerFault;
case 12 -> channel12BreakerFault;
case 13 -> channel13BreakerFault;
case 14 -> channel14BreakerFault;
case 15 -> channel15BreakerFault;
case 16 -> channel16BreakerFault;
case 17 -> channel17BreakerFault;
case 18 -> channel18BreakerFault;
case 19 -> channel19BreakerFault;
case 20 -> channel20BreakerFault;
case 21 -> channel21BreakerFault;
case 22 -> channel22BreakerFault;
case 23 -> channel23BreakerFault;
default ->
throw new IndexOutOfBoundsException("Power distribution fault channel out of bounds!");
};
@@ -145,35 +144,35 @@ public class PowerDistributionStickyFaults {
* @param faults faults
*/
public PowerDistributionStickyFaults(int faults) {
Channel0BreakerFault = (faults & 0x1) != 0;
Channel1BreakerFault = (faults & 0x2) != 0;
Channel2BreakerFault = (faults & 0x4) != 0;
Channel3BreakerFault = (faults & 0x8) != 0;
Channel4BreakerFault = (faults & 0x10) != 0;
Channel5BreakerFault = (faults & 0x20) != 0;
Channel6BreakerFault = (faults & 0x40) != 0;
Channel7BreakerFault = (faults & 0x80) != 0;
Channel8BreakerFault = (faults & 0x100) != 0;
Channel9BreakerFault = (faults & 0x200) != 0;
Channel10BreakerFault = (faults & 0x400) != 0;
Channel11BreakerFault = (faults & 0x800) != 0;
Channel12BreakerFault = (faults & 0x1000) != 0;
Channel13BreakerFault = (faults & 0x2000) != 0;
Channel14BreakerFault = (faults & 0x4000) != 0;
Channel15BreakerFault = (faults & 0x8000) != 0;
Channel16BreakerFault = (faults & 0x10000) != 0;
Channel17BreakerFault = (faults & 0x20000) != 0;
Channel18BreakerFault = (faults & 0x40000) != 0;
Channel19BreakerFault = (faults & 0x80000) != 0;
Channel20BreakerFault = (faults & 0x100000) != 0;
Channel21BreakerFault = (faults & 0x200000) != 0;
Channel22BreakerFault = (faults & 0x400000) != 0;
Channel23BreakerFault = (faults & 0x800000) != 0;
Brownout = (faults & 0x1000000) != 0;
CanWarning = (faults & 0x2000000) != 0;
CanBusOff = (faults & 0x4000000) != 0;
HardwareFault = (faults & 0x8000000) != 0;
FirmwareFault = (faults & 0x10000000) != 0;
HasReset = (faults & 0x20000000) != 0;
channel0BreakerFault = (faults & 0x1) != 0;
channel1BreakerFault = (faults & 0x2) != 0;
channel2BreakerFault = (faults & 0x4) != 0;
channel3BreakerFault = (faults & 0x8) != 0;
channel4BreakerFault = (faults & 0x10) != 0;
channel5BreakerFault = (faults & 0x20) != 0;
channel6BreakerFault = (faults & 0x40) != 0;
channel7BreakerFault = (faults & 0x80) != 0;
channel8BreakerFault = (faults & 0x100) != 0;
channel9BreakerFault = (faults & 0x200) != 0;
channel10BreakerFault = (faults & 0x400) != 0;
channel11BreakerFault = (faults & 0x800) != 0;
channel12BreakerFault = (faults & 0x1000) != 0;
channel13BreakerFault = (faults & 0x2000) != 0;
channel14BreakerFault = (faults & 0x4000) != 0;
channel15BreakerFault = (faults & 0x8000) != 0;
channel16BreakerFault = (faults & 0x10000) != 0;
channel17BreakerFault = (faults & 0x20000) != 0;
channel18BreakerFault = (faults & 0x40000) != 0;
channel19BreakerFault = (faults & 0x80000) != 0;
channel20BreakerFault = (faults & 0x100000) != 0;
channel21BreakerFault = (faults & 0x200000) != 0;
channel22BreakerFault = (faults & 0x400000) != 0;
channel23BreakerFault = (faults & 0x800000) != 0;
brownout = (faults & 0x1000000) != 0;
canWarning = (faults & 0x2000000) != 0;
canBusOff = (faults & 0x4000000) != 0;
hardwareFault = (faults & 0x8000000) != 0;
firmwareFault = (faults & 0x10000000) != 0;
hasReset = (faults & 0x20000000) != 0;
}
}

1
hal/src/main/java/org/wpilib/hardware/hal/PowerDistributionVersion.java
View File

@@ -5,7 +5,6 @@
package org.wpilib.hardware.hal;
/** Power distribution version. */
@SuppressWarnings("MemberName")
public class PowerDistributionVersion {
/** Firmware major version number. */
public final int firmwareMajor;

123
hal/src/main/java/org/wpilib/hardware/hal/REVPHFaults.java
View File

@@ -5,73 +5,72 @@
package org.wpilib.hardware.hal;
/** Faults for a REV PH. These faults are only active while the condition is active. */
@SuppressWarnings("MemberName")
public class REVPHFaults {
/** Fault on channel 0. */
public final boolean Channel0Fault;
public final boolean channel0Fault;
/** Fault on channel 1. */
public final boolean Channel1Fault;
public final boolean channel1Fault;
/** Fault on channel 2. */
public final boolean Channel2Fault;
public final boolean channel2Fault;
/** Fault on channel 3. */
public final boolean Channel3Fault;
public final boolean channel3Fault;
/** Fault on channel 4. */
public final boolean Channel4Fault;
public final boolean channel4Fault;
/** Fault on channel 5. */
public final boolean Channel5Fault;
public final boolean channel5Fault;
/** Fault on channel 6. */
public final boolean Channel6Fault;
public final boolean channel6Fault;
/** Fault on channel 7. */
public final boolean Channel7Fault;
public final boolean channel7Fault;
/** Fault on channel 8. */
public final boolean Channel8Fault;
public final boolean channel8Fault;
/** Fault on channel 9. */
public final boolean Channel9Fault;
public final boolean channel9Fault;
/** Fault on channel 10. */
public final boolean Channel10Fault;
public final boolean channel10Fault;
/** Fault on channel 11. */
public final boolean Channel11Fault;
public final boolean channel11Fault;
/** Fault on channel 12. */
public final boolean Channel12Fault;
public final boolean channel12Fault;
/** Fault on channel 13. */
public final boolean Channel13Fault;
public final boolean channel13Fault;
/** Fault on channel 14. */
public final boolean Channel14Fault;
public final boolean channel14Fault;
/** Fault on channel 15. */
public final boolean Channel15Fault;
public final boolean channel15Fault;
/** An overcurrent event occurred on the compressor output. */
public final boolean CompressorOverCurrent;
public final boolean compressorOverCurrent;
/** The compressor output has an open circuit. */
public final boolean CompressorOpen;
public final boolean compressorOpen;
/** An overcurrent event occurred on a solenoid output. */
public final boolean SolenoidOverCurrent;
public final boolean solenoidOverCurrent;
/** The input voltage is below the minimum voltage. */
public final boolean Brownout;
public final boolean brownout;
/** A warning was raised by the device's CAN controller. */
public final boolean CanWarning;
public final boolean canWarning;
/** The hardware on the device has malfunctioned. */
public final boolean HardwareFault;
public final boolean hardwareFault;
/**
* Gets whether there is a fault at the specified channel.
@@ -81,24 +80,24 @@ public class REVPHFaults {
* @throws IndexOutOfBoundsException if the provided channel is outside of the range supported by
* the hardware.
*/
public final boolean getChannelFault(int channel) {
public final boolean getchannelFault(int channel) {
return switch (channel) {
case 0 -> Channel0Fault;
case 1 -> Channel1Fault;
case 2 -> Channel2Fault;
case 3 -> Channel3Fault;
case 4 -> Channel4Fault;
case 5 -> Channel5Fault;
case 6 -> Channel6Fault;
case 7 -> Channel7Fault;
case 8 -> Channel8Fault;
case 9 -> Channel9Fault;
case 10 -> Channel10Fault;
case 11 -> Channel11Fault;
case 12 -> Channel12Fault;
case 13 -> Channel13Fault;
case 14 -> Channel14Fault;
case 15 -> Channel15Fault;
case 0 -> channel0Fault;
case 1 -> channel1Fault;
case 2 -> channel2Fault;
case 3 -> channel3Fault;
case 4 -> channel4Fault;
case 5 -> channel5Fault;
case 6 -> channel6Fault;
case 7 -> channel7Fault;
case 8 -> channel8Fault;
case 9 -> channel9Fault;
case 10 -> channel10Fault;
case 11 -> channel11Fault;
case 12 -> channel12Fault;
case 13 -> channel13Fault;
case 14 -> channel14Fault;
case 15 -> channel15Fault;
default -> throw new IndexOutOfBoundsException("Pneumatics fault channel out of bounds!");
};
}
@@ -109,27 +108,27 @@ public class REVPHFaults {
* @param faults the fault bitfields
*/
public REVPHFaults(int faults) {
Channel0Fault = (faults & (1 << 0)) != 0;
Channel1Fault = (faults & (1 << 1)) != 0;
Channel2Fault = (faults & (1 << 2)) != 0;
Channel3Fault = (faults & (1 << 3)) != 0;
Channel4Fault = (faults & (1 << 4)) != 0;
Channel5Fault = (faults & (1 << 5)) != 0;
Channel6Fault = (faults & (1 << 6)) != 0;
Channel7Fault = (faults & (1 << 7)) != 0;
Channel8Fault = (faults & (1 << 8)) != 0;
Channel9Fault = (faults & (1 << 9)) != 0;
Channel10Fault = (faults & (1 << 10)) != 0;
Channel11Fault = (faults & (1 << 11)) != 0;
Channel12Fault = (faults & (1 << 12)) != 0;
Channel13Fault = (faults & (1 << 13)) != 0;
Channel14Fault = (faults & (1 << 14)) != 0;
Channel15Fault = (faults & (1 << 15)) != 0;
CompressorOverCurrent = (faults & (1 << 16)) != 0;
CompressorOpen = (faults & (1 << 17)) != 0;
SolenoidOverCurrent = (faults & (1 << 18)) != 0;
Brownout = (faults & (1 << 19)) != 0;
CanWarning = (faults & (1 << 20)) != 0;
HardwareFault = (faults & (1 << 21)) != 0;
channel0Fault = (faults & (1 << 0)) != 0;
channel1Fault = (faults & (1 << 1)) != 0;
channel2Fault = (faults & (1 << 2)) != 0;
channel3Fault = (faults & (1 << 3)) != 0;
channel4Fault = (faults & (1 << 4)) != 0;
channel5Fault = (faults & (1 << 5)) != 0;
channel6Fault = (faults & (1 << 6)) != 0;
channel7Fault = (faults & (1 << 7)) != 0;
channel8Fault = (faults & (1 << 8)) != 0;
channel9Fault = (faults & (1 << 9)) != 0;
channel10Fault = (faults & (1 << 10)) != 0;
channel11Fault = (faults & (1 << 11)) != 0;
channel12Fault = (faults & (1 << 12)) != 0;
channel13Fault = (faults & (1 << 13)) != 0;
channel14Fault = (faults & (1 << 14)) != 0;
channel15Fault = (faults & (1 << 15)) != 0;
compressorOverCurrent = (faults & (1 << 16)) != 0;
compressorOpen = (faults & (1 << 17)) != 0;
solenoidOverCurrent = (faults & (1 << 18)) != 0;
brownout = (faults & (1 << 19)) != 0;
canWarning = (faults & (1 << 20)) != 0;
hardwareFault = (faults & (1 << 21)) != 0;
}
}

37
hal/src/main/java/org/wpilib/hardware/hal/REVPHStickyFaults.java
View File

@@ -5,34 +5,33 @@
package org.wpilib.hardware.hal;
/** Sticky faults for a REV PH. These faults will remain active until they are reset by the user. */
@SuppressWarnings("MemberName")
public class REVPHStickyFaults {
/** An overcurrent event occurred on the compressor output. */
public final boolean CompressorOverCurrent;
public final boolean compressorOverCurrent;
/** The compressor output has an open circuit. */
public final boolean CompressorOpen;
public final boolean compressorOpen;
/** An overcurrent event occurred on a solenoid output. */
public final boolean SolenoidOverCurrent;
public final boolean solenoidOverCurrent;
/** The input voltage is below the minimum voltage. */
public final boolean Brownout;
public final boolean brownout;
/** A warning was raised by the device's CAN controller. */
public final boolean CanWarning;
public final boolean canWarning;
/** The device's CAN controller experienced a "Bus Off" event. */
public final boolean CanBusOff;
public final boolean canBusOff;
/** The hardware on the device has malfunctioned. */
public final boolean HardwareFault;
public final boolean hardwareFault;
/** The firmware on the device has malfunctioned. */
public final boolean FirmwareFault;
public final boolean firmwareFault;
/** The device has rebooted. */
public final boolean HasReset;
public final boolean hasReset;
/**
* Called from HAL.
@@ -40,14 +39,14 @@ public class REVPHStickyFaults {
* @param faults sticky fault bit mask
*/
public REVPHStickyFaults(int faults) {
CompressorOverCurrent = (faults & 0x1) != 0;
CompressorOpen = (faults & 0x2) != 0;
SolenoidOverCurrent = (faults & 0x4) != 0;
Brownout = (faults & 0x8) != 0;
CanWarning = (faults & 0x10) != 0;
CanBusOff = (faults & 0x20) != 0;
HardwareFault = (faults & 0x40) != 0;
FirmwareFault = (faults & 0x80) != 0;
HasReset = (faults & 0x100) != 0;
compressorOverCurrent = (faults & 0x1) != 0;
compressorOpen = (faults & 0x2) != 0;
solenoidOverCurrent = (faults & 0x4) != 0;
brownout = (faults & 0x8) != 0;
canWarning = (faults & 0x10) != 0;
canBusOff = (faults & 0x20) != 0;
hardwareFault = (faults & 0x40) != 0;
firmwareFault = (faults & 0x80) != 0;
hasReset = (faults & 0x100) != 0;
}
}

1
hal/src/main/java/org/wpilib/hardware/hal/REVPHVersion.java
View File

@@ -5,7 +5,6 @@
package org.wpilib.hardware.hal;
/** Version and device data received from a REV PH. */
@SuppressWarnings("MemberName")
public class REVPHVersion {
/** The firmware major version. */
public final int firmwareMajor;

19
hal/src/main/java/org/wpilib/hardware/hal/SimDevice.java
View File

@@ -26,10 +26,10 @@ public class SimDevice implements AutoCloseable {
BIDIR(SimDeviceJNI.VALUE_BIDIR);
/** The native value of this Direction. */
public final int m_value;
public final int value;
Direction(int value) {
m_value = value;
this.value = value;
}
}
@@ -140,7 +140,7 @@ public class SimDevice implements AutoCloseable {
* @return simulated value object
*/
public SimValue createValue(String name, Direction direction, HALValue initialValue) {
int handle = SimDeviceJNI.createSimValue(m_handle, name, direction.m_value, initialValue);
int handle = SimDeviceJNI.createSimValue(m_handle, name, direction.value, initialValue);
if (handle <= 0) {
return null;
}
@@ -158,7 +158,7 @@ public class SimDevice implements AutoCloseable {
* @return simulated double value object
*/
public SimInt createInt(String name, Direction direction, int initialValue) {
int handle = SimDeviceJNI.createSimValueInt(m_handle, name, direction.m_value, initialValue);
int handle = SimDeviceJNI.createSimValueInt(m_handle, name, direction.value, initialValue);
if (handle <= 0) {
return null;
}
@@ -176,7 +176,7 @@ public class SimDevice implements AutoCloseable {
* @return simulated double value object
*/
public SimLong createLong(String name, Direction direction, long initialValue) {
int handle = SimDeviceJNI.createSimValueLong(m_handle, name, direction.m_value, initialValue);
int handle = SimDeviceJNI.createSimValueLong(m_handle, name, direction.value, initialValue);
if (handle <= 0) {
return null;
}
@@ -194,7 +194,7 @@ public class SimDevice implements AutoCloseable {
* @return simulated double value object
*/
public SimDouble createDouble(String name, Direction direction, double initialValue) {
int handle = SimDeviceJNI.createSimValueDouble(m_handle, name, direction.m_value, initialValue);
int handle = SimDeviceJNI.createSimValueDouble(m_handle, name, direction.value, initialValue);
if (handle <= 0) {
return null;
}
@@ -216,7 +216,7 @@ public class SimDevice implements AutoCloseable {
*/
public SimEnum createEnum(String name, Direction direction, String[] options, int initialValue) {
int handle =
SimDeviceJNI.createSimValueEnum(m_handle, name, direction.m_value, options, initialValue);
SimDeviceJNI.createSimValueEnum(m_handle, name, direction.value, options, initialValue);
if (handle <= 0) {
return null;
}
@@ -241,7 +241,7 @@ public class SimDevice implements AutoCloseable {
String name, Direction direction, String[] options, double[] optionValues, int initialValue) {
int handle =
SimDeviceJNI.createSimValueEnumDouble(
m_handle, name, direction.m_value, options, optionValues, initialValue);
m_handle, name, direction.value, options, optionValues, initialValue);
if (handle <= 0) {
return null;
}
@@ -259,8 +259,7 @@ public class SimDevice implements AutoCloseable {
* @return simulated boolean value object
*/
public SimBoolean createBoolean(String name, Direction direction, boolean initialValue) {
int handle =
SimDeviceJNI.createSimValueBoolean(m_handle, name, direction.m_value, initialValue);
int handle = SimDeviceJNI.createSimValueBoolean(m_handle, name, direction.value, initialValue);
if (handle <= 0) {
return null;
}

4
hal/src/main/java/org/wpilib/hardware/hal/can/CANReceiveMessage.java
View File

@@ -7,19 +7,15 @@ package org.wpilib.hardware.hal.can;
/** Represents a CAN message read from a stream. */
public class CANReceiveMessage {
/** The message data. */
@SuppressWarnings("MemberName")
public final byte[] data = new byte[64];
/** The length of the data received (0-8 bytes). */
@SuppressWarnings("MemberName")
public int length;
/** The flags of the message. */
@SuppressWarnings("MemberName")
public int flags;
/** Timestamp message was received, in microseconds (wpi time). */
@SuppressWarnings("MemberName")
public long timestamp;
/** Default constructor. */

1
hal/src/main/java/org/wpilib/hardware/hal/can/CANStatus.java
View File

@@ -5,7 +5,6 @@
package org.wpilib.hardware.hal.can;
/** Structure for holding the result of a CAN Status request. */
@SuppressWarnings("MemberName")
public class CANStatus {
/** The utilization of the CAN Bus. */
public double percentBusUtilization;

5
hal/src/main/java/org/wpilib/hardware/hal/can/CANStreamMessage.java
View File

@@ -7,23 +7,18 @@ package org.wpilib.hardware.hal.can;
/** Represents a CAN message read from a stream. */
public class CANStreamMessage {
/** The message data. */
@SuppressWarnings("MemberName")
public final byte[] data = new byte[64];
/** The length of the data received (0-64 bytes). */
@SuppressWarnings("MemberName")
public int length;
/** The flags of the message. */
@SuppressWarnings("MemberName")
public int flags;
/** Timestamp message was received, in milliseconds (based off of CLOCK_MONOTONIC). */
@SuppressWarnings("MemberName")
public long timestamp;
/** The message ID. */
@SuppressWarnings("MemberName")
public int messageId;
/** Default constructor. */

5
hal/src/main/java/org/wpilib/hardware/hal/simulation/AlertDataJNI.java
View File

@@ -18,19 +18,14 @@ public class AlertDataJNI extends JNIWrapper {
this.level = level;
}
@SuppressWarnings("MemberName")
public final int handle;
@SuppressWarnings("MemberName")
public final String group;
@SuppressWarnings("MemberName")
public final String text;
@SuppressWarnings("MemberName")
public final long activeStartTime; // 0 if not active
@SuppressWarnings("MemberName")
public final int level; // ALERT_LEVEL_HIGH, ALERT_LEVEL_MEDIUM, ALERT_LEVEL_LOW
}

2
hal/src/main/java/org/wpilib/hardware/hal/simulation/SimDeviceDataJNI.java
View File

@@ -29,7 +29,6 @@ public class SimDeviceDataJNI extends JNIWrapper {
public static native int getSimValueDeviceHandle(int handle);
@SuppressWarnings("MemberName")
public static class SimDeviceInfo {
public String name;
public int handle;
@@ -74,7 +73,6 @@ public class SimDeviceDataJNI extends JNIWrapper {
public static native int getSimValueHandle(int device, String name);
@SuppressWarnings("MemberName")
public static class SimValueInfo {
public String name;
public int handle;