Don't force public variables to use Hungarian notation (#8774)

People generally have expressed a dislike for the Hungarian notation
used in member variables, especially in examples/templates, and our
styleguide shouldn't be forced on downstream consumers, so this removes
all Hungarian notation from the examples/templates.

There are _some_ benefits to Hungarian for private member variables
(like knowing what's a member vs. local in a PR review) so we'll keep
private member variables the same for now, but public variables should
no longer use Hungarian notation, since it looks much worse. A new PMD
XPath rule has been added to accomplish this goal. Some other
non-compliant variables were fixed for the new rule.
This commit is contained in:
Gold856
2026-04-25 14:32:08 -04:00
committed by GitHub
parent e7e51c9c05
commit 35e8abedeb
443 changed files with 4584 additions and 4789 deletions

View File

@@ -54,38 +54,38 @@ classes:
UniqueId:
wpi::PneumaticHub::Faults:
attributes:
Channel0Fault:
Channel1Fault:
Channel2Fault:
Channel3Fault:
Channel4Fault:
Channel5Fault:
Channel6Fault:
Channel7Fault:
Channel8Fault:
Channel9Fault:
Channel10Fault:
Channel11Fault:
Channel12Fault:
Channel13Fault:
Channel14Fault:
Channel15Fault:
CompressorOverCurrent:
CompressorOpen:
SolenoidOverCurrent:
Brownout:
CanWarning:
HardwareFault:
channel0Fault:
channel1Fault:
channel2Fault:
channel3Fault:
channel4Fault:
channel5Fault:
channel6Fault:
channel7Fault:
channel8Fault:
channel9Fault:
channel10Fault:
channel11Fault:
channel12Fault:
channel13Fault:
channel14Fault:
channel15Fault:
compressorOverCurrent:
compressorOpen:
solenoidOverCurrent:
brownout:
canWarning:
hardwareFault:
methods:
GetChannelFault:
wpi::PneumaticHub::StickyFaults:
attributes:
CompressorOverCurrent:
CompressorOpen:
SolenoidOverCurrent:
Brownout:
CanWarning:
CanBusOff:
HasReset:
HardwareFault:
FirmwareFault:
compressorOverCurrent:
compressorOpen:
solenoidOverCurrent:
brownout:
canWarning:
canBusOff:
hasReset:
hardwareFault:
firmwareFault: