Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-24 01:31:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't force public variables to use Hungarian notation (#8774)

Browse Source 
People generally have expressed a dislike for the Hungarian notation
used in member variables, especially in examples/templates, and our
styleguide shouldn't be forced on downstream consumers, so this removes
all Hungarian notation from the examples/templates.

There are _some_ benefits to Hungarian for private member variables
(like knowing what's a member vs. local in a PR review) so we'll keep
private member variables the same for now, but public variables should
no longer use Hungarian notation, since it looks much worse. A new PMD
XPath rule has been added to accomplish this goal. Some other
non-compliant variables were fixed for the new rule.
This commit is contained in:
Gold856
2026-04-25 14:32:08 -04:00
committed by GitHub
parent e7e51c9c05
commit 35e8abedeb
443 changed files with 4584 additions and 4789 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
wpilibjExamples/src/main/java/org/wpilib/examples/tankdrivegamepad/Robot.java
View File

@@ -15,21 +15,21 @@ import org.wpilib.util.sendable.SendableRegistry;
* steering and a gamepad.
*/
public class Robot extends TimedRobot {
private final PWMSparkMax m_leftMotor = new PWMSparkMax(0);
private final PWMSparkMax m_rightMotor = new PWMSparkMax(1);
private final DifferentialDrive m_robotDrive =
new DifferentialDrive(m_leftMotor::setThrottle, m_rightMotor::setThrottle);
private final Gamepad m_driverController = new Gamepad(0);
private final PWMSparkMax leftMotor = new PWMSparkMax(0);
private final PWMSparkMax rightMotor = new PWMSparkMax(1);
private final DifferentialDrive robotDrive =
new DifferentialDrive(leftMotor::setThrottle, rightMotor::setThrottle);
private final Gamepad driverController = new Gamepad(0);
/** Called once at the beginning of the robot program. */
public Robot() {
SendableRegistry.addChild(m_robotDrive, m_leftMotor);
SendableRegistry.addChild(m_robotDrive, m_rightMotor);
SendableRegistry.addChild(robotDrive, leftMotor);
SendableRegistry.addChild(robotDrive, rightMotor);
// We need to invert one side of the drivetrain so that positive voltages
// result in both sides moving forward. Depending on how your robot's
// gearbox is constructed, you might have to invert the left side instead.
m_rightMotor.setInverted(true);
rightMotor.setInverted(true);
}
@Override
@@ -38,6 +38,6 @@ public class Robot extends TimedRobot {
// That means that the Y axis of the left stick moves the left side
// of the robot forward and backward, and the Y axis of the right stick
// moves the right side of the robot forward and backward.
m_robotDrive.tankDrive(-m_driverController.getLeftY(), -m_driverController.getRightY());
robotDrive.tankDrive(-driverController.getLeftY(), -driverController.getRightY());
}
}