Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-19 00:41:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

[wpilibc] Notifier: Use atomic exchange in move constructor/assignment (#8740)

Browse Source
This commit is contained in:
Peter Johnson
2026-04-10 12:28:54 -07:00
committed by GitHub
parent 1671150521
commit 3728bc3b5c
1 changed files with 4 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
wpilibc/src/main/native/cpp/system/Notifier.cpp
View File

@@ -72,7 +72,7 @@ Notifier::Notifier(int priority, std::function<void()> callback) {
Notifier::~Notifier() {
// atomically set handle to 0, then clean
HAL_NotifierHandle handle = m_notifier.exchange(0);
HAL_NotifierHandle handle = m_notifier.exchange(HAL_INVALID_HANDLE);
HAL_DestroyNotifier(handle);
// Join the thread to ensure the callback has exited.
@@ -83,15 +83,12 @@ Notifier::~Notifier() {
Notifier::Notifier(Notifier&& rhs)
: m_thread(std::move(rhs.m_thread)),
m_notifier(rhs.m_notifier.load()),
m_callback(std::move(rhs.m_callback)) {
rhs.m_notifier = HAL_INVALID_HANDLE;
}
m_notifier(rhs.m_notifier.exchange(HAL_INVALID_HANDLE)),
m_callback(std::move(rhs.m_callback)) {}
Notifier& Notifier::operator=(Notifier&& rhs) {
m_thread = std::move(rhs.m_thread);
m_notifier = rhs.m_notifier.load();
rhs.m_notifier = HAL_INVALID_HANDLE;
m_notifier = rhs.m_notifier.exchange(HAL_INVALID_HANDLE);
m_callback = std::move(rhs.m_callback);
return *this;
}