[build] Make custom CMake macros use lowercase (#5594)

Most of them already do use lowercase, and uppercase is like screaming
at the user.

cmake/modules/GenResources.cmake

@@ -1,26 +1,26 @@
-set(SCRIPTS_DIR "${CMAKE_CURRENT_LIST_DIR}/../scripts")
-MACRO(GENERATE_RESOURCES inputDir outputDir prefix namespace outputFiles)
-  FILE(GLOB inputFiles ${inputDir}/*)
-  SET(${outputFiles})
-  FOREACH(input ${inputFiles})
-    GET_FILENAME_COMPONENT(inputBase ${input} NAME)
-    IF("${inputBase}" MATCHES "^\\.")
-      CONTINUE()
-    ENDIF()
-    SET(output "${outputDir}/${inputBase}.cpp")
-    LIST(APPEND ${outputFiles} "${output}")
+set(scripts_dir "${CMAKE_CURRENT_LIST_DIR}/../scripts")
+macro(generate_resources inputDir outputDir prefix namespace outputFiles)
+  file(GLOB inputFiles ${inputDir}/*)
+  set(${outputFiles})
+  foreach(input ${inputFiles})
+    get_filename_component(inputBase ${input} NAME)
+    if("${inputBase}" MATCHES "^\\.")
+      continue()
+    endif()
+    set(output "${outputDir}/${inputBase}.cpp")
+    list(APPEND ${outputFiles} "${output}")
 
-    ADD_CUSTOM_COMMAND(
+    add_custom_command(
       OUTPUT ${output}
       COMMAND ${CMAKE_COMMAND}
         "-Dinput=${input}"
         "-Doutput=${output}"
         "-Dprefix=${prefix}"
         "-Dnamespace=${namespace}"
-        -P "${SCRIPTS_DIR}/GenResource.cmake"
+        -P "${scripts_dir}/GenResource.cmake"
       MAIN_DEPENDENCY ${input}
-      DEPENDS ${SCRIPTS_DIR}/GenResource.cmake
+      DEPENDS ${scripts_dir}/GenResource.cmake
       VERBATIM
     )
-  ENDFOREACH()
-ENDMACRO()
+  endforeach()
+endmacro()

cmake/modules/SubDirList.cmake

@@ -1,17 +1,17 @@
-MACRO(SUBDIR_LIST result curdir)
-  FILE(GLOB children RELATIVE ${curdir} ${curdir}/*)
-  SET(dirlist "")
-  FOREACH(child ${children})
-    IF(IS_DIRECTORY ${curdir}/${child})
-      LIST(APPEND dirlist ${child})
-    ENDIF()
-  ENDFOREACH()
-  SET(${result} ${dirlist})
-ENDMACRO()
+macro(subdir_list result curdir)
+  file(GLOB children RELATIVE ${curdir} ${curdir}/*)
+  set(dirlist "")
+  foreach(child ${children})
+    if(IS_DIRECTORY ${curdir}/${child})
+      list(APPEND dirlist ${child})
+    endif()
+  endforeach()
+  set(${result} ${dirlist})
+endmacro()
 
-MACRO(ADD_ALL_SUBDIRECTORIES curdir)
-  SUBDIR_LIST (_SUBPROJECTS ${curdir})
-  FOREACH (dir ${_SUBPROJECTS})
-    ADD_SUBDIRECTORY (${dir})
-  ENDFOREACH ()
-ENDMACRO()
+macro(add_all_subdirectories curdir)
+  subdir_list(_SUBPROJECTS ${curdir})
+  foreach(dir ${_SUBPROJECTS})
+    add_subdirectory(${dir})
+  endforeach()
+endmacro()