[commands] Revert SubsystemBase deprecation/removal (#5634)

2026-06-19 00:41:43 +00:00 · 2023-09-14 23:56:48 -04:00
parent bc7f23a632
commit 3b79cb6ed3
80 changed files with 370 additions and 375 deletions
--- a/wpilibcExamples/src/main/cpp/commands/subsystem2/ReplaceMeSubsystem2.h
+++ b/wpilibcExamples/src/main/cpp/commands/subsystem2/ReplaceMeSubsystem2.h
@@ -4,9 +4,9 @@

 #pragma once

-#include <frc2/command/Subsystem.h>
+#include <frc2/command/SubsystemBase.h>

-class ReplaceMeSubsystem2 : public frc2::Subsystem {
+class ReplaceMeSubsystem2 : public frc2::SubsystemBase {
 public:
  ReplaceMeSubsystem2();

--- a/wpilibcExamples/src/main/cpp/examples/ArmBot/include/subsystems/DriveSubsystem.h
+++ b/wpilibcExamples/src/main/cpp/examples/ArmBot/include/subsystems/DriveSubsystem.h
@@ -8,11 +8,11 @@
 #include <frc/drive/DifferentialDrive.h>
 #include <frc/motorcontrol/MotorControllerGroup.h>
 #include <frc/motorcontrol/PWMSparkMax.h>
-#include <frc2/command/Subsystem.h>
+#include <frc2/command/SubsystemBase.h>

 #include "Constants.h"

-class DriveSubsystem : public frc2::Subsystem {
+class DriveSubsystem : public frc2::SubsystemBase {
 public:
  DriveSubsystem();

--- a/wpilibcExamples/src/main/cpp/examples/ArmBotOffboard/include/subsystems/DriveSubsystem.h
+++ b/wpilibcExamples/src/main/cpp/examples/ArmBotOffboard/include/subsystems/DriveSubsystem.h
@@ -11,11 +11,11 @@
 #include <frc/motorcontrol/MotorControllerGroup.h>
 #include <frc/motorcontrol/PWMSparkMax.h>
 #include <frc2/command/Commands.h>
-#include <frc2/command/Subsystem.h>
+#include <frc2/command/SubsystemBase.h>

 #include "Constants.h"

-class DriveSubsystem : public frc2::Subsystem {
+class DriveSubsystem : public frc2::SubsystemBase {
 public:
  DriveSubsystem();

--- a/wpilibcExamples/src/main/cpp/examples/DriveDistanceOffboard/include/subsystems/DriveSubsystem.h
+++ b/wpilibcExamples/src/main/cpp/examples/DriveDistanceOffboard/include/subsystems/DriveSubsystem.h
@@ -8,13 +8,13 @@
 #include <frc/controller/SimpleMotorFeedforward.h>
 #include <frc/drive/DifferentialDrive.h>
 #include <frc/trajectory/TrapezoidProfile.h>
-#include <frc2/command/Subsystem.h>
+#include <frc2/command/SubsystemBase.h>
 #include <units/length.h>

 #include "Constants.h"
 #include "ExampleSmartMotorController.h"

-class DriveSubsystem : public frc2::Subsystem {
+class DriveSubsystem : public frc2::SubsystemBase {
 public:
  DriveSubsystem();

--- a/wpilibcExamples/src/main/cpp/examples/Frisbeebot/include/subsystems/DriveSubsystem.h
+++ b/wpilibcExamples/src/main/cpp/examples/Frisbeebot/include/subsystems/DriveSubsystem.h
@@ -8,11 +8,11 @@
 #include <frc/drive/DifferentialDrive.h>
 #include <frc/motorcontrol/MotorControllerGroup.h>
 #include <frc/motorcontrol/PWMSparkMax.h>
-#include <frc2/command/Subsystem.h>
+#include <frc2/command/SubsystemBase.h>

 #include "Constants.h"

-class DriveSubsystem : public frc2::Subsystem {
+class DriveSubsystem : public frc2::SubsystemBase {
 public:
  DriveSubsystem();

--- a/wpilibcExamples/src/main/cpp/examples/GearsBot/include/subsystems/Claw.h
+++ b/wpilibcExamples/src/main/cpp/examples/GearsBot/include/subsystems/Claw.h
@@ -6,14 +6,14 @@

 #include <frc/DigitalInput.h>
 #include <frc/motorcontrol/PWMSparkMax.h>
-#include <frc2/command/Subsystem.h>
+#include <frc2/command/SubsystemBase.h>

 /**
 * The claw subsystem is a simple system with a motor for opening and closing.
 * If using stronger motors, you should probably use a sensor so that the
 * motors don't stall.
 */
-class Claw : public frc2::Subsystem {
+class Claw : public frc2::SubsystemBase {
 public:
  Claw();

--- a/wpilibcExamples/src/main/cpp/examples/GearsBot/include/subsystems/Drivetrain.h
+++ b/wpilibcExamples/src/main/cpp/examples/GearsBot/include/subsystems/Drivetrain.h
@@ -10,7 +10,7 @@
 #include <frc/drive/DifferentialDrive.h>
 #include <frc/motorcontrol/MotorControllerGroup.h>
 #include <frc/motorcontrol/PWMSparkMax.h>
-#include <frc2/command/Subsystem.h>
+#include <frc2/command/SubsystemBase.h>

 namespace frc {
 class Joystick;
@@ -21,7 +21,7 @@ class Joystick;
 * the robots chassis. These include four drive motors, a left and right encoder
 * and a gyro.
 */
-class Drivetrain : public frc2::Subsystem {
+class Drivetrain : public frc2::SubsystemBase {
 public:
  Drivetrain();

--- a/wpilibcExamples/src/main/cpp/examples/GyroDriveCommands/include/subsystems/DriveSubsystem.h
+++ b/wpilibcExamples/src/main/cpp/examples/GyroDriveCommands/include/subsystems/DriveSubsystem.h
@@ -9,12 +9,12 @@
 #include <frc/drive/DifferentialDrive.h>
 #include <frc/motorcontrol/MotorControllerGroup.h>
 #include <frc/motorcontrol/PWMSparkMax.h>
-#include <frc2/command/Subsystem.h>
+#include <frc2/command/SubsystemBase.h>
 #include <units/angle.h>

 #include "Constants.h"

-class DriveSubsystem : public frc2::Subsystem {
+class DriveSubsystem : public frc2::SubsystemBase {
 public:
  DriveSubsystem();

--- a/wpilibcExamples/src/main/cpp/examples/HatchbotInlined/cpp/subsystems/DriveSubsystem.cpp
+++ b/wpilibcExamples/src/main/cpp/examples/HatchbotInlined/cpp/subsystems/DriveSubsystem.cpp
@@ -47,7 +47,7 @@ void DriveSubsystem::SetMaxOutput(double maxOutput) {
 }

 void DriveSubsystem::InitSendable(wpi::SendableBuilder& builder) {
-  Subsystem::InitSendable(builder);
+  SubsystemBase::InitSendable(builder);

  // Publish encoder distances to telemetry.
  builder.AddDoubleProperty(
--- a/wpilibcExamples/src/main/cpp/examples/HatchbotInlined/cpp/subsystems/HatchSubsystem.cpp
+++ b/wpilibcExamples/src/main/cpp/examples/HatchbotInlined/cpp/subsystems/HatchSubsystem.cpp
@@ -25,7 +25,7 @@ frc2::CommandPtr HatchSubsystem::ReleaseHatchCommand() {
 }

 void HatchSubsystem::InitSendable(wpi::SendableBuilder& builder) {
-  Subsystem::InitSendable(builder);
+  SubsystemBase::InitSendable(builder);

  // Publish the solenoid state to telemetry.
  builder.AddBooleanProperty(
--- a/wpilibcExamples/src/main/cpp/examples/HatchbotInlined/include/subsystems/DriveSubsystem.h
+++ b/wpilibcExamples/src/main/cpp/examples/HatchbotInlined/include/subsystems/DriveSubsystem.h
@@ -8,11 +8,11 @@
 #include <frc/drive/DifferentialDrive.h>
 #include <frc/motorcontrol/MotorControllerGroup.h>
 #include <frc/motorcontrol/PWMSparkMax.h>
-#include <frc2/command/Subsystem.h>
+#include <frc2/command/SubsystemBase.h>

 #include "Constants.h"

-class DriveSubsystem : public frc2::Subsystem {
+class DriveSubsystem : public frc2::SubsystemBase {
 public:
  DriveSubsystem();

--- a/wpilibcExamples/src/main/cpp/examples/HatchbotInlined/include/subsystems/HatchSubsystem.h
+++ b/wpilibcExamples/src/main/cpp/examples/HatchbotInlined/include/subsystems/HatchSubsystem.h
@@ -7,11 +7,11 @@
 #include <frc/DoubleSolenoid.h>
 #include <frc/PneumaticsControlModule.h>
 #include <frc2/command/CommandPtr.h>
-#include <frc2/command/Subsystem.h>
+#include <frc2/command/SubsystemBase.h>

 #include "Constants.h"

-class HatchSubsystem : public frc2::Subsystem {
+class HatchSubsystem : public frc2::SubsystemBase {
 public:
  HatchSubsystem();

--- a/wpilibcExamples/src/main/cpp/examples/HatchbotTraditional/cpp/subsystems/DriveSubsystem.cpp
+++ b/wpilibcExamples/src/main/cpp/examples/HatchbotTraditional/cpp/subsystems/DriveSubsystem.cpp
@@ -47,7 +47,7 @@ void DriveSubsystem::SetMaxOutput(double maxOutput) {
 }

 void DriveSubsystem::InitSendable(wpi::SendableBuilder& builder) {
-  Subsystem::InitSendable(builder);
+  SubsystemBase::InitSendable(builder);

  // Publish encoder distances to telemetry.
  builder.AddDoubleProperty(
--- a/wpilibcExamples/src/main/cpp/examples/HatchbotTraditional/cpp/subsystems/HatchSubsystem.cpp
+++ b/wpilibcExamples/src/main/cpp/examples/HatchbotTraditional/cpp/subsystems/HatchSubsystem.cpp
@@ -21,7 +21,7 @@ void HatchSubsystem::ReleaseHatch() {
 }

 void HatchSubsystem::InitSendable(wpi::SendableBuilder& builder) {
-  Subsystem::InitSendable(builder);
+  SubsystemBase::InitSendable(builder);

  // Publish the solenoid state to telemetry.
  builder.AddBooleanProperty(
--- a/wpilibcExamples/src/main/cpp/examples/HatchbotTraditional/include/subsystems/DriveSubsystem.h
+++ b/wpilibcExamples/src/main/cpp/examples/HatchbotTraditional/include/subsystems/DriveSubsystem.h
@@ -8,11 +8,11 @@
 #include <frc/drive/DifferentialDrive.h>
 #include <frc/motorcontrol/MotorControllerGroup.h>
 #include <frc/motorcontrol/PWMSparkMax.h>
-#include <frc2/command/Subsystem.h>
+#include <frc2/command/SubsystemBase.h>

 #include "Constants.h"

-class DriveSubsystem : public frc2::Subsystem {
+class DriveSubsystem : public frc2::SubsystemBase {
 public:
  DriveSubsystem();

--- a/wpilibcExamples/src/main/cpp/examples/HatchbotTraditional/include/subsystems/HatchSubsystem.h
+++ b/wpilibcExamples/src/main/cpp/examples/HatchbotTraditional/include/subsystems/HatchSubsystem.h
@@ -6,11 +6,11 @@

 #include <frc/DoubleSolenoid.h>
 #include <frc/PneumaticsControlModule.h>
-#include <frc2/command/Subsystem.h>
+#include <frc2/command/SubsystemBase.h>

 #include "Constants.h"

-class HatchSubsystem : public frc2::Subsystem {
+class HatchSubsystem : public frc2::SubsystemBase {
 public:
  HatchSubsystem();

--- a/wpilibcExamples/src/main/cpp/examples/MecanumControllerCommand/include/subsystems/DriveSubsystem.h
+++ b/wpilibcExamples/src/main/cpp/examples/MecanumControllerCommand/include/subsystems/DriveSubsystem.h
@@ -13,11 +13,11 @@
 #include <frc/kinematics/MecanumDriveOdometry.h>
 #include <frc/kinematics/MecanumDriveWheelSpeeds.h>
 #include <frc/motorcontrol/PWMSparkMax.h>
-#include <frc2/command/Subsystem.h>
+#include <frc2/command/SubsystemBase.h>

 #include "Constants.h"

-class DriveSubsystem : public frc2::Subsystem {
+class DriveSubsystem : public frc2::SubsystemBase {
 public:
  DriveSubsystem();

--- a/wpilibcExamples/src/main/cpp/examples/RamseteCommand/include/subsystems/DriveSubsystem.h
+++ b/wpilibcExamples/src/main/cpp/examples/RamseteCommand/include/subsystems/DriveSubsystem.h
@@ -11,12 +11,12 @@
 #include <frc/kinematics/DifferentialDriveOdometry.h>
 #include <frc/motorcontrol/MotorControllerGroup.h>
 #include <frc/motorcontrol/PWMSparkMax.h>
-#include <frc2/command/Subsystem.h>
+#include <frc2/command/SubsystemBase.h>
 #include <units/voltage.h>

 #include "Constants.h"

-class DriveSubsystem : public frc2::Subsystem {
+class DriveSubsystem : public frc2::SubsystemBase {
 public:
  DriveSubsystem();

--- a/wpilibcExamples/src/main/cpp/examples/RapidReactCommandBot/include/subsystems/Drive.h
+++ b/wpilibcExamples/src/main/cpp/examples/RapidReactCommandBot/include/subsystems/Drive.h
@@ -11,12 +11,12 @@
 #include <frc/motorcontrol/MotorControllerGroup.h>
 #include <frc/motorcontrol/PWMSparkMax.h>
 #include <frc2/command/CommandPtr.h>
-#include <frc2/command/Subsystem.h>
+#include <frc2/command/SubsystemBase.h>
 #include <units/length.h>

 #include "Constants.h"

-class Drive : public frc2::Subsystem {
+class Drive : public frc2::SubsystemBase {
 public:
  Drive();
  /**
--- a/wpilibcExamples/src/main/cpp/examples/RapidReactCommandBot/include/subsystems/Intake.h
+++ b/wpilibcExamples/src/main/cpp/examples/RapidReactCommandBot/include/subsystems/Intake.h
@@ -9,11 +9,11 @@
 #include <frc/DoubleSolenoid.h>
 #include <frc/motorcontrol/PWMSparkMax.h>
 #include <frc2/command/CommandPtr.h>
-#include <frc2/command/Subsystem.h>
+#include <frc2/command/SubsystemBase.h>

 #include "Constants.h"

-class Intake : public frc2::Subsystem {
+class Intake : public frc2::SubsystemBase {
 public:
  Intake() = default;

--- a/wpilibcExamples/src/main/cpp/examples/RapidReactCommandBot/include/subsystems/Pneumatics.h
+++ b/wpilibcExamples/src/main/cpp/examples/RapidReactCommandBot/include/subsystems/Pneumatics.h
@@ -8,12 +8,12 @@
 #include <frc/Compressor.h>
 #include <frc/PneumaticsControlModule.h>
 #include <frc2/command/CommandPtr.h>
-#include <frc2/command/Subsystem.h>
+#include <frc2/command/SubsystemBase.h>
 #include <units/pressure.h>

 #include "Constants.h"

-class Pneumatics : frc2::Subsystem {
+class Pneumatics : frc2::SubsystemBase {
 public:
  Pneumatics();
  /** Returns a command that disables the compressor indefinitely. */
--- a/wpilibcExamples/src/main/cpp/examples/RapidReactCommandBot/include/subsystems/Shooter.h
+++ b/wpilibcExamples/src/main/cpp/examples/RapidReactCommandBot/include/subsystems/Shooter.h
@@ -11,13 +11,13 @@
 #include <frc/controller/SimpleMotorFeedforward.h>
 #include <frc/motorcontrol/PWMSparkMax.h>
 #include <frc2/command/CommandPtr.h>
-#include <frc2/command/Subsystem.h>
+#include <frc2/command/SubsystemBase.h>
 #include <units/angle.h>
 #include <units/angular_velocity.h>

 #include "Constants.h"

-class Shooter : public frc2::Subsystem {
+class Shooter : public frc2::SubsystemBase {
 public:
  Shooter();

--- a/wpilibcExamples/src/main/cpp/examples/RapidReactCommandBot/include/subsystems/Storage.h
+++ b/wpilibcExamples/src/main/cpp/examples/RapidReactCommandBot/include/subsystems/Storage.h
@@ -7,11 +7,11 @@
 #include <frc/DigitalInput.h>
 #include <frc/motorcontrol/PWMSparkMax.h>
 #include <frc2/command/CommandPtr.h>
-#include <frc2/command/Subsystem.h>
+#include <frc2/command/SubsystemBase.h>

 #include "Constants.h"

-class Storage : frc2::Subsystem {
+class Storage : frc2::SubsystemBase {
 public:
  Storage();
  /** Returns a command that runs the storage motor indefinitely. */
--- a/wpilibcExamples/src/main/cpp/examples/RomiReference/include/subsystems/Drivetrain.h
+++ b/wpilibcExamples/src/main/cpp/examples/RomiReference/include/subsystems/Drivetrain.h
@@ -8,12 +8,12 @@
 #include <frc/Encoder.h>
 #include <frc/drive/DifferentialDrive.h>
 #include <frc/motorcontrol/Spark.h>
-#include <frc2/command/Subsystem.h>
+#include <frc2/command/SubsystemBase.h>
 #include <units/length.h>

 #include "sensors/RomiGyro.h"

-class Drivetrain : public frc2::Subsystem {
+class Drivetrain : public frc2::SubsystemBase {
 public:
  static constexpr double kCountsPerRevolution = 1440.0;
  static constexpr units::meter_t kWheelDiameter = 70_mm;
--- a/wpilibcExamples/src/main/cpp/examples/RomiReference/include/subsystems/OnBoardIO.h
+++ b/wpilibcExamples/src/main/cpp/examples/RomiReference/include/subsystems/OnBoardIO.h
@@ -8,7 +8,7 @@

 #include <frc/DigitalInput.h>
 #include <frc/DigitalOutput.h>
-#include <frc2/command/Subsystem.h>
+#include <frc2/command/SubsystemBase.h>

 /**
 * This class represents the onboard IO of the Romi
@@ -20,7 +20,7 @@
 * DIO 2 - Button C (input) or Red LED (output)
 * DIO 3 - Yellow LED (output only)
 */
-class OnBoardIO : public frc2::Subsystem {
+class OnBoardIO : public frc2::SubsystemBase {
 public:
  enum ChannelMode { INPUT, OUTPUT };
  OnBoardIO(OnBoardIO::ChannelMode dio1, OnBoardIO::ChannelMode dio2);
--- a/wpilibcExamples/src/main/cpp/examples/StateSpaceDifferentialDriveSimulation/include/subsystems/DriveSubsystem.h
+++ b/wpilibcExamples/src/main/cpp/examples/StateSpaceDifferentialDriveSimulation/include/subsystems/DriveSubsystem.h
@@ -15,12 +15,12 @@
 #include <frc/simulation/DifferentialDrivetrainSim.h>
 #include <frc/simulation/EncoderSim.h>
 #include <frc/smartdashboard/Field2d.h>
-#include <frc2/command/Subsystem.h>
+#include <frc2/command/SubsystemBase.h>
 #include <units/voltage.h>

 #include "Constants.h"

-class DriveSubsystem : public frc2::Subsystem {
+class DriveSubsystem : public frc2::SubsystemBase {
 public:
  DriveSubsystem();

--- a/wpilibcExamples/src/main/cpp/examples/SwerveControllerCommand/include/subsystems/DriveSubsystem.h
+++ b/wpilibcExamples/src/main/cpp/examples/SwerveControllerCommand/include/subsystems/DriveSubsystem.h
@@ -14,12 +14,12 @@
 #include <frc/kinematics/SwerveDriveKinematics.h>
 #include <frc/kinematics/SwerveDriveOdometry.h>
 #include <frc/motorcontrol/PWMSparkMax.h>
-#include <frc2/command/Subsystem.h>
+#include <frc2/command/SubsystemBase.h>

 #include "Constants.h"
 #include "SwerveModule.h"

-class DriveSubsystem : public frc2::Subsystem {
+class DriveSubsystem : public frc2::SubsystemBase {
 public:
  DriveSubsystem();

--- a/wpilibcExamples/src/main/cpp/templates/commandbased/include/subsystems/ExampleSubsystem.h
+++ b/wpilibcExamples/src/main/cpp/templates/commandbased/include/subsystems/ExampleSubsystem.h
@@ -5,9 +5,9 @@
 #pragma once

 #include <frc2/command/CommandPtr.h>
-#include <frc2/command/Subsystem.h>
+#include <frc2/command/SubsystemBase.h>

-class ExampleSubsystem : public frc2::Subsystem {
+class ExampleSubsystem : public frc2::SubsystemBase {
 public:
  ExampleSubsystem();