Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-21 01:01:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

[commands] Java: Fix CommandXboxController.leftTrigger() parameter order (#5831)

Browse Source
This commit is contained in:
Ryan Blue
2023-10-26 22:18:36 -04:00
committed by GitHub
parent ec569a58ef
commit 3ba501f947
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/button/CommandXboxController.java
View File

@@ -261,13 +261,13 @@ public class CommandXboxController extends CommandGenericHID {
* Constructs a Trigger instance around the axis value of the left trigger. The returned trigger
* will be true when the axis value is greater than {@code threshold}.
*
* @param loop the event loop instance to attach the Trigger to.
* @param threshold the minimum axis value for the returned {@link Trigger} to be true. This value
* should be in the range [0, 1] where 0 is the unpressed state of the axis.
* @param loop the event loop instance to attach the Trigger to.
* @return a Trigger instance that is true when the left trigger's axis exceeds the provided
* threshold, attached to the given event loop
*/
public Trigger leftTrigger(EventLoop loop, double threshold) {
public Trigger leftTrigger(double threshold, EventLoop loop) {
return m_hid.leftTrigger(threshold, loop).castTo(Trigger::new);
}
@@ -282,7 +282,7 @@ public class CommandXboxController extends CommandGenericHID {
* button loop}.
*/
public Trigger leftTrigger(double threshold) {
return leftTrigger(CommandScheduler.getInstance().getDefaultButtonLoop(), threshold);
return leftTrigger(threshold, CommandScheduler.getInstance().getDefaultButtonLoop());
}
/**