Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-19 00:41:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

[build] Refactor zip base name generation for consistency (#8831)

Browse Source 
Right now, the `zipBaseName` variable in various publish.gradle files
contains the group ID and artifact ID for use by the combiner, however,
they are also duplicated in `artifactGroupId` and `baseArtifactId`,
leading to potential mistakes if they aren't updated together. This
fixes that by adding a new utility function `makeZipBaseName` to
automatically create the right name given a group ID and artifact ID.
This also fixes publishing for thirdparty subprojects, which didn't
update `zipBaseName`.
This commit is contained in:
Gold856
2026-04-27 14:46:11 -04:00
committed by GitHub
parent 29beacbefe
commit 3bf67edc34
22 changed files with 33 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
msvcruntime/build.gradle
View File

@@ -11,7 +11,7 @@ if (OperatingSystem.current().isWindows()) {
def baseArtifactId = 'runtime'
def artifactGroupId = "org.wpilib.msvc"
def zipBaseName = "_GROUP_org_wpilib_msvc_ID_runtime_CLS"
def zipBaseName = makeZipBaseName(artifactGroupId, baseArtifactId)
def vsLocator = gradle.services.get(VisualStudioLocator)