Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-19 00:41:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

[wpilib, commands] Cache controller BooleanEvents/Triggers and directly construct Triggers (#6738)

Browse Source 
This has been a common footgun for teams, due to calling the factory functions in periodic loops.
This commit is contained in:
Gold856
2024-07-29 10:58:23 -04:00
committed by GitHub
parent 073192d513
commit 3c2bdafd57
21 changed files with 235 additions and 187 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
wpilibNewCommands/src/main/native/cpp/frc2/command/button/CommandJoystick.cpp
View File

@@ -14,11 +14,11 @@ frc::Joystick& CommandJoystick::GetHID() {
}
Trigger CommandJoystick::Trigger(frc::EventLoop* loop) const {
return m_hid.Trigger(loop).CastTo<class Trigger>();
return Button(frc::Joystick::ButtonType::kTriggerButton, loop);
}
Trigger CommandJoystick::Top(frc::EventLoop* loop) const {
return m_hid.Top(loop).CastTo<class Trigger>();
return Button(frc::Joystick::ButtonType::kTopButton, loop);
}
double CommandJoystick::GetMagnitude() const {