Enable checkstyle on cscore, ntcore, wpiutil (#1032)

Also update to version 8.10.

wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/AbstractInterruptTest.java

@@ -7,13 +7,13 @@
 
 package edu.wpi.first.wpilibj;
 
-import org.junit.After;
-import org.junit.Test;
-
 import java.util.concurrent.atomic.AtomicBoolean;
 import java.util.concurrent.atomic.AtomicInteger;
 import java.util.concurrent.atomic.AtomicLong;
 
+import org.junit.After;
+import org.junit.Test;
+
 import edu.wpi.first.wpilibj.test.AbstractComsSetup;
 
 import static org.hamcrest.Matchers.both;

wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/AnalogCrossConnectTest.java

@@ -7,13 +7,13 @@
 
 package edu.wpi.first.wpilibj;
 
+import java.util.logging.Logger;
+
 import org.junit.AfterClass;
 import org.junit.Before;
 import org.junit.BeforeClass;
 import org.junit.Test;
 
-import java.util.logging.Logger;
-
 import edu.wpi.first.wpilibj.AnalogTriggerOutput.AnalogTriggerType;
 import edu.wpi.first.wpilibj.fixtures.AnalogCrossConnectFixture;
 import edu.wpi.first.wpilibj.test.TestBench;

wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/AnalogPotentiometerTest.java

@@ -7,12 +7,12 @@
 
 package edu.wpi.first.wpilibj;
 
+import java.util.logging.Logger;
+
 import org.junit.After;
 import org.junit.Before;
 import org.junit.Test;
 
-import java.util.logging.Logger;
-
 import edu.wpi.first.wpilibj.fixtures.AnalogCrossConnectFixture;
 import edu.wpi.first.wpilibj.mockhardware.FakePotentiometerSource;
 import edu.wpi.first.wpilibj.test.AbstractComsSetup;

wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/BuiltInAccelerometerTest.java

@@ -7,16 +7,16 @@
 
 package edu.wpi.first.wpilibj;
 
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.logging.Logger;
+
 import org.junit.BeforeClass;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.junit.runners.Parameterized;
 import org.junit.runners.Parameterized.Parameters;
 
-import java.util.Arrays;
-import java.util.Collection;
-import java.util.logging.Logger;
-
 import edu.wpi.first.wpilibj.interfaces.Accelerometer;
 import edu.wpi.first.wpilibj.test.AbstractComsSetup;
 

wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/ConstantsPortsTest.java

@@ -7,10 +7,10 @@
 
 package edu.wpi.first.wpilibj;
 
-import org.junit.Test;
-
 import java.util.logging.Logger;
 
+import org.junit.Test;
+
 import edu.wpi.first.wpilibj.test.AbstractComsSetup;
 
 import static org.junit.Assert.assertEquals;

wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/CounterTest.java

@@ -7,6 +7,9 @@
 
 package edu.wpi.first.wpilibj;
 
+import java.util.Collection;
+import java.util.logging.Logger;
+
 import org.junit.AfterClass;
 import org.junit.Before;
 import org.junit.BeforeClass;
@@ -15,9 +18,6 @@ import org.junit.runner.RunWith;
 import org.junit.runners.Parameterized;
 import org.junit.runners.Parameterized.Parameters;
 
-import java.util.Collection;
-import java.util.logging.Logger;
-
 import edu.wpi.first.wpilibj.fixtures.FakeCounterFixture;
 import edu.wpi.first.wpilibj.test.AbstractComsSetup;
 import edu.wpi.first.wpilibj.test.TestBench;

wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/DIOCrossConnectTest.java

@@ -7,6 +7,9 @@
 
 package edu.wpi.first.wpilibj;
 
+import java.util.Collection;
+import java.util.logging.Logger;
+
 import org.junit.After;
 import org.junit.AfterClass;
 import org.junit.Test;
@@ -14,9 +17,6 @@ import org.junit.runner.RunWith;
 import org.junit.runners.Parameterized;
 import org.junit.runners.Parameterized.Parameters;
 
-import java.util.Collection;
-import java.util.logging.Logger;
-
 import edu.wpi.first.wpilibj.fixtures.DIOCrossConnectFixture;
 import edu.wpi.first.wpilibj.test.TestBench;
 

wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/DigitalGlitchFilterTest.java

@@ -7,10 +7,10 @@
 
 package edu.wpi.first.wpilibj;
 
-import org.junit.Test;
-
 import java.util.logging.Logger;
 
+import org.junit.Test;
+
 import edu.wpi.first.wpilibj.test.AbstractComsSetup;
 
 import static org.junit.Assert.assertEquals;

wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/DriverStationTest.java

@@ -7,10 +7,10 @@
 
 package edu.wpi.first.wpilibj;
 
-import org.junit.Test;
-
 import java.util.logging.Logger;
 
+import org.junit.Test;
+
 import edu.wpi.first.wpilibj.test.AbstractComsSetup;
 
 import static org.junit.Assert.assertEquals;

wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/EncoderTest.java

@@ -7,6 +7,9 @@
 
 package edu.wpi.first.wpilibj;
 
+import java.util.Collection;
+import java.util.logging.Logger;
+
 import org.junit.After;
 import org.junit.AfterClass;
 import org.junit.Before;
@@ -15,9 +18,6 @@ import org.junit.runner.RunWith;
 import org.junit.runners.Parameterized;
 import org.junit.runners.Parameterized.Parameters;
 
-import java.util.Collection;
-import java.util.logging.Logger;
-
 import edu.wpi.first.wpilibj.fixtures.FakeEncoderFixture;
 import edu.wpi.first.wpilibj.test.AbstractComsSetup;
 import edu.wpi.first.wpilibj.test.TestBench;

wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/FilterNoiseTest.java

@@ -7,6 +7,10 @@
 
 package edu.wpi.first.wpilibj;
 
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.logging.Logger;
+
 import org.junit.After;
 import org.junit.AfterClass;
 import org.junit.Before;
@@ -15,10 +19,6 @@ import org.junit.runner.RunWith;
 import org.junit.runners.Parameterized;
 import org.junit.runners.Parameterized.Parameters;
 
-import java.util.Arrays;
-import java.util.Collection;
-import java.util.logging.Logger;
-
 import edu.wpi.first.wpilibj.fixtures.FilterNoiseFixture;
 import edu.wpi.first.wpilibj.test.AbstractComsSetup;
 import edu.wpi.first.wpilibj.test.TestBench;

wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/FilterOutputTest.java

@@ -7,6 +7,10 @@
 
 package edu.wpi.first.wpilibj;
 
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.logging.Logger;
+
 import org.junit.After;
 import org.junit.AfterClass;
 import org.junit.Before;
@@ -15,10 +19,6 @@ import org.junit.runner.RunWith;
 import org.junit.runners.Parameterized;
 import org.junit.runners.Parameterized.Parameters;
 
-import java.util.Arrays;
-import java.util.Collection;
-import java.util.logging.Logger;
-
 import edu.wpi.first.wpilibj.fixtures.FilterOutputFixture;
 import edu.wpi.first.wpilibj.test.AbstractComsSetup;
 import edu.wpi.first.wpilibj.test.TestBench;

wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/GyroTest.java

@@ -7,12 +7,12 @@
 
 package edu.wpi.first.wpilibj;
 
+import java.util.logging.Logger;
+
 import org.junit.After;
 import org.junit.Before;
 import org.junit.Test;
 
-import java.util.logging.Logger;
-
 import edu.wpi.first.wpilibj.fixtures.TiltPanCameraFixture;
 import edu.wpi.first.wpilibj.test.AbstractComsSetup;
 import edu.wpi.first.wpilibj.test.TestBench;

wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/MotorEncoderTest.java

@@ -7,6 +7,10 @@
 
 package edu.wpi.first.wpilibj;
 
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.logging.Logger;
+
 import org.junit.After;
 import org.junit.AfterClass;
 import org.junit.Before;
@@ -15,10 +19,6 @@ import org.junit.runner.RunWith;
 import org.junit.runners.Parameterized;
 import org.junit.runners.Parameterized.Parameters;
 
-import java.util.Arrays;
-import java.util.Collection;
-import java.util.logging.Logger;
-
 import edu.wpi.first.wpilibj.filters.LinearDigitalFilter;
 import edu.wpi.first.wpilibj.fixtures.MotorEncoderFixture;
 import edu.wpi.first.wpilibj.test.AbstractComsSetup;

wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/MotorInvertingTest.java

@@ -7,6 +7,10 @@
 
 package edu.wpi.first.wpilibj;
 
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.logging.Logger;
+
 import org.junit.AfterClass;
 import org.junit.Before;
 import org.junit.Test;
@@ -14,10 +18,6 @@ import org.junit.runner.RunWith;
 import org.junit.runners.Parameterized;
 import org.junit.runners.Parameterized.Parameters;
 
-import java.util.Arrays;
-import java.util.Collection;
-import java.util.logging.Logger;
-
 import edu.wpi.first.wpilibj.fixtures.MotorEncoderFixture;
 import edu.wpi.first.wpilibj.test.AbstractComsSetup;
 import edu.wpi.first.wpilibj.test.TestBench;

wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/PCMTest.java

@@ -7,13 +7,13 @@
 
 package edu.wpi.first.wpilibj;
 
+import java.util.logging.Logger;
+
 import org.junit.AfterClass;
 import org.junit.Before;
 import org.junit.BeforeClass;
 import org.junit.Test;
 
-import java.util.logging.Logger;
-
 import edu.wpi.first.wpilibj.test.AbstractComsSetup;
 
 import static org.junit.Assert.assertEquals;

wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/PDPTest.java

@@ -7,6 +7,10 @@
 
 package edu.wpi.first.wpilibj;
 
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.logging.Logger;
+
 import org.junit.After;
 import org.junit.AfterClass;
 import org.junit.BeforeClass;
@@ -15,10 +19,6 @@ import org.junit.runner.RunWith;
 import org.junit.runners.Parameterized;
 import org.junit.runners.Parameterized.Parameters;
 
-import java.util.Arrays;
-import java.util.Collection;
-import java.util.logging.Logger;
-
 import edu.wpi.first.wpilibj.can.CANMessageNotFoundException;
 import edu.wpi.first.wpilibj.fixtures.MotorEncoderFixture;
 import edu.wpi.first.wpilibj.test.AbstractComsSetup;

wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/PIDTest.java

@@ -7,6 +7,11 @@
 
 package edu.wpi.first.wpilibj;
 
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.logging.Logger;
+
 import org.junit.After;
 import org.junit.AfterClass;
 import org.junit.Before;
@@ -16,11 +21,6 @@ import org.junit.runner.RunWith;
 import org.junit.runners.Parameterized;
 import org.junit.runners.Parameterized.Parameters;
 
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.Collection;
-import java.util.logging.Logger;
-
 import edu.wpi.first.networktables.NetworkTable;
 import edu.wpi.first.networktables.NetworkTableInstance;
 import edu.wpi.first.wpilibj.fixtures.MotorEncoderFixture;

wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/PreferencesTest.java

@@ -7,16 +7,16 @@
 
 package edu.wpi.first.wpilibj;
 
-import java.util.Arrays;
-import org.junit.Before;
-import org.junit.Test;
-
 import java.io.File;
 import java.io.FileOutputStream;
 import java.io.IOException;
 import java.io.OutputStream;
+import java.util.Arrays;
 import java.util.logging.Logger;
 
+import org.junit.Before;
+import org.junit.Test;
+
 import edu.wpi.first.wpilibj.networktables.NetworkTable;
 import edu.wpi.first.wpilibj.test.AbstractComsSetup;
 

wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/RelayCrossConnectTest.java

@@ -7,12 +7,12 @@
 
 package edu.wpi.first.wpilibj;
 
+import java.util.logging.Logger;
+
 import org.junit.After;
 import org.junit.Before;
 import org.junit.Test;
 
-import java.util.logging.Logger;
-
 import edu.wpi.first.networktables.NetworkTable;
 import edu.wpi.first.networktables.NetworkTableInstance;
 import edu.wpi.first.wpilibj.Relay.Direction;

wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/RobotDriveTest.java

@@ -7,16 +7,15 @@
 
 package edu.wpi.first.wpilibj;
 
+import java.util.logging.Logger;
+
 import org.junit.BeforeClass;
 import org.junit.Test;
 
 import edu.wpi.first.wpilibj.drive.DifferentialDrive;
 import edu.wpi.first.wpilibj.drive.MecanumDrive;
-
 import edu.wpi.first.wpilibj.test.AbstractComsSetup;
 
-import java.util.logging.Logger;
-
 import static org.junit.Assert.assertEquals;
 
 /**

wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/SampleTest.java

@@ -7,13 +7,13 @@
 
 package edu.wpi.first.wpilibj;
 
+import java.util.logging.Logger;
+
 import org.junit.AfterClass;
 import org.junit.Before;
 import org.junit.BeforeClass;
 import org.junit.Test;
 
-import java.util.logging.Logger;
-
 import edu.wpi.first.wpilibj.fixtures.SampleFixture;
 import edu.wpi.first.wpilibj.test.AbstractComsSetup;
 

wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/TimerTest.java

@@ -7,10 +7,10 @@
 
 package edu.wpi.first.wpilibj;
 
-import org.junit.Test;
-
 import java.util.logging.Logger;
 
+import org.junit.Test;
+
 import edu.wpi.first.wpilibj.test.AbstractComsSetup;
 
 import static org.junit.Assert.assertEquals;

wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/smartdashboard/SmartDashboardTest.java

@@ -7,11 +7,11 @@
 
 package edu.wpi.first.wpilibj.smartdashboard;
 
+import java.util.logging.Logger;
+
 import org.junit.Ignore;
 import org.junit.Test;
 
-import java.util.logging.Logger;
-
 import edu.wpi.first.wpilibj.networktables.NetworkTable;
 import edu.wpi.first.wpilibj.test.AbstractComsSetup;
 

wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/test/AbstractComsSetup.java

@@ -7,15 +7,15 @@
 
 package edu.wpi.first.wpilibj.test;
 
+import java.util.logging.Level;
+import java.util.logging.Logger;
+
 import org.junit.BeforeClass;
 import org.junit.Rule;
 import org.junit.rules.TestWatcher;
 import org.junit.runner.Description;
 import org.junit.runners.model.MultipleFailureException;
 
-import java.util.logging.Level;
-import java.util.logging.Logger;
-
 import edu.wpi.first.wpilibj.DriverStation;
 import edu.wpi.first.wpilibj.MockDS;
 import edu.wpi.first.wpilibj.RobotBase;

wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/test/AbstractTestSuite.java

@@ -7,11 +7,6 @@
 
 package edu.wpi.first.wpilibj.test;
 
-import org.junit.Ignore;
-import org.junit.Test;
-import org.junit.runner.Request;
-import org.junit.runners.Suite.SuiteClasses;
-
 import java.lang.reflect.Method;
 import java.util.List;
 import java.util.Vector;
@@ -19,6 +14,11 @@ import java.util.logging.Level;
 import java.util.logging.Logger;
 import java.util.regex.Pattern;
 
+import org.junit.Ignore;
+import org.junit.Test;
+import org.junit.runner.Request;
+import org.junit.runners.Suite.SuiteClasses;
+
 /**
  * Allows tests suites and tests to be run selectively from the command line using a regex text
  * pattern.

wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/test/AbstractTestSuiteTest.java

@@ -7,6 +7,8 @@
 
 package edu.wpi.first.wpilibj.test;
 
+import java.util.List;
+
 import org.junit.Before;
 import org.junit.Ignore;
 import org.junit.Test;
@@ -15,8 +17,6 @@ import org.junit.runners.Suite;
 import org.junit.runners.Suite.SuiteClasses;
 import org.junit.runners.model.InitializationError;
 
-import java.util.List;
-
 import edu.wpi.first.wpilibj.test.AbstractTestSuite.ClassMethodPair;
 
 import static org.hamcrest.MatcherAssert.assertThat;

wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/test/AntJunitLanucher.java

@@ -7,6 +7,8 @@
 
 package edu.wpi.first.wpilibj.test;
 
+import java.io.File;
+
 import org.apache.tools.ant.BuildLogger;
 import org.apache.tools.ant.DefaultLogger;
 import org.apache.tools.ant.Project;
@@ -14,8 +16,6 @@ import org.apache.tools.ant.taskdefs.optional.junit.FormatterElement;
 import org.apache.tools.ant.taskdefs.optional.junit.JUnitTask;
 import org.apache.tools.ant.taskdefs.optional.junit.JUnitTest;
 
-import java.io.File;
-
 /**
  * Provides an entry point for tests to run with ANT. This allows ant to output JUnit XML test
  * results for Jenkins.

wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/test/QuickTest.java

@@ -7,10 +7,10 @@
 
 package edu.wpi.first.wpilibj.test;
 
-import org.junit.Test;
-
 import java.util.logging.Logger;
 
+import org.junit.Test;
+
 /**
  * This class is designated to allow for simple testing of the library without the overlying testing
  * framework. This test is NOT run as a normal part of the testing process and must be explicitly

wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/test/RepeatRule.java

@@ -7,14 +7,14 @@
 
 package edu.wpi.first.wpilibj.test;
 
-import org.junit.rules.TestRule;
-import org.junit.runner.Description;
-import org.junit.runners.model.Statement;
-
 import java.lang.annotation.Retention;
 import java.lang.annotation.RetentionPolicy;
 import java.lang.annotation.Target;
 
+import org.junit.rules.TestRule;
+import org.junit.runner.Description;
+import org.junit.runners.model.Statement;
+
 /**
  * This JUnit Rule allows you to apply this rule to any test to allow it to run multiple times. This
  * is important if you have a test that fails only "sometimes" and needs to be rerun to find the

wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/test/TestSuite.java

@@ -7,16 +7,6 @@
 
 package edu.wpi.first.wpilibj.test;
 
-import junit.framework.JUnit4TestAdapter;
-import junit.runner.Version;
-
-import org.junit.runner.JUnitCore;
-import org.junit.runner.Result;
-import org.junit.runner.RunWith;
-import org.junit.runner.notification.Failure;
-import org.junit.runners.Suite;
-import org.junit.runners.Suite.SuiteClasses;
-
 import java.io.IOException;
 import java.io.InputStream;
 import java.util.ArrayList;
@@ -27,6 +17,16 @@ import java.util.logging.LogManager;
 import java.util.logging.Logger;
 import java.util.regex.Pattern;
 
+import org.junit.runner.JUnitCore;
+import org.junit.runner.Result;
+import org.junit.runner.RunWith;
+import org.junit.runner.notification.Failure;
+import org.junit.runners.Suite;
+import org.junit.runners.Suite.SuiteClasses;
+
+import junit.framework.JUnit4TestAdapter;
+import junit.runner.Version;
+
 import edu.wpi.first.wpilibj.WpiLibJTestSuite;
 import edu.wpi.first.wpilibj.command.CommandTestSuite;
 import edu.wpi.first.wpilibj.smartdashboard.SmartDashboardTestSuite;