[hal] Refactor REV PDH (#3775)

Browse Source

Refactors retrieving the faults from the device to match the implementation that we have for the Pneumatic Hub. Instead of having a getter function for each fault, there is a single function to get all faults (sticky or normal) for use with the higher level API

Renames functions to be consistent

Removes some functions that don't need to be included in wpilib:
- Identify device - this just flashes the module LED on the device and has no use in wpilib
- Is PDH enabled - the PDH does not change state depending on robot enabled state

PDH frame and signal names were updated in our DBC, and this PR makes use of the newly generated CAN frame helper functions

...

This commit is contained in:

Jan-Felix Abellera

2021-12-09 14:27:06 -06:00

committed by GitHub

parent 7269a170fb

commit 41d26bee8d

5 changed files with 2076 additions and 1624 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

1120

hal/src/main/native/athena/rev/PDHFrames.cpp

File diff suppressed because it is too large Load Diff