From 423fd75fa806ae8abf36c1219b24f16639268fa9 Mon Sep 17 00:00:00 2001 From: Starlight220 <53231611+Starlight220@users.noreply.github.com> Date: Thu, 23 Nov 2023 20:56:47 +0200 Subject: [PATCH] [wpilib] Default LiveWindowEnabledInTest to false (#5950) --- wpilibc/src/main/native/include/frc/IterativeRobotBase.h | 4 ++-- .../main/java/edu/wpi/first/wpilibj/IterativeRobotBase.java | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/wpilibc/src/main/native/include/frc/IterativeRobotBase.h b/wpilibc/src/main/native/include/frc/IterativeRobotBase.h index 42b0c715df..79c1de2cbc 100644 --- a/wpilibc/src/main/native/include/frc/IterativeRobotBase.h +++ b/wpilibc/src/main/native/include/frc/IterativeRobotBase.h @@ -215,7 +215,7 @@ class IterativeRobotBase : public RobotBase { /** * Sets whether LiveWindow operation is enabled during test mode. * - * @param testLW True to enable, false to disable. Defaults to true. + * @param testLW True to enable, false to disable. Defaults to false. * @throws if called in test mode. */ void EnableLiveWindowInTest(bool testLW); @@ -252,7 +252,7 @@ class IterativeRobotBase : public RobotBase { units::second_t m_period; Watchdog m_watchdog; bool m_ntFlushEnabled = true; - bool m_lwEnabledInTest = true; + bool m_lwEnabledInTest = false; bool m_calledDsConnected = false; void PrintLoopOverrunMessage(); diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/IterativeRobotBase.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/IterativeRobotBase.java index 4afece468d..bbc98a4108 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/IterativeRobotBase.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/IterativeRobotBase.java @@ -70,7 +70,7 @@ public abstract class IterativeRobotBase extends RobotBase { private final double m_period; private final Watchdog m_watchdog; private boolean m_ntFlushEnabled = true; - private boolean m_lwEnabledInTest = true; + private boolean m_lwEnabledInTest; private boolean m_calledDsConnected; /** @@ -260,7 +260,7 @@ public abstract class IterativeRobotBase extends RobotBase { /** * Sets whether LiveWindow operation is enabled during test mode. Calling * - * @param testLW True to enable, false to disable. Defaults to true. + * @param testLW True to enable, false to disable. Defaults to false. * @throws ConcurrentModificationException if this is called during test mode. */ public void enableLiveWindowInTest(boolean testLW) {