Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-24 01:31:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

[hal] Refactor C++ handle closing; check for invalid handle before closing (#7016)

Browse Source 
Adds a close function pointer template parameter to hal::Handle.  This allows default destructors in many places.
The status parameter has been removed from close functions; in most places it was not used. Where it was, an error is printed instead.
This commit is contained in:
Ryan Blue
2024-09-07 13:58:15 -04:00
committed by GitHub
parent 80f3813908
commit 496e7c1bba
94 changed files with 247 additions and 425 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
hal/src/main/native/cpp/jni/SerialPortJNI.cpp
View File

@@ -306,9 +306,9 @@ JNIEXPORT void JNICALL
Java_edu_wpi_first_hal_SerialPortJNI_serialClose
(JNIEnv* env, jclass, jint handle)
{
int32_t status = 0;
HAL_CloseSerial(static_cast<HAL_SerialPortHandle>(handle), &status);
CheckStatus(env, status);
if (handle != HAL_kInvalidHandle) {
HAL_CloseSerial(static_cast<HAL_SerialPortHandle>(handle));
}
}
} // extern "C"