[hal] Refactor C++ handle closing; check for invalid handle before closing (#7016)

Adds a close function pointer template parameter to hal::Handle.  This allows default destructors in many places.
The status parameter has been removed from close functions; in most places it was not used. Where it was, an error is printed instead.
This commit is contained in:
Ryan Blue
2024-09-07 13:58:15 -04:00
committed by GitHub
parent 80f3813908
commit 496e7c1bba
94 changed files with 247 additions and 425 deletions

View File

@@ -6,7 +6,7 @@
#include <stdint.h>
#include <hal/CANAPITypes.h>
#include <hal/CANAPI.h>
namespace frc {
struct CANData {
@@ -50,11 +50,6 @@ class CAN {
*/
CAN(int deviceId, int deviceManufacturer, int deviceType);
/**
* Closes the CAN communication.
*/
~CAN();
CAN(CAN&&) = default;
CAN& operator=(CAN&&) = default;
@@ -178,6 +173,6 @@ class CAN {
HAL_CAN_Dev_kMiscellaneous;
private:
hal::Handle<HAL_CANHandle> m_handle;
hal::Handle<HAL_CANHandle, HAL_CleanCAN> m_handle;
};
} // namespace frc