mirror of
https://github.com/wpilibsuite/allwpilib
synced 2026-06-28 02:11:43 +00:00
[hal] Refactor C++ handle closing; check for invalid handle before closing (#7016)
Adds a close function pointer template parameter to hal::Handle. This allows default destructors in many places. The status parameter has been removed from close functions; in most places it was not used. Where it was, an error is printed instead.
This commit is contained in:
@@ -6,6 +6,7 @@
|
||||
|
||||
#include <memory>
|
||||
|
||||
#include <hal/Counter.h>
|
||||
#include <hal/Types.h>
|
||||
#include <units/time.h>
|
||||
#include <wpi/sendable/Sendable.h>
|
||||
@@ -142,11 +143,11 @@ class Counter : public CounterBase,
|
||||
Counter(EncodingType encodingType, std::shared_ptr<DigitalSource> upSource,
|
||||
std::shared_ptr<DigitalSource> downSource, bool inverted);
|
||||
|
||||
~Counter() override;
|
||||
|
||||
Counter(Counter&&) = default;
|
||||
Counter& operator=(Counter&&) = default;
|
||||
|
||||
~Counter() override;
|
||||
|
||||
/**
|
||||
* Set the up source for the counter as a digital input channel.
|
||||
*
|
||||
@@ -458,7 +459,7 @@ class Counter : public CounterBase,
|
||||
std::shared_ptr<DigitalSource> m_downSource;
|
||||
|
||||
/// The FPGA counter object
|
||||
hal::Handle<HAL_CounterHandle> m_counter;
|
||||
hal::Handle<HAL_CounterHandle, HAL_FreeCounter> m_counter;
|
||||
|
||||
private:
|
||||
/// The index of this counter.
|
||||
|
||||
Reference in New Issue
Block a user