Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-19 00:41:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

[wpilib,cmd] Rename gamepad shoulder to bumper (#8573)

Browse Source 
Both programs used bumper, so we shouldn't rename it. There's no reason
to change it, and we don't need to match SDL.
This commit is contained in:
Thad House
2026-02-07 10:39:22 -08:00
committed by GitHub
parent 19c61cc419
commit 4aa21e947d
24 changed files with 179 additions and 182 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
commandsv3/src/main/java/org/wpilib/command3/button/CommandGamepad.java
View File

@@ -266,51 +266,51 @@ public class CommandGamepad extends CommandGenericHID {
}
/**
* Constructs a Trigger instance around the right shoulder button's digital signal.
* Constructs a Trigger instance around the right bumper button's digital signal.
*
* @return a Trigger instance representing the right shoulder button's digital signal attached to
* @return a Trigger instance representing the right bumper button's digital signal attached to
* the {@link Scheduler#getDefaultEventLoop() default scheduler event loop} on the scheduler
* passed to the controller's constructor, or the {@link Scheduler#getDefault default
* scheduler} if a scheduler was not explicitly provided.
* @see #leftShoulder(EventLoop)
* @see #leftBumper(EventLoop)
*/
public Trigger leftShoulder() {
return leftShoulder(getScheduler().getDefaultEventLoop());
public Trigger leftBumper() {
return leftBumper(getScheduler().getDefaultEventLoop());
}
/**
* Constructs a Trigger instance around the right shoulder button's digital signal.
* Constructs a Trigger instance around the right bumper button's digital signal.
*
* @param loop the event loop instance to attach the event to.
* @return a Trigger instance representing the right shoulder button's digital signal attached to
* @return a Trigger instance representing the right bumper button's digital signal attached to
* the given loop.
*/
public Trigger leftShoulder(EventLoop loop) {
return button(Gamepad.Button.kLeftShoulder.value, loop);
public Trigger leftBumper(EventLoop loop) {
return button(Gamepad.Button.kLeftBumper.value, loop);
}
/**
* Constructs a Trigger instance around the right shoulder button's digital signal.
* Constructs a Trigger instance around the right bumper button's digital signal.
*
* @return a Trigger instance representing the right shoulder button's digital signal attached to
* @return a Trigger instance representing the right bumper button's digital signal attached to
* the {@link Scheduler#getDefaultEventLoop() default scheduler event loop} on the scheduler
* passed to the controller's constructor, or the {@link Scheduler#getDefault default
* scheduler} if a scheduler was not explicitly provided.
* @see #rightShoulder(EventLoop)
* @see #rightBumper(EventLoop)
*/
public Trigger rightShoulder() {
return rightShoulder(getScheduler().getDefaultEventLoop());
public Trigger rightBumper() {
return rightBumper(getScheduler().getDefaultEventLoop());
}
/**
* Constructs a Trigger instance around the right shoulder button's digital signal.
* Constructs a Trigger instance around the right bumper button's digital signal.
*
* @param loop the event loop instance to attach the event to.
* @return a Trigger instance representing the right shoulder button's digital signal attached to
* @return a Trigger instance representing the right bumper button's digital signal attached to
* the given loop.
*/
public Trigger rightShoulder(EventLoop loop) {
return button(Gamepad.Button.kRightShoulder.value, loop);
public Trigger rightBumper(EventLoop loop) {
return button(Gamepad.Button.kRightBumper.value, loop);
}
/**