Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-22 01:11:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Storage: Use std::forward and emplace for updates.

Browse Source
This commit is contained in:
Peter Johnson
2015-07-21 22:43:44 -07:00
parent bb5848a033
commit 4aa2d65bba
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/Storage.h
View File

@@ -82,8 +82,10 @@ class Storage {
~Storage();
struct Update {
std::shared_ptr<StorageEntry> entry;
enum Kind { kAssign, kValueUpdate, kFlagsUpdate, kDelete, kDeleteAll };
Update(std::shared_ptr<StorageEntry> entry_, Kind kind_)
: entry(entry_), kind(kind_) {}
std::shared_ptr<StorageEntry> entry;
Kind kind;
};
typedef ConcurrentQueue<Update> UpdateQueue;
@@ -117,9 +119,9 @@ class Storage {
Storage(const Storage&) = delete;
Storage& operator=(const Storage&) = delete;
void AddUpdate(std::shared_ptr<StorageEntry> entry, Update::Kind kind) {
if (m_updates_enabled)
m_updates.push(Update{entry, kind});
template <typename... Args>
void AddUpdate(Args&&... args) {
if (m_updates_enabled) m_updates.emplace(std::forward<Args>(args)...);
}
typedef llvm::StringMap<std::shared_ptr<StorageEntry>> EntriesMap;