From 4aca3c202265f14bf9e7da4569fb4f0a84b19b7e Mon Sep 17 00:00:00 2001 From: Tyler Veness Date: Thu, 26 May 2016 12:59:34 -0700 Subject: [PATCH] Removed extraneous curly braces around std::lock_guards in PIDController class (#78) --- wpilibc/athena/src/PIDController.cpp | 32 +++++++++++----------------- 1 file changed, 12 insertions(+), 20 deletions(-) diff --git a/wpilibc/athena/src/PIDController.cpp b/wpilibc/athena/src/PIDController.cpp index 9346679ad2..317f4cce8f 100644 --- a/wpilibc/athena/src/PIDController.cpp +++ b/wpilibc/athena/src/PIDController.cpp @@ -338,11 +338,9 @@ void PIDController::SetInputRange(float minimumInput, float maximumInput) { * @param maximumOutput the maximum value to write to the output */ void PIDController::SetOutputRange(float minimumOutput, float maximumOutput) { - { - std::lock_guard sync(m_mutex); - m_minimumOutput = minimumOutput; - m_maximumOutput = maximumOutput; - } + std::lock_guard sync(m_mutex); + m_minimumOutput = minimumOutput; + m_maximumOutput = maximumOutput; } /** @@ -451,11 +449,9 @@ float PIDController::GetAvgError() const { * @param percentage error which is tolerable */ void PIDController::SetTolerance(float percent) { - { - std::lock_guard sync(m_mutex); - m_toleranceType = kPercentTolerance; - m_tolerance = percent; - } + std::lock_guard sync(m_mutex); + m_toleranceType = kPercentTolerance; + m_tolerance = percent; } /* @@ -465,11 +461,9 @@ void PIDController::SetTolerance(float percent) { * @param percentage error which is tolerable */ void PIDController::SetPercentTolerance(float percent) { - { - std::lock_guard sync(m_mutex); - m_toleranceType = kPercentTolerance; - m_tolerance = percent; - } + std::lock_guard sync(m_mutex); + m_toleranceType = kPercentTolerance; + m_tolerance = percent; } /* @@ -479,11 +473,9 @@ void PIDController::SetPercentTolerance(float percent) { * @param percentage error which is tolerable */ void PIDController::SetAbsoluteTolerance(float absTolerance) { - { - std::lock_guard sync(m_mutex); - m_toleranceType = kAbsoluteTolerance; - m_tolerance = absTolerance; - } + std::lock_guard sync(m_mutex); + m_toleranceType = kAbsoluteTolerance; + m_tolerance = absTolerance; } /*