Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-20 00:51:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't delete persistent entries in DeleteAllEntries. (#71)

Browse Source 
This is a behavior change but without it DeleteAllEntries is dangerous and
not very useful, so I consider the current behavior to be a bug.
This commit is contained in:
Peter Johnson
2016-06-17 22:33:02 -07:00
committed by GitHub
parent c7d9ecbab3
commit 4b516de183
3 changed files with 40 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
test/unit/StorageTest.cpp
View File

@@ -387,6 +387,19 @@ TEST_P(StorageTestPopulated, DeleteAllEntries) {
EXPECT_EQ(Message::kClearEntries, msg->type());
}
TEST_P(StorageTestPopulated, DeleteAllEntriesPersistent) {
GetEntry("foo2")->flags = NT_PERSISTENT;
storage.DeleteAllEntries();
ASSERT_EQ(1u, entries().size());
EXPECT_EQ(1u, entries().count("foo2"));
ASSERT_EQ(1u, outgoing.size());
EXPECT_FALSE(outgoing[0].only);
EXPECT_FALSE(outgoing[0].except);
auto msg = outgoing[0].msg;
EXPECT_EQ(Message::kClearEntries, msg->type());
}
TEST_P(StorageTestPopulated, GetEntryInfoAll) {
auto info = storage.GetEntryInfo("", 0u);
ASSERT_EQ(4u, info.size());