Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-07-02 02:51:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ntcore] Revert to per-element copy for toNative() (#3621)

Browse Source 
arraycopy() does not unbox values, so throws an exception.

This was broken in #3419 due to a false positive in PMD
(see https://sourceforge.net/p/pmd/bugs/804/).
This commit is contained in:
Peter Johnson
2021-10-10 15:53:35 -07:00
committed by GitHub
parent 7b3f62244f
commit 4c61a13057
1 changed files with 18 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
ntcore/src/main/java/edu/wpi/first/networktables/NetworkTableValue.java
View File

@@ -478,27 +478,41 @@ public final class NetworkTableValue {
return Objects.hash(m_type, m_value);
}
// arraycopy() doesn't know how to unwrap boxed values; this is a false positive in PMD
// (see https://sourceforge.net/p/pmd/bugs/804/)
@SuppressWarnings("PMD.AvoidArrayLoops")
static boolean[] toNative(Boolean[] arr) {
boolean[] out = new boolean[arr.length];
System.arraycopy(arr, 0, out, 0, arr.length);
for (int i = 0; i < arr.length; i++) {
out[i] = arr[i];
}
return out;
}
@SuppressWarnings("PMD.AvoidArrayLoops")
static double[] toNative(Number[] arr) {
double[] out = new double[arr.length];
System.arraycopy(arr, 0, out, 0, arr.length);
for (int i = 0; i < arr.length; i++) {
out[i] = arr[i].doubleValue();
}
return out;
}
@SuppressWarnings("PMD.AvoidArrayLoops")
static Boolean[] fromNative(boolean[] arr) {
Boolean[] out = new Boolean[arr.length];
System.arraycopy(arr, 0, out, 0, arr.length);
for (int i = 0; i < arr.length; i++) {
out[i] = arr[i];
}
return out;
}
@SuppressWarnings("PMD.AvoidArrayLoops")
static Double[] fromNative(double[] arr) {
Double[] out = new Double[arr.length];
System.arraycopy(arr, 0, out, 0, arr.length);
for (int i = 0; i < arr.length; i++) {
out[i] = arr[i];
}
return out;
}