From 4d0b67d293aae53a010988da82372737d8e4e3c3 Mon Sep 17 00:00:00 2001 From: Matt Morley Date: Fri, 27 Feb 2026 17:27:59 -0500 Subject: [PATCH] [wpinet] Fix uv_tcp_keepalive to take seconds (#8639) [Libuv docs](https://docs.libuv.org/en/v1.x/tcp.html) states: > Enable / disable TCP keep-alive. delay is the initial delay in seconds, ignored when enable is zero. But we used std::milli, leading to being off by a factor of 1000. --- wpinet/src/main/native/include/wpi/net/uv/Tcp.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/wpinet/src/main/native/include/wpi/net/uv/Tcp.hpp b/wpinet/src/main/native/include/wpi/net/uv/Tcp.hpp index 2780f06c82..de04c01cc0 100644 --- a/wpinet/src/main/native/include/wpi/net/uv/Tcp.hpp +++ b/wpinet/src/main/native/include/wpi/net/uv/Tcp.hpp @@ -27,7 +27,7 @@ class Tcp final : public NetworkStreamImpl { struct private_init {}; public: - using Time = std::chrono::duration; + using Time = std::chrono::seconds; explicit Tcp(const private_init&) {} ~Tcp() noexcept override = default;