[wpilibc] Use std::string_view instead of Twine (#3380)

Use fmtlib where needed for string formatting into std::string_view.

wpilibNewCommands/src/main/native/cpp/frc2/command/CommandBase.cpp

@@ -30,7 +30,7 @@ wpi::SmallSet<Subsystem*, 4> CommandBase::GetRequirements() const {
   return m_requirements;
 }
 
-void CommandBase::SetName(const wpi::Twine& name) {
+void CommandBase::SetName(std::string_view name) {
   frc::SendableRegistry::GetInstance().SetName(this, name);
 }
 
@@ -42,7 +42,7 @@ std::string CommandBase::GetSubsystem() const {
   return frc::SendableRegistry::GetInstance().GetSubsystem(this);
 }
 
-void CommandBase::SetSubsystem(const wpi::Twine& subsystem) {
+void CommandBase::SetSubsystem(std::string_view subsystem) {
   frc::SendableRegistry::GetInstance().SetSubsystem(this, subsystem);
 }
 

wpilibNewCommands/src/main/native/cpp/frc2/command/PrintCommand.cpp

@@ -8,9 +8,9 @@
 
 using namespace frc2;
 
-PrintCommand::PrintCommand(const wpi::Twine& message)
-    : CommandHelper{[str = message.str()] { wpi::outs() << str << "\n"; }, {}} {
-}
+PrintCommand::PrintCommand(std::string_view message)
+    : CommandHelper{
+          [str = std::string(message)] { wpi::outs() << str << "\n"; }, {}} {}
 
 bool PrintCommand::RunsWhenDisabled() const {
   return true;

wpilibNewCommands/src/main/native/cpp/frc2/command/SubsystemBase.cpp

@@ -51,7 +51,7 @@ std::string SubsystemBase::GetName() const {
   return frc::SendableRegistry::GetInstance().GetName(this);
 }
 
-void SubsystemBase::SetName(const wpi::Twine& name) {
+void SubsystemBase::SetName(std::string_view name) {
   frc::SendableRegistry::GetInstance().SetName(this, name);
 }
 
@@ -59,7 +59,7 @@ std::string SubsystemBase::GetSubsystem() const {
   return frc::SendableRegistry::GetInstance().GetSubsystem(this);
 }
 
-void SubsystemBase::SetSubsystem(const wpi::Twine& name) {
+void SubsystemBase::SetSubsystem(std::string_view name) {
   frc::SendableRegistry::GetInstance().SetSubsystem(this, name);
 }
 

wpilibNewCommands/src/main/native/cpp/frc2/command/WaitCommand.cpp

@@ -4,11 +4,13 @@
 
 #include "frc2/command/WaitCommand.h"
 
+#include <fmt/format.h>
+
 using namespace frc2;
 
 WaitCommand::WaitCommand(units::second_t duration) : m_duration{duration} {
   auto durationStr = std::to_string(duration.to<double>());
-  SetName(wpi::Twine(GetName()) + ": " + wpi::Twine(durationStr) + " seconds");
+  SetName(fmt::format("{}: {} seconds", GetName(), durationStr));
 }
 
 void WaitCommand::Initialize() {

wpilibNewCommands/src/main/native/cpp/frc2/command/button/NetworkButton.cpp

@@ -12,9 +12,9 @@ NetworkButton::NetworkButton(nt::NetworkTableEntry entry)
       }) {}
 
 NetworkButton::NetworkButton(std::shared_ptr<nt::NetworkTable> table,
-                             const wpi::Twine& field)
+                             std::string_view field)
     : NetworkButton(table->GetEntry(field)) {}
 
-NetworkButton::NetworkButton(const wpi::Twine& table, const wpi::Twine& field)
+NetworkButton::NetworkButton(std::string_view table, std::string_view field)
     : NetworkButton(nt::NetworkTableInstance::GetDefault().GetTable(table),
                     field) {}

wpilibNewCommands/src/main/native/include/frc2/command/CommandBase.h

@@ -6,12 +6,12 @@
 
 #include <initializer_list>
 #include <string>
+#include <string_view>
 
 #include <frc/smartdashboard/Sendable.h>
 #include <frc/smartdashboard/SendableHelper.h>
 #include <wpi/ArrayRef.h>
 #include <wpi/SmallSet.h>
-#include <wpi/Twine.h>
 
 #include "frc2/command/Command.h"
 
@@ -46,7 +46,7 @@ class CommandBase : public Command,
    *
    * @param name name
    */
-  void SetName(const wpi::Twine& name);
+  void SetName(std::string_view name);
 
   /**
    * Gets the name of this Command.
@@ -67,7 +67,7 @@ class CommandBase : public Command,
    *
    * @param subsystem subsystem name
    */
-  void SetSubsystem(const wpi::Twine& subsystem);
+  void SetSubsystem(std::string_view subsystem);
 
   void InitSendable(frc::SendableBuilder& builder) override;
 

wpilibNewCommands/src/main/native/include/frc2/command/PrintCommand.h

@@ -4,7 +4,7 @@
 
 #pragma once
 
-#include <wpi/Twine.h>
+#include <string_view>
 
 #include "frc2/command/CommandHelper.h"
 #include "frc2/command/InstantCommand.h"
@@ -20,7 +20,7 @@ class PrintCommand : public CommandHelper<InstantCommand, PrintCommand> {
    *
    * @param message the message to print
    */
-  explicit PrintCommand(const wpi::Twine& message);
+  explicit PrintCommand(std::string_view message);
 
   PrintCommand(PrintCommand&& other) = default;
 

wpilibNewCommands/src/main/native/include/frc2/command/SubsystemBase.h

@@ -5,6 +5,7 @@
 #pragma once
 
 #include <string>
+#include <string_view>
 
 #include <frc/smartdashboard/Sendable.h>
 #include <frc/smartdashboard/SendableHelper.h>
@@ -34,7 +35,7 @@ class SubsystemBase : public Subsystem,
    *
    * @param name name
    */
-  void SetName(const wpi::Twine& name);
+  void SetName(std::string_view name);
 
   /**
    * Gets the subsystem name of this Subsystem.
@@ -48,7 +49,7 @@ class SubsystemBase : public Subsystem,
    *
    * @param subsystem subsystem name
    */
-  void SetSubsystem(const wpi::Twine& name);
+  void SetSubsystem(std::string_view name);
 
   /**
    * Associate a Sendable with this Subsystem.

wpilibNewCommands/src/main/native/include/frc2/command/button/NetworkButton.h

@@ -5,10 +5,10 @@
 #pragma once
 
 #include <memory>
+#include <string_view>
 
 #include <networktables/NetworkTable.h>
 #include <networktables/NetworkTableInstance.h>
-#include <wpi/Twine.h>
 
 #include "Button.h"
 
@@ -32,7 +32,7 @@ class NetworkButton : public Button {
    * @param field The field that is the value.
    */
   NetworkButton(std::shared_ptr<nt::NetworkTable> table,
-                const wpi::Twine& field);
+                std::string_view field);
 
   /**
    * Creates a NetworkButton that commands can be bound to.
@@ -40,6 +40,6 @@ class NetworkButton : public Button {
    * @param table The table where the networktable value is located.
    * @param field The field that is the value.
    */
-  NetworkButton(const wpi::Twine& table, const wpi::Twine& field);
+  NetworkButton(std::string_view table, std::string_view field);
 };
 }  // namespace frc2