Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-21 01:01:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

[wpilibc] Use std::string_view instead of Twine (#3380)

Browse Source 
Use fmtlib where needed for string formatting into std::string_view.
This commit is contained in:
Peter Johnson
2021-05-26 17:44:18 -07:00
committed by GitHub
parent 50915cb7ed
commit 4e2c3051be
76 changed files with 387 additions and 419 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
wpilibNewCommands/src/main/native/include/frc2/command/CommandBase.h
View File

@@ -6,12 +6,12 @@
#include <initializer_list>
#include <string>
#include <string_view>
#include <frc/smartdashboard/Sendable.h>
#include <frc/smartdashboard/SendableHelper.h>
#include <wpi/ArrayRef.h>
#include <wpi/SmallSet.h>
#include <wpi/Twine.h>
#include "frc2/command/Command.h"
@@ -46,7 +46,7 @@ class CommandBase : public Command,
*
* @param name name
*/
void SetName(const wpi::Twine& name);
void SetName(std::string_view name);
/**
* Gets the name of this Command.
@@ -67,7 +67,7 @@ class CommandBase : public Command,
*
* @param subsystem subsystem name
*/
void SetSubsystem(const wpi::Twine& subsystem);
void SetSubsystem(std::string_view subsystem);
void InitSendable(frc::SendableBuilder& builder) override;

4
wpilibNewCommands/src/main/native/include/frc2/command/PrintCommand.h
View File

@@ -4,7 +4,7 @@
#pragma once
#include <wpi/Twine.h>
#include <string_view>
#include "frc2/command/CommandHelper.h"
#include "frc2/command/InstantCommand.h"
@@ -20,7 +20,7 @@ class PrintCommand : public CommandHelper<InstantCommand, PrintCommand> {
*
* @param message the message to print
*/
explicit PrintCommand(const wpi::Twine& message);
explicit PrintCommand(std::string_view message);
PrintCommand(PrintCommand&& other) = default;

5
wpilibNewCommands/src/main/native/include/frc2/command/SubsystemBase.h
View File

@@ -5,6 +5,7 @@
#pragma once
#include <string>
#include <string_view>
#include <frc/smartdashboard/Sendable.h>
#include <frc/smartdashboard/SendableHelper.h>
@@ -34,7 +35,7 @@ class SubsystemBase : public Subsystem,
*
* @param name name
*/
void SetName(const wpi::Twine& name);
void SetName(std::string_view name);
/**
* Gets the subsystem name of this Subsystem.
@@ -48,7 +49,7 @@ class SubsystemBase : public Subsystem,
*
* @param subsystem subsystem name
*/
void SetSubsystem(const wpi::Twine& name);
void SetSubsystem(std::string_view name);
/**
* Associate a Sendable with this Subsystem.

6
wpilibNewCommands/src/main/native/include/frc2/command/button/NetworkButton.h
View File

@@ -5,10 +5,10 @@
#pragma once
#include <memory>
#include <string_view>
#include <networktables/NetworkTable.h>
#include <networktables/NetworkTableInstance.h>
#include <wpi/Twine.h>
#include "Button.h"
@@ -32,7 +32,7 @@ class NetworkButton : public Button {
* @param field The field that is the value.
*/
NetworkButton(std::shared_ptr<nt::NetworkTable> table,
const wpi::Twine& field);
std::string_view field);
/**
* Creates a NetworkButton that commands can be bound to.
@@ -40,6 +40,6 @@ class NetworkButton : public Button {
* @param table The table where the networktable value is located.
* @param field The field that is the value.
*/
NetworkButton(const wpi::Twine& table, const wpi::Twine& field);
NetworkButton(std::string_view table, std::string_view field);
};
} // namespace frc2