From 4f2114d6f54b96c7357d1f335742a837e8dfcaa5 Mon Sep 17 00:00:00 2001
From: Tyler Veness <calcmogul@gmail.com>
Date: Fri, 15 Sep 2023 10:37:52 -0700
Subject: [PATCH] Fix warnings from GCC 13 release build (#5637)

---
 ntcore/src/main/native/cpp/net/Message.h                 | 9 +++++++++
 .../native/include/networktables/NetworkTableValue.h     | 2 +-
 .../cpp/DigitalCommunicationTest.cpp                     | 2 +-
 .../I2CCommunication/cpp/I2CCommunicationTest.cpp        | 2 +-
 4 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/ntcore/src/main/native/cpp/net/Message.h b/ntcore/src/main/native/cpp/net/Message.h
index a95c5e8f6e..43f858a221 100644
--- a/ntcore/src/main/native/cpp/net/Message.h
+++ b/ntcore/src/main/native/cpp/net/Message.h
@@ -17,6 +17,11 @@
 
 namespace nt::net {
 
+#if __GNUC__ >= 13
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
+#endif
+
 struct PublishMsg {
   static constexpr std::string_view kMethodStr = "publish";
   NT_Publisher pubHandle{0};
@@ -57,6 +62,10 @@ struct ClientValueMsg {
   Value value;
 };
 
+#if __GNUC__ >= 13
+#pragma GCC diagnostic pop
+#endif
+
 struct ClientMessage {
   using Contents =
       std::variant<std::monostate, PublishMsg, UnpublishMsg, SetPropertiesMsg,
diff --git a/ntcore/src/main/native/include/networktables/NetworkTableValue.h b/ntcore/src/main/native/include/networktables/NetworkTableValue.h
index d637e486d1..eb05b04ec1 100644
--- a/ntcore/src/main/native/include/networktables/NetworkTableValue.h
+++ b/ntcore/src/main/native/include/networktables/NetworkTableValue.h
@@ -629,7 +629,7 @@ class Value final {
   friend bool operator==(const Value& lhs, const Value& rhs);
 
  private:
-  NT_Value m_val;
+  NT_Value m_val = {};
   std::shared_ptr<void> m_storage;
 };
 
diff --git a/wpilibcExamples/src/test/cpp/examples/DigitalCommunication/cpp/DigitalCommunicationTest.cpp b/wpilibcExamples/src/test/cpp/examples/DigitalCommunication/cpp/DigitalCommunicationTest.cpp
index 02bca00a40..8979894e85 100644
--- a/wpilibcExamples/src/test/cpp/examples/DigitalCommunication/cpp/DigitalCommunicationTest.cpp
+++ b/wpilibcExamples/src/test/cpp/examples/DigitalCommunication/cpp/DigitalCommunicationTest.cpp
@@ -54,7 +54,7 @@ TEST_P(AllianceTest, Alliance) {
 
   frc::sim::StepTiming(20_ms);
 
-  bool isRed;
+  bool isRed = false;
   switch (alliance) {
     case HAL_AllianceStationID_kBlue1:
     case HAL_AllianceStationID_kBlue2:
diff --git a/wpilibcExamples/src/test/cpp/examples/I2CCommunication/cpp/I2CCommunicationTest.cpp b/wpilibcExamples/src/test/cpp/examples/I2CCommunication/cpp/I2CCommunicationTest.cpp
index 44386be11d..3d84dbf65b 100644
--- a/wpilibcExamples/src/test/cpp/examples/I2CCommunication/cpp/I2CCommunicationTest.cpp
+++ b/wpilibcExamples/src/test/cpp/examples/I2CCommunication/cpp/I2CCommunicationTest.cpp
@@ -61,7 +61,7 @@ TEST_P(AllianceTest, Alliance) {
 
   frc::sim::StepTiming(20_ms);
 
-  char expected;
+  char expected = 'U';
   switch (alliance) {
     case HAL_AllianceStationID_kBlue1:
     case HAL_AllianceStationID_kBlue2: