Fix errors from new cpplint.py (#7105)

hal/src/main/native/athena/AddressableLED.cpp

@@ -5,6 +5,7 @@
 #include "hal/AddressableLED.h"
 
 #include <cstring>
+#include <memory>
 
 #include <fmt/format.h>
 

hal/src/main/native/athena/AnalogInternal.cpp

@@ -5,6 +5,7 @@
 #include "AnalogInternal.h"
 
 #include <atomic>
+#include <memory>
 
 #include <wpi/mutex.h>
 

hal/src/main/native/athena/AnalogTrigger.cpp

@@ -4,6 +4,8 @@
 
 #include "hal/AnalogTrigger.h"
 
+#include <memory>
+
 #include "AnalogInternal.h"
 #include "ConstantsInternal.h"
 #include "DutyCycleInternal.h"

hal/src/main/native/athena/CANAPI.cpp

@@ -5,6 +5,7 @@
 #include "hal/CANAPI.h"
 
 #include <ctime>
+#include <memory>
 
 #include <wpi/DenseMap.h>
 #include <wpi/mutex.h>

hal/src/main/native/athena/CTREPCM.cpp

@@ -4,6 +4,8 @@
 
 #include "hal/CTREPCM.h"
 
+#include <string>
+
 #include <fmt/format.h>
 
 #include "HALInitializer.h"

hal/src/main/native/athena/CTREPDP.cpp

@@ -4,6 +4,8 @@
 
 #include "CTREPDP.h"
 
+#include <string>
+
 #include <fmt/format.h>
 #include <wpi/mutex.h>
 

hal/src/main/native/athena/Counter.cpp

@@ -5,6 +5,7 @@
 #include "hal/Counter.h"
 
 #include <limits>
+#include <memory>
 
 #include <fmt/format.h>
 

hal/src/main/native/athena/DigitalInternal.cpp

@@ -6,6 +6,7 @@
 
 #include <atomic>
 #include <cmath>
+#include <memory>
 #include <thread>
 
 #include <FRC_NetworkCommunication/LoadOut.h>

hal/src/main/native/athena/Encoder.cpp

@@ -4,6 +4,8 @@
 
 #include "hal/Encoder.h"
 
+#include <memory>
+
 #include <fmt/format.h>
 
 #include "EncoderInternal.h"

hal/src/main/native/athena/FRCDriverStation.cpp

@@ -4,6 +4,7 @@
 
 #include <atomic>
 #include <chrono>
+#include <cstdio>
 #include <cstdlib>
 #include <cstring>
 #include <limits>

hal/src/main/native/athena/HAL.cpp

@@ -13,7 +13,9 @@
 #include <cstdio>
 #include <cstdlib>
 #include <fstream>
+#include <memory>
 #include <thread>
+#include <utility>
 
 #include <FRC_NetworkCommunication/FRCComm.h>
 #include <FRC_NetworkCommunication/LoadOut.h>

hal/src/main/native/athena/REVPDH.cpp

@@ -12,6 +12,7 @@
 #include <hal/handles/IndexedHandleResource.h>
 
 #include <cstring>
+#include <string>
 #include <thread>
 
 #include <fmt/format.h>

hal/src/main/native/athena/REVPH.cpp

@@ -4,6 +4,7 @@
 
 #include "hal/REVPH.h"
 
+#include <string>
 #include <thread>
 
 #include <fmt/format.h>

hal/src/main/native/athena/SPI.cpp

@@ -13,6 +13,7 @@
 #include <atomic>
 #include <cstdio>
 #include <cstring>
+#include <memory>
 
 #include <fmt/format.h>
 #include <wpi/mutex.h>

hal/src/main/native/athena/cpp/SerialHelper.cpp

@@ -7,7 +7,9 @@
 #include <algorithm>
 #include <cstdio>
 #include <cstring>
+#include <string>
 #include <string_view>
+#include <vector>
 
 #include <wpi/StringExtras.h>
 #include <wpi/fs.h>

hal/src/main/native/cpp/jni/CANJNI.cpp

@@ -176,7 +176,6 @@ Java_edu_wpi_first_hal_can_CANJNI_readCANStreamSession
       // OOM, just return
       elem = JLocal<jobject>{env, CreateCANStreamMessage(env)};
       if (elem) {
-        std::printf("Allocated and set object\n");
         env->SetObjectArrayElement(messages, i, elem);
       } else {
         return 0;

hal/src/main/native/cpp/jni/SimDeviceJNI.cpp

@@ -4,6 +4,9 @@
 
 #include <jni.h>
 
+#include <string>
+#include <vector>
+
 #include <wpi/jni_util.h>
 
 #include "HALUtil.h"

hal/src/main/native/cpp/jni/simulation/AddressableLEDDataJNI.cpp

@@ -4,6 +4,8 @@
 
 #include <jni.h>
 
+#include <memory>
+
 #include "CallbackStore.h"
 #include "ConstBufferCallbackStore.h"
 #include "edu_wpi_first_hal_simulation_AddressableLEDDataJNI.h"

hal/src/main/native/cpp/jni/simulation/BufferCallbackStore.cpp

@@ -7,14 +7,13 @@
 #include <jni.h>
 
 #include <cstdio>
+#include <memory>
 
 #include <wpi/jni_util.h>
 
 #include "SimulatorJNI.h"
 #include "hal/Types.h"
-#include "hal/Value.h"
 #include "hal/handles/UnlimitedHandleResource.h"
-#include "hal/simulation/NotifyListener.h"
 
 using namespace hal;
 using namespace hal::sim;

hal/src/main/native/cpp/jni/simulation/CallbackStore.cpp

@@ -7,6 +7,7 @@
 #include <jni.h>
 
 #include <cstdio>
+#include <memory>
 
 #include <wpi/jni_util.h>
 
@@ -14,7 +15,6 @@
 #include "hal/Types.h"
 #include "hal/Value.h"
 #include "hal/handles/UnlimitedHandleResource.h"
-#include "hal/simulation/NotifyListener.h"
 
 using namespace hal;
 using namespace hal::sim;

hal/src/main/native/cpp/jni/simulation/ConstBufferCallbackStore.cpp

@@ -7,14 +7,13 @@
 #include <jni.h>
 
 #include <cstdio>
+#include <memory>
 
 #include <wpi/jni_util.h>
 
 #include "SimulatorJNI.h"
 #include "hal/Types.h"
-#include "hal/Value.h"
 #include "hal/handles/UnlimitedHandleResource.h"
-#include "hal/simulation/NotifyListener.h"
 
 using namespace hal;
 using namespace hal::sim;

hal/src/main/native/cpp/jni/simulation/SimDeviceDataJNI.cpp

@@ -7,13 +7,15 @@
 #include <jni.h>
 
 #include <cstdio>
+#include <memory>
+#include <string>
 #include <utility>
+#include <vector>
 
 #include <wpi/jni_util.h>
 
 #include "SimulatorJNI.h"
 #include "edu_wpi_first_hal_simulation_SimDeviceDataJNI.h"
-#include "hal/SimDevice.h"
 #include "hal/handles/UnlimitedHandleResource.h"
 #include "hal/simulation/SimDeviceData.h"
 

hal/src/main/native/cpp/jni/simulation/SpiReadAutoReceiveBufferCallbackStore.cpp

@@ -7,14 +7,13 @@
 #include <jni.h>
 
 #include <cstdio>
+#include <memory>
 
 #include <wpi/jni_util.h>
 
 #include "SimulatorJNI.h"
 #include "hal/Types.h"
-#include "hal/Value.h"
 #include "hal/handles/UnlimitedHandleResource.h"
-#include "hal/simulation/NotifyListener.h"
 
 using namespace hal;
 using namespace hal::sim;

hal/src/main/native/sim/CANAPI.cpp

@@ -4,6 +4,8 @@
 
 #include "hal/CANAPI.h"
 
+#include <memory>
+
 #include <wpi/DenseMap.h>
 
 #include "CANAPIInternal.h"

hal/src/main/native/sim/CTREPCM.cpp

@@ -4,10 +4,11 @@
 
 #include "hal/CTREPCM.h"
 
+#include <string>
+
 #include "HALInitializer.h"
 #include "HALInternal.h"
 #include "PortsInternal.h"
-#include "hal/CANAPI.h"
 #include "hal/Errors.h"
 #include "hal/handles/IndexedHandleResource.h"
 #include "mockdata/CTREPCMDataInternal.h"

hal/src/main/native/sim/Encoder.cpp

@@ -4,6 +4,8 @@
 
 #include "hal/Encoder.h"
 
+#include <limits>
+
 #include "CounterInternal.h"
 #include "HALInitializer.h"
 #include "HALInternal.h"

hal/src/main/native/sim/Extensions.cpp

@@ -5,7 +5,9 @@
 #include "hal/Extensions.h"
 
 #include <cstdio>
+#include <string>
 #include <string_view>
+#include <utility>
 #include <vector>
 
 #include <wpi/SmallVector.h>

hal/src/main/native/sim/HAL.cpp

@@ -6,6 +6,7 @@
 
 #include <cstdio>
 #include <cstring>
+#include <utility>
 #include <vector>
 
 #include <wpi/mutex.h>
@@ -25,7 +26,6 @@ NtQueryTimerResolution(PULONG MinimumResolution, PULONG MaximumResolution,
 #include "ErrorsInternal.h"
 #include "HALInitializer.h"
 #include "MockHooksInternal.h"
-#include "hal/DriverStation.h"
 #include "hal/Errors.h"
 #include "hal/Extensions.h"
 #include "hal/handles/HandlesInternal.h"

hal/src/main/native/sim/Notifier.cpp

@@ -8,7 +8,9 @@
 #include <chrono>
 #include <cstdio>
 #include <cstring>
+#include <memory>
 #include <string>
+#include <utility>
 
 #include <wpi/SmallVector.h>
 #include <wpi/StringExtras.h>

hal/src/main/native/sim/REVPH.cpp

@@ -4,10 +4,11 @@
 
 #include "hal/REVPH.h"
 
+#include <string>
+
 #include "HALInitializer.h"
 #include "HALInternal.h"
 #include "PortsInternal.h"
-#include "hal/CANAPI.h"
 #include "hal/Errors.h"
 #include "hal/handles/IndexedHandleResource.h"
 #include "mockdata/REVPHDataInternal.h"

hal/src/main/native/sim/mockdata/DriverStationData.cpp

@@ -5,7 +5,6 @@
 #include <cstring>
 
 #include "DriverStationDataInternal.h"
-#include "hal/DriverStation.h"
 
 using namespace hal;
 

hal/src/main/native/sim/mockdata/EncoderData.cpp

@@ -2,6 +2,8 @@
 // Open Source Software; you can modify and/or share it under the terms of
 // the WPILib BSD license file in the root directory of this project.
 
+#include <limits>
+
 #include "../PortsInternal.h"
 #include "EncoderDataInternal.h"
 

hal/src/main/native/sim/mockdata/RoboRioData.cpp

@@ -2,7 +2,8 @@
 // Open Source Software; you can modify and/or share it under the terms of
 // the WPILib BSD license file in the root directory of this project.
 
-#include "../PortsInternal.h"
+#include <string>
+
 #include "RoboRioDataInternal.h"
 
 using namespace hal;

hal/src/main/native/sim/mockdata/SimDeviceData.cpp

@@ -5,6 +5,8 @@
 #include "hal/simulation/SimDeviceData.h"  // NOLINT(build/include_order)
 
 #include <algorithm>
+#include <memory>
+#include <utility>
 
 #include <wpi/StringExtras.h>