Fix errors from new cpplint.py (#7105)

wpilibc/src/main/native/cpp/ADIS16448_IMU.cpp

@@ -13,23 +13,21 @@
 
 #include "frc/ADIS16448_IMU.h"
 
-#include <frc/DigitalInput.h>
-#include <frc/DigitalOutput.h>
-#include <frc/DigitalSource.h>
-#include <frc/DriverStation.h>
-#include <frc/SPI.h>
-#include <frc/Timer.h>
-
 #include <algorithm>
 #include <cmath>
 #include <numbers>
+#include <utility>
 
 #include <hal/HAL.h>
 #include <wpi/sendable/SendableBuilder.h>
 #include <wpi/sendable/SendableRegistry.h>
 
+#include "frc/DigitalInput.h"
+#include "frc/DigitalOutput.h"
 #include "frc/Errors.h"
 #include "frc/MathUtil.h"
+#include "frc/SPI.h"
+#include "frc/Timer.h"
 
 /* Helpful conversion functions */
 static inline uint16_t BuffToUShort(const uint32_t* buf) {

wpilibc/src/main/native/cpp/ADIS16470_IMU.cpp

@@ -13,11 +13,6 @@
 
 #include "frc/ADIS16470_IMU.h"
 
-#include <frc/DigitalInput.h>
-#include <frc/DigitalSource.h>
-#include <frc/DriverStation.h>
-#include <frc/Timer.h>
-
 #include <cmath>
 #include <numbers>
 #include <utility>
@@ -26,8 +21,10 @@
 #include <wpi/sendable/SendableBuilder.h>
 #include <wpi/sendable/SendableRegistry.h>
 
+#include "frc/DigitalInput.h"
 #include "frc/Errors.h"
 #include "frc/MathUtil.h"
+#include "frc/Timer.h"
 
 /* Helpful conversion functions */
 static inline int32_t ToInt(const uint32_t* buf) {

wpilibc/src/main/native/cpp/Alert.cpp

@@ -4,11 +4,15 @@
 
 #include "frc/Alert.h"
 
-#include <frc/Timer.h>
-#include <frc/smartdashboard/SmartDashboard.h>
+#include <algorithm>
+#include <string>
+#include <vector>
 
 #include <networktables/NTSendableBuilder.h>
 
+#include "frc/Timer.h"
+#include "frc/smartdashboard/SmartDashboard.h"
+
 using namespace frc;
 
 Alert::Alert(std::string_view text, AlertType type)

wpilibc/src/main/native/cpp/AnalogEncoder.cpp

@@ -4,11 +4,12 @@
 
 #include "frc/AnalogEncoder.h"
 
+#include <utility>
+
 #include <wpi/NullDeleter.h>
 #include <wpi/sendable/SendableBuilder.h>
 
 #include "frc/AnalogInput.h"
-#include "frc/Errors.h"
 #include "frc/MathUtil.h"
 #include "frc/RobotController.h"
 

wpilibc/src/main/native/cpp/AnalogGyro.cpp

@@ -5,7 +5,8 @@
 #include "frc/AnalogGyro.h"
 
 #include <climits>
-#include <utility>
+#include <memory>
+#include <string>
 
 #include <hal/AnalogGyro.h>
 #include <hal/Errors.h>
@@ -17,7 +18,6 @@
 
 #include "frc/AnalogInput.h"
 #include "frc/Errors.h"
-#include "frc/Timer.h"
 
 using namespace frc;
 

wpilibc/src/main/native/cpp/AnalogInput.cpp

@@ -4,6 +4,8 @@
 
 #include "frc/AnalogInput.h"
 
+#include <string>
+
 #include <hal/AnalogAccumulator.h>
 #include <hal/AnalogInput.h>
 #include <hal/FRCUsageReporting.h>

wpilibc/src/main/native/cpp/AnalogOutput.cpp

@@ -4,8 +4,7 @@
 
 #include "frc/AnalogOutput.h"
 
-#include <limits>
-#include <utility>
+#include <string>
 
 #include <hal/AnalogOutput.h>
 #include <hal/FRCUsageReporting.h>

wpilibc/src/main/native/cpp/AnalogPotentiometer.cpp

@@ -4,6 +4,7 @@
 
 #include "frc/AnalogPotentiometer.h"
 
+#include <memory>
 #include <utility>
 
 #include <wpi/NullDeleter.h>

wpilibc/src/main/native/cpp/AnalogTrigger.cpp

@@ -4,6 +4,7 @@
 
 #include "frc/AnalogTrigger.h"
 
+#include <memory>
 #include <utility>
 
 #include <hal/AnalogTrigger.h>

wpilibc/src/main/native/cpp/AsynchronousInterrupt.cpp

@@ -6,6 +6,9 @@
 
 #include <frc/DigitalSource.h>
 
+#include <memory>
+#include <utility>
+
 using namespace frc;
 
 AsynchronousInterrupt::AsynchronousInterrupt(

wpilibc/src/main/native/cpp/Counter.cpp

@@ -4,7 +4,7 @@
 
 #include "frc/Counter.h"
 
-#include <utility>
+#include <memory>
 
 #include <hal/Counter.h>
 #include <hal/FRCUsageReporting.h>

wpilibc/src/main/native/cpp/DMA.cpp

@@ -15,11 +15,6 @@
 #include <hal/DMA.h>
 #include <hal/HALBase.h>
 
-#include "frc/AnalogInput.h"
-#include "frc/Counter.h"
-#include "frc/DigitalSource.h"
-#include "frc/DutyCycle.h"
-#include "frc/Encoder.h"
 #include "frc/Errors.h"
 
 using namespace frc;

wpilibc/src/main/native/cpp/DataLogManager.cpp

@@ -9,6 +9,8 @@
 #include <algorithm>
 #include <ctime>
 #include <random>
+#include <string>
+#include <vector>
 
 #include <fmt/chrono.h>
 #include <networktables/NetworkTableInstance.h>

wpilibc/src/main/native/cpp/DigitalInput.cpp

@@ -4,7 +4,7 @@
 
 #include "frc/DigitalInput.h"
 
-#include <limits>
+#include <string>
 
 #include <hal/DIO.h>
 #include <hal/FRCUsageReporting.h>

wpilibc/src/main/native/cpp/DigitalOutput.cpp

@@ -4,7 +4,7 @@
 
 #include "frc/DigitalOutput.h"
 
-#include <limits>
+#include <string>
 
 #include <hal/DIO.h>
 #include <hal/FRCUsageReporting.h>

wpilibc/src/main/native/cpp/DriverStation.cpp

@@ -8,12 +8,10 @@
 
 #include <array>
 #include <atomic>
-#include <chrono>
+#include <memory>
 #include <span>
 #include <string>
 #include <string_view>
-#include <thread>
-#include <type_traits>
 
 #include <fmt/format.h>
 #include <hal/DriverStation.h>
@@ -33,7 +31,6 @@
 #include <wpi/timestamp.h>
 
 #include "frc/Errors.h"
-#include "frc/MotorSafety.h"
 #include "frc/Timer.h"
 
 using namespace frc;

wpilibc/src/main/native/cpp/DutyCycle.cpp

@@ -4,6 +4,8 @@
 
 #include "frc/DutyCycle.h"
 
+#include <utility>
+
 #include <hal/DutyCycle.h>
 #include <hal/FRCUsageReporting.h>
 #include <wpi/NullDeleter.h>

wpilibc/src/main/native/cpp/DutyCycleEncoder.cpp

@@ -4,13 +4,15 @@
 
 #include "frc/DutyCycleEncoder.h"
 
+#include <memory>
+#include <utility>
+
 #include <wpi/NullDeleter.h>
 #include <wpi/sendable/SendableBuilder.h>
 
 #include "frc/DigitalInput.h"
 #include "frc/DigitalSource.h"
 #include "frc/DutyCycle.h"
-#include "frc/Errors.h"
 #include "frc/MathUtil.h"
 
 using namespace frc;

wpilibc/src/main/native/cpp/Encoder.cpp

@@ -4,6 +4,7 @@
 
 #include "frc/Encoder.h"
 
+#include <memory>
 #include <utility>
 
 #include <hal/Encoder.h>

wpilibc/src/main/native/cpp/Errors.cpp

@@ -4,7 +4,8 @@
 
 #include "frc/Errors.h"
 
-#include <exception>
+#include <string>
+#include <utility>
 
 #include <hal/DriverStation.h>
 #include <hal/HALBase.h>

wpilibc/src/main/native/cpp/Filesystem.cpp

@@ -4,6 +4,8 @@
 
 #include "frc/Filesystem.h"
 
+#include <string>
+
 #include <wpi/fs.h>
 
 #include "frc/RobotBase.h"

wpilibc/src/main/native/cpp/GenericHID.cpp

@@ -4,6 +4,8 @@
 
 #include "frc/GenericHID.h"
 
+#include <string>
+
 #include <hal/DriverStation.h>
 
 #include "frc/DriverStation.h"

wpilibc/src/main/native/cpp/LEDPattern.cpp

@@ -8,6 +8,7 @@
 #include <cmath>
 #include <numbers>
 #include <unordered_map>
+#include <utility>
 #include <vector>
 
 #include <wpi/MathExtras.h>

wpilibc/src/main/native/cpp/PneumaticHub.cpp

@@ -5,6 +5,9 @@
 #include "frc/PneumaticHub.h"
 
 #include <array>
+#include <cstdio>
+#include <memory>
+#include <string>
 
 #include <fmt/format.h>
 #include <hal/REVPH.h>

wpilibc/src/main/native/cpp/PneumaticsBase.cpp

@@ -4,6 +4,8 @@
 
 #include "frc/PneumaticsBase.h"
 
+#include <memory>
+
 #include <hal/REVPH.h>
 
 #include "frc/Errors.h"

wpilibc/src/main/native/cpp/PneumaticsControlModule.cpp

@@ -4,6 +4,9 @@
 
 #include "frc/PneumaticsControlModule.h"
 
+#include <memory>
+#include <string>
+
 #include <hal/CTREPCM.h>
 #include <wpi/NullDeleter.h>
 #include <wpi/StackTrace.h>

wpilibc/src/main/native/cpp/PowerDistribution.cpp

@@ -4,6 +4,8 @@
 
 #include "frc/PowerDistribution.h"
 
+#include <vector>
+
 #include <fmt/format.h>
 #include <hal/FRCUsageReporting.h>
 #include <hal/Ports.h>
@@ -13,7 +15,6 @@
 #include <wpi/sendable/SendableRegistry.h>
 
 #include "frc/Errors.h"
-#include "frc/SensorUtil.h"
 
 static_assert(static_cast<HAL_PowerDistributionType>(
                   frc::PowerDistribution::ModuleType::kCTRE) ==

wpilibc/src/main/native/cpp/Preferences.cpp

@@ -4,7 +4,9 @@
 
 #include "frc/Preferences.h"
 
-#include <algorithm>
+#include <memory>
+#include <string>
+#include <vector>
 
 #include <fmt/format.h>
 #include <hal/FRCUsageReporting.h>

wpilibc/src/main/native/cpp/Relay.cpp

@@ -4,7 +4,7 @@
 
 #include "frc/Relay.h"
 
-#include <utility>
+#include <string>
 
 #include <fmt/format.h>
 #include <hal/FRCUsageReporting.h>

wpilibc/src/main/native/cpp/Resource.cpp

@@ -4,6 +4,11 @@
 
 #include "frc/Resource.h"
 
+#include <limits>
+#include <memory>
+#include <string>
+#include <vector>
+
 #include <wpi/deprecated.h>
 
 #include "frc/Errors.h"

wpilibc/src/main/native/cpp/RobotController.cpp

@@ -4,7 +4,7 @@
 
 #include "frc/RobotController.h"
 
-#include <cstddef>
+#include <string>
 
 #include <hal/CAN.h>
 #include <hal/HALBase.h>

wpilibc/src/main/native/cpp/SerialPort.cpp

@@ -4,7 +4,7 @@
 
 #include "frc/SerialPort.h"
 
-#include <utility>
+#include <string>
 
 #include <hal/FRCUsageReporting.h>
 #include <hal/SerialPort.h>

wpilibc/src/main/native/cpp/SharpIR.cpp

@@ -4,6 +4,8 @@
 
 #include "frc/SharpIR.h"
 
+#include <algorithm>
+
 #include <wpi/sendable/SendableBuilder.h>
 #include <wpi/sendable/SendableRegistry.h>
 

wpilibc/src/main/native/cpp/SynchronousInterrupt.cpp

@@ -4,7 +4,9 @@
 
 #include "frc/SynchronousInterrupt.h"
 
+#include <memory>
 #include <type_traits>
+#include <utility>
 
 #include <hal/Interrupts.h>
 #include <wpi/NullDeleter.h>

wpilibc/src/main/native/cpp/Ultrasonic.cpp

@@ -4,7 +4,9 @@
 
 #include "frc/Ultrasonic.h"
 
+#include <memory>
 #include <utility>
+#include <vector>
 
 #include <hal/FRCUsageReporting.h>
 #include <wpi/NullDeleter.h>

wpilibc/src/main/native/cpp/Watchdog.cpp

@@ -7,6 +7,7 @@
 #include <atomic>
 #include <thread>
 #include <utility>
+#include <vector>
 
 #include <fmt/format.h>
 #include <hal/Notifier.h>

wpilibc/src/main/native/cpp/counter/ExternalDirectionCounter.cpp

@@ -4,6 +4,8 @@
 
 #include "frc/counter/ExternalDirectionCounter.h"
 
+#include <memory>
+
 #include <hal/Counter.h>
 #include <hal/FRCUsageReporting.h>
 #include <wpi/NullDeleter.h>

wpilibc/src/main/native/cpp/counter/UpDownCounter.cpp

@@ -4,6 +4,8 @@
 
 #include "frc/counter/UpDownCounter.h"
 
+#include <memory>
+
 #include <hal/Counter.h>
 #include <hal/FRCUsageReporting.h>
 #include <wpi/NullDeleter.h>

wpilibc/src/main/native/cpp/drive/DifferentialDrive.cpp

@@ -6,6 +6,8 @@
 
 #include <algorithm>
 #include <cmath>
+#include <string>
+#include <utility>
 
 #include <hal/FRCUsageReporting.h>
 #include <wpi/sendable/SendableBuilder.h>

wpilibc/src/main/native/cpp/drive/MecanumDrive.cpp

@@ -5,6 +5,8 @@
 #include "frc/drive/MecanumDrive.h"
 
 #include <algorithm>
+#include <string>
+#include <utility>
 
 #include <hal/FRCUsageReporting.h>
 #include <wpi/sendable/SendableBuilder.h>

wpilibc/src/main/native/cpp/event/BooleanEvent.cpp

@@ -4,6 +4,9 @@
 
 #include "frc/event/BooleanEvent.h"
 
+#include <memory>
+#include <utility>
+
 using namespace frc;
 
 BooleanEvent::BooleanEvent(EventLoop* loop, std::function<bool()> condition)

wpilibc/src/main/native/cpp/event/EventLoop.cpp

@@ -4,6 +4,8 @@
 
 #include "frc/event/EventLoop.h"
 
+#include <utility>
+
 #include "frc/Errors.h"
 
 using namespace frc;

wpilibc/src/main/native/cpp/event/NetworkBooleanEvent.cpp

@@ -4,6 +4,9 @@
 
 #include "frc/event/NetworkBooleanEvent.h"
 
+#include <memory>
+#include <utility>
+
 #include <networktables/BooleanTopic.h>
 #include <networktables/NetworkTable.h>
 #include <networktables/NetworkTableInstance.h>

wpilibc/src/main/native/cpp/livewindow/LiveWindow.cpp

@@ -4,6 +4,8 @@
 
 #include "frc/livewindow/LiveWindow.h"
 
+#include <memory>
+
 #include <networktables/BooleanTopic.h>
 #include <networktables/NetworkTable.h>
 #include <networktables/NetworkTableInstance.h>

wpilibc/src/main/native/cpp/motorcontrol/MotorControllerGroup.cpp

@@ -4,6 +4,9 @@
 
 #include "frc/motorcontrol/MotorControllerGroup.h"
 
+#include <utility>
+#include <vector>
+
 #include <wpi/sendable/SendableBuilder.h>
 #include <wpi/sendable/SendableRegistry.h>
 

wpilibc/src/main/native/cpp/motorcontrol/NidecBrushless.cpp

@@ -4,6 +4,8 @@
 
 #include "frc/motorcontrol/NidecBrushless.h"
 
+#include <string>
+
 #include <fmt/format.h>
 #include <hal/FRCUsageReporting.h>
 #include <wpi/sendable/SendableBuilder.h>

wpilibc/src/main/native/cpp/motorcontrol/PWMMotorController.cpp

@@ -4,6 +4,8 @@
 
 #include "frc/motorcontrol/PWMMotorController.h"
 
+#include <string>
+
 #include <fmt/format.h>
 #include <wpi/sendable/SendableBuilder.h>
 #include <wpi/sendable/SendableRegistry.h>

wpilibc/src/main/native/cpp/shuffleboard/ComplexWidget.cpp

@@ -4,6 +4,8 @@
 
 #include "frc/shuffleboard/ComplexWidget.h"
 
+#include <memory>
+
 #include <wpi/sendable/Sendable.h>
 
 #include "frc/smartdashboard/SendableBuilderImpl.h"

wpilibc/src/main/native/cpp/shuffleboard/RecordingController.cpp

@@ -4,6 +4,8 @@
 
 #include "frc/shuffleboard/RecordingController.h"
 
+#include <string>
+
 #include "frc/Errors.h"
 
 using namespace frc;

wpilibc/src/main/native/cpp/shuffleboard/Shuffleboard.cpp

@@ -4,6 +4,8 @@
 
 #include "frc/shuffleboard/Shuffleboard.h"
 
+#include <memory>
+
 #include <networktables/NetworkTableInstance.h>
 
 #include "frc/shuffleboard/ShuffleboardTab.h"

wpilibc/src/main/native/cpp/shuffleboard/ShuffleboardComponentBase.cpp

@@ -4,6 +4,9 @@
 
 #include "frc/shuffleboard/ShuffleboardComponentBase.h"
 
+#include <memory>
+#include <string>
+
 using namespace frc;
 
 ShuffleboardComponentBase::ShuffleboardComponentBase(

wpilibc/src/main/native/cpp/shuffleboard/ShuffleboardContainer.cpp

@@ -4,6 +4,11 @@
 
 #include "frc/shuffleboard/ShuffleboardContainer.h"
 
+#include <memory>
+#include <string>
+#include <utility>
+#include <vector>
+
 #include <ntcore_cpp.h>
 #include <wpi/sendable/SendableRegistry.h>
 

wpilibc/src/main/native/cpp/shuffleboard/ShuffleboardInstance.cpp

@@ -4,6 +4,9 @@
 
 #include "frc/shuffleboard/ShuffleboardInstance.h"
 
+#include <memory>
+#include <string>
+
 #include <hal/FRCUsageReporting.h>
 #include <networktables/NetworkTable.h>
 #include <networktables/NetworkTableInstance.h>

wpilibc/src/main/native/cpp/shuffleboard/ShuffleboardLayout.cpp

@@ -4,6 +4,8 @@
 
 #include "frc/shuffleboard/ShuffleboardLayout.h"
 
+#include <memory>
+
 #include <wpi/json.h>
 
 using namespace frc;

wpilibc/src/main/native/cpp/shuffleboard/ShuffleboardTab.cpp

@@ -4,6 +4,8 @@
 
 #include "frc/shuffleboard/ShuffleboardTab.h"
 
+#include <memory>
+
 #include <wpi/json.h>
 
 using namespace frc;

wpilibc/src/main/native/cpp/shuffleboard/SimpleWidget.cpp

@@ -4,6 +4,8 @@
 
 #include "frc/shuffleboard/SimpleWidget.h"
 
+#include <memory>
+
 #include "frc/shuffleboard/Shuffleboard.h"
 #include "frc/shuffleboard/ShuffleboardLayout.h"
 #include "frc/shuffleboard/ShuffleboardTab.h"

wpilibc/src/main/native/cpp/simulation/DoubleSolenoidSim.cpp

@@ -4,6 +4,9 @@
 
 #include "frc/simulation/DoubleSolenoidSim.h"
 
+#include <memory>
+#include <utility>
+
 #include "frc/PneumaticsBase.h"
 
 using namespace frc;

wpilibc/src/main/native/cpp/simulation/PneumaticsBaseSim.cpp

@@ -4,6 +4,8 @@
 
 #include "frc/simulation/PneumaticsBaseSim.h"
 
+#include <memory>
+
 #include "frc/Errors.h"
 #include "frc/PneumaticsModuleType.h"
 #include "frc/simulation/CTREPCMSim.h"

wpilibc/src/main/native/cpp/simulation/RoboRioSim.cpp

@@ -5,7 +5,7 @@
 #include "frc/simulation/RoboRioSim.h"
 
 #include <memory>
-#include <utility>
+#include <string>
 
 #include <hal/simulation/RoboRioData.h>
 

wpilibc/src/main/native/cpp/simulation/SolenoidSim.cpp

@@ -4,6 +4,9 @@
 
 #include "frc/simulation/SolenoidSim.h"
 
+#include <memory>
+#include <utility>
+
 #include "frc/PneumaticsBase.h"
 
 using namespace frc;

wpilibc/src/main/native/cpp/smartdashboard/Field2d.cpp

@@ -4,6 +4,9 @@
 
 #include "frc/smartdashboard/Field2d.h"
 
+#include <memory>
+#include <utility>
+
 #include <networktables/DoubleArrayTopic.h>
 #include <networktables/NTSendableBuilder.h>
 #include <wpi/sendable/SendableRegistry.h>

wpilibc/src/main/native/cpp/smartdashboard/FieldObject2d.cpp

@@ -4,6 +4,7 @@
 
 #include "frc/smartdashboard/FieldObject2d.h"
 
+#include <utility>
 #include <vector>
 
 #include "frc/trajectory/Trajectory.h"

wpilibc/src/main/native/cpp/smartdashboard/ListenerExecutor.cpp

@@ -4,6 +4,8 @@
 
 #include "frc/smartdashboard/ListenerExecutor.h"
 
+#include <utility>
+
 using namespace frc::detail;
 
 void ListenerExecutor::Execute(std::function<void()> task) {

wpilibc/src/main/native/cpp/smartdashboard/Mechanism2d.cpp

@@ -4,6 +4,7 @@
 
 #include "frc/smartdashboard/Mechanism2d.h"
 
+#include <memory>
 #include <string_view>
 
 #include <networktables/NTSendableBuilder.h>

wpilibc/src/main/native/cpp/smartdashboard/MechanismLigament2d.cpp

@@ -4,6 +4,9 @@
 
 #include "frc/smartdashboard/MechanismLigament2d.h"
 
+#include <cstdio>
+#include <memory>
+
 #include <wpi/StringExtras.h>
 #include <wpi/json.h>
 

wpilibc/src/main/native/cpp/smartdashboard/MechanismObject2d.cpp

@@ -4,6 +4,8 @@
 
 #include "frc/smartdashboard/MechanismObject2d.h"
 
+#include <string>
+
 using namespace frc;
 
 MechanismObject2d::MechanismObject2d(std::string_view name) : m_name{name} {}

wpilibc/src/main/native/cpp/smartdashboard/SendableBuilderImpl.cpp

@@ -4,6 +4,10 @@
 
 #include "frc/smartdashboard/SendableBuilderImpl.h"
 
+#include <memory>
+#include <string>
+#include <utility>
+
 #include <networktables/BooleanArrayTopic.h>
 #include <networktables/BooleanTopic.h>
 #include <networktables/DoubleArrayTopic.h>
@@ -18,8 +22,6 @@
 #include <wpi/SmallVector.h>
 #include <wpi/json.h>
 
-#include "frc/smartdashboard/SmartDashboard.h"
-
 using namespace frc;
 
 template <typename Topic>

wpilibc/src/main/native/cpp/smartdashboard/SendableChooserBase.cpp

@@ -4,6 +4,8 @@
 
 #include "frc/smartdashboard/SendableChooserBase.h"
 
+#include <utility>
+
 #include <wpi/sendable/SendableRegistry.h>
 
 using namespace frc;

wpilibc/src/main/native/cpp/smartdashboard/SmartDashboard.cpp

@@ -4,6 +4,11 @@
 
 #include "frc/smartdashboard/SmartDashboard.h"
 
+#include <memory>
+#include <string>
+#include <utility>
+#include <vector>
+
 #include <hal/FRCUsageReporting.h>
 #include <networktables/NetworkTable.h>
 #include <networktables/NetworkTableInstance.h>

wpilibc/src/main/native/cpp/sysid/SysIdRoutineLog.cpp

@@ -4,6 +4,8 @@
 
 #include "frc/sysid/SysIdRoutineLog.h"
 
+#include <string>
+
 #include <fmt/format.h>
 
 #include "frc/DataLogManager.h"