[wpilib] Deprecate Timer::HasPeriodPassed() (#3598)

AdvanceIfElapsed() is safer to use, as it has less surprising side effects.

wpilibc/src/main/native/include/frc/Timer.h

@@ -5,6 +5,7 @@
 #pragma once
 
 #include <units/time.h>
+#include <wpi/deprecated.h>
 
 namespace frc {
 
@@ -97,7 +98,9 @@ class Timer {
    *
    * @param period The period to check for.
    * @return       True if the period has passed.
+   * @deprecated Use AdvanceIfElapsed() instead.
    */
+  WPI_DEPRECATED("Use AdvanceIfElapsed() instead.")
   bool HasPeriodPassed(units::second_t period);
 
   /**