diff --git a/hal/include/HAL/HAL.h b/hal/include/HAL/HAL.h index a9a34fe83b..6df4d5b970 100644 --- a/hal/include/HAL/HAL.h +++ b/hal/include/HAL/HAL.h @@ -7,7 +7,6 @@ #pragma once -#include #include #include "Accelerometer.h" @@ -206,10 +205,6 @@ struct HALJoystickDescriptor { uint8_t povCount; }; -inline float intToFloat(int value) { return (float)value; } - -inline int floatToInt(float value) { return round(value); } - extern "C" { extern const uint32_t dio_kNumSystems; extern const uint32_t solenoid_kNumDO7_0Elements; diff --git a/hal/include/HAL/Interrupts.h b/hal/include/HAL/Interrupts.h index 4271e8d5c6..52cf652498 100644 --- a/hal/include/HAL/Interrupts.h +++ b/hal/include/HAL/Interrupts.h @@ -7,11 +7,8 @@ #pragma once -#include #include -#include - extern "C" { typedef void (*InterruptHandlerFunction)(uint32_t interruptAssertedMask, void* param); diff --git a/hal/lib/athena/Accelerometer.cpp b/hal/lib/athena/Accelerometer.cpp index f4cca4bd5e..274cfe29fb 100644 --- a/hal/lib/athena/Accelerometer.cpp +++ b/hal/lib/athena/Accelerometer.cpp @@ -7,9 +7,10 @@ #include "HAL/Accelerometer.h" -#include +#include +#include + #include -#include #include "ChipObject.h" @@ -125,7 +126,7 @@ static void writeRegister(Register reg, uint8_t data) { if (getFPGATime(&status) > initialTime + 1000) break; } - fflush(stdout); + std::fflush(stdout); } static uint8_t readRegister(Register reg) { @@ -155,7 +156,7 @@ static uint8_t readRegister(Register reg) { if (getFPGATime(&status) > initialTime + 1000) break; } - fflush(stdout); + std::fflush(stdout); return accel->readDATI(&status); } diff --git a/hal/lib/athena/Compressor.cpp b/hal/lib/athena/Compressor.cpp index fdcb650bdf..e4c1b1ef66 100644 --- a/hal/lib/athena/Compressor.cpp +++ b/hal/lib/athena/Compressor.cpp @@ -7,8 +7,6 @@ #include "HAL/Compressor.h" -#include - #include "ctre/PCM.h" static const int NUM_MODULE_NUMBERS = 63; diff --git a/hal/lib/athena/DIO.cpp b/hal/lib/athena/DIO.cpp index 3c8788a177..65465a104f 100644 --- a/hal/lib/athena/DIO.cpp +++ b/hal/lib/athena/DIO.cpp @@ -7,7 +7,7 @@ #include "HAL/DIO.h" -#include +#include #include "DigitalInternal.h" @@ -100,7 +100,7 @@ void setPWMDutyCycle(void* pwmGenerator, double dutyCycle, int32_t* status) { if (pwmPeriodPower < 4) { // The resolution of the duty cycle drops close to the highest // frequencies. - rawDutyCycle = rawDutyCycle / pow(2.0, 4 - pwmPeriodPower); + rawDutyCycle = rawDutyCycle / std::pow(2.0, 4 - pwmPeriodPower); } if (id < 4) digitalSystem->writePWMDutyCycleA(id, (uint8_t)rawDutyCycle, status); diff --git a/hal/lib/athena/DigitalInternal.cpp b/hal/lib/athena/DigitalInternal.cpp index 96d29c333e..97124b1fc3 100644 --- a/hal/lib/athena/DigitalInternal.cpp +++ b/hal/lib/athena/DigitalInternal.cpp @@ -7,9 +7,6 @@ #include "DigitalInternal.h" -#include -#include - #include #include @@ -65,10 +62,6 @@ void initializeDigital(int32_t* status) { while (pwmSystem->readLoopTiming(status) == 0) std::this_thread::yield(); if (pwmSystem->readLoopTiming(status) != kExpectedLoopTiming) { - // TODO: char err[128]; - // TODO: sprintf(err, "DIO LoopTiming: %d, expecting: %lu\n", - // digitalModules[port->module-1]->readLoopTiming(status), - // kExpectedLoopTiming); *status = LOOP_TIMING_ERROR; // NOTE: Doesn't display the error } @@ -81,7 +74,6 @@ void initializeDigital(int32_t* status) { uint16_t minHigh = (uint16_t)( (kDefaultPwmCenter - kDefaultPwmStepsDown * loopTime) / loopTime + .5); pwmSystem->writeConfig_MinHigh(minHigh, status); - // printf("MinHigh: %d\n", minHigh); // Ensure that PWM output values are set to OFF for (uint32_t pwm_index = 0; pwm_index < kPwmPins; pwm_index++) { // Initialize port structure diff --git a/hal/lib/athena/Notifier.cpp b/hal/lib/athena/Notifier.cpp index 7863c5c077..6d3da8f2af 100644 --- a/hal/lib/athena/Notifier.cpp +++ b/hal/lib/athena/Notifier.cpp @@ -7,7 +7,8 @@ #include "HAL/Notifier.h" -#include +// For std::atexit() +#include #include #include diff --git a/wpilibc/athena/include/RobotDrive.h b/wpilibc/athena/include/RobotDrive.h index b63238bdf4..1780f3656e 100644 --- a/wpilibc/athena/include/RobotDrive.h +++ b/wpilibc/athena/include/RobotDrive.h @@ -7,8 +7,6 @@ #pragma once -#include - #include #include diff --git a/wpilibc/athena/include/Vision/ImageBase.h b/wpilibc/athena/include/Vision/ImageBase.h index d7797052f6..d128632079 100644 --- a/wpilibc/athena/include/Vision/ImageBase.h +++ b/wpilibc/athena/include/Vision/ImageBase.h @@ -7,8 +7,6 @@ #pragma once -#include - #include "ErrorBase.h" #include "nivision.h" diff --git a/wpilibc/athena/src/CANJaguar.cpp b/wpilibc/athena/src/CANJaguar.cpp index 5aa961245f..1ffc393676 100644 --- a/wpilibc/athena/src/CANJaguar.cpp +++ b/wpilibc/athena/src/CANJaguar.cpp @@ -7,8 +7,7 @@ #include "CANJaguar.h" -#include -#include +#include #include "FRC_NetworkCommunication/CANSessionMux.h" #include "HAL/HAL.h" diff --git a/wpilibc/athena/src/CameraServer.cpp b/wpilibc/athena/src/CameraServer.cpp index d2642a1063..dfb8e950e9 100644 --- a/wpilibc/athena/src/CameraServer.cpp +++ b/wpilibc/athena/src/CameraServer.cpp @@ -8,11 +8,11 @@ #include "CameraServer.h" #include -#include #include #include #include +#include #include #include "Utility.h" @@ -170,7 +170,7 @@ void CameraServer::Serve() { sockaddr_in address, clientAddress; - memset(&address, 0, sizeof(address)); + std::memset(&address, 0, sizeof(address)); address.sin_family = AF_INET; address.sin_addr.s_addr = htonl(INADDR_ANY); address.sin_port = htons(kPort); diff --git a/wpilibc/athena/src/DriverStation.cpp b/wpilibc/athena/src/DriverStation.cpp index 290be1a641..c80ddd5747 100644 --- a/wpilibc/athena/src/DriverStation.cpp +++ b/wpilibc/athena/src/DriverStation.cpp @@ -383,7 +383,7 @@ bool DriverStation::GetStickButton(uint32_t stick, uint8_t button) { */ bool DriverStation::IsEnabled() const { HALControlWord controlWord; - memset(&controlWord, 0, sizeof(controlWord)); + std::memset(&controlWord, 0, sizeof(controlWord)); HALGetControlWord(&controlWord); return controlWord.enabled && controlWord.dsAttached; } @@ -395,7 +395,7 @@ bool DriverStation::IsEnabled() const { */ bool DriverStation::IsDisabled() const { HALControlWord controlWord; - memset(&controlWord, 0, sizeof(controlWord)); + std::memset(&controlWord, 0, sizeof(controlWord)); HALGetControlWord(&controlWord); return !(controlWord.enabled && controlWord.dsAttached); } @@ -407,7 +407,7 @@ bool DriverStation::IsDisabled() const { */ bool DriverStation::IsAutonomous() const { HALControlWord controlWord; - memset(&controlWord, 0, sizeof(controlWord)); + std::memset(&controlWord, 0, sizeof(controlWord)); HALGetControlWord(&controlWord); return controlWord.autonomous; } @@ -419,7 +419,7 @@ bool DriverStation::IsAutonomous() const { */ bool DriverStation::IsOperatorControl() const { HALControlWord controlWord; - memset(&controlWord, 0, sizeof(controlWord)); + std::memset(&controlWord, 0, sizeof(controlWord)); HALGetControlWord(&controlWord); return !(controlWord.autonomous || controlWord.test); } @@ -442,7 +442,7 @@ bool DriverStation::IsTest() const { */ bool DriverStation::IsDSAttached() const { HALControlWord controlWord; - memset(&controlWord, 0, sizeof(controlWord)); + std::memset(&controlWord, 0, sizeof(controlWord)); HALGetControlWord(&controlWord); return controlWord.dsAttached; } diff --git a/wpilibc/athena/src/MotorSafetyHelper.cpp b/wpilibc/athena/src/MotorSafetyHelper.cpp index 24908c3500..c958ece8dd 100644 --- a/wpilibc/athena/src/MotorSafetyHelper.cpp +++ b/wpilibc/athena/src/MotorSafetyHelper.cpp @@ -7,14 +7,13 @@ #include "MotorSafetyHelper.h" +#include + #include "DriverStation.h" #include "MotorSafety.h" #include "Timer.h" #include "WPIErrors.h" -#include -#include - std::set MotorSafetyHelper::m_helperList; priority_recursive_mutex MotorSafetyHelper::m_listMutex; diff --git a/wpilibc/athena/src/PWM.cpp b/wpilibc/athena/src/PWM.cpp index 5468821faa..c0d607c651 100644 --- a/wpilibc/athena/src/PWM.cpp +++ b/wpilibc/athena/src/PWM.cpp @@ -162,12 +162,7 @@ void PWM::SetPosition(float pos) { // converting to int unsigned short rawValue = (int32_t)((pos * (float)GetFullRangeScaleFactor()) + GetMinNegativePwm()); - // printf("MinNegPWM: %d FullRangeScaleFactor: %d Raw value: %5d Input " - // "value: %4.4f\n", GetMinNegativePwm(), GetFullRangeScaleFactor(), rawValue, - // pos); - // wpi_assert((rawValue >= GetMinNegativePwm()) && (rawValue <= - // GetMaxPositivePwm())); wpi_assert(rawValue != kPwmDisabled); // send the computed pwm value to the FPGA diff --git a/wpilibc/athena/src/Preferences.cpp b/wpilibc/athena/src/Preferences.cpp index 5cd47e04ec..6bf7c6480d 100644 --- a/wpilibc/athena/src/Preferences.cpp +++ b/wpilibc/athena/src/Preferences.cpp @@ -7,12 +7,11 @@ #include "Preferences.h" +#include + #include "HAL/HAL.h" #include "WPIErrors.h" -#include -#include - /** The Preferences table name */ static const char* kTableName = "Preferences"; @@ -61,8 +60,8 @@ std::string Preferences::GetString(llvm::StringRef key, } /** - * Returns the int at the given key. If this table does not have a value - * for that position, then the given defaultValue value will be returned. + * Returns the int at the given key. If this table does not have a value for + * that position, then the given defaultValue value will be returned. * * @param key the key * @param defaultValue the value to return if none exists in the table diff --git a/wpilibc/athena/src/RobotBase.cpp b/wpilibc/athena/src/RobotBase.cpp index d59c2fce95..fc74151627 100644 --- a/wpilibc/athena/src/RobotBase.cpp +++ b/wpilibc/athena/src/RobotBase.cpp @@ -7,8 +7,7 @@ #include "RobotBase.h" -#include -#include +#include #include "DriverStation.h" #include "HAL/HAL.h" @@ -28,7 +27,7 @@ void RobotBase::setInstance(RobotBase* robot) { RobotBase& RobotBase::getInstance() { return *m_instance; } void RobotBase::robotSetup(RobotBase* robot) { - printf("\n********** Robot program starting **********\n"); + std::printf("\n********** Robot program starting **********\n"); robot->StartCompetition(); } diff --git a/wpilibc/athena/src/SPI.cpp b/wpilibc/athena/src/SPI.cpp index 47e12d846c..6492111672 100644 --- a/wpilibc/athena/src/SPI.cpp +++ b/wpilibc/athena/src/SPI.cpp @@ -7,7 +7,7 @@ #include "SPI.h" -#include +#include #include "HAL/HAL.h" #include "WPIErrors.h" @@ -151,7 +151,7 @@ int32_t SPI::Read(bool initiate, uint8_t* dataReceived, uint8_t size) { int32_t retVal = 0; if (initiate) { auto dataToSend = new uint8_t[size]; - memset(dataToSend, 0, size); + std::memset(dataToSend, 0, size); retVal = spiTransaction(m_port, dataToSend, dataReceived, size); } else retVal = spiRead(m_port, dataReceived, size); diff --git a/wpilibc/athena/src/SerialPort.cpp b/wpilibc/athena/src/SerialPort.cpp index 8dddb6a5a2..cd7fdf4aa8 100644 --- a/wpilibc/athena/src/SerialPort.cpp +++ b/wpilibc/athena/src/SerialPort.cpp @@ -7,7 +7,6 @@ #include "SerialPort.h" -#include #include "HAL/HAL.h" // static ViStatus _VI_FUNCH ioCompleteHandler (ViSession vi, ViEventType diff --git a/wpilibc/athena/src/Task.cpp b/wpilibc/athena/src/Task.cpp index 3c2217cc2a..33db422efc 100644 --- a/wpilibc/athena/src/Task.cpp +++ b/wpilibc/athena/src/Task.cpp @@ -7,9 +7,8 @@ #include "Task.h" -#include -#include -#include +#include + #include "WPIErrors.h" #ifndef OK diff --git a/wpilibc/athena/src/Utility.cpp b/wpilibc/athena/src/Utility.cpp index 99013755a6..420e655ca0 100644 --- a/wpilibc/athena/src/Utility.cpp +++ b/wpilibc/athena/src/Utility.cpp @@ -9,11 +9,7 @@ #include #include -#include -#include -#include -#include #include #include "HAL/HAL.h" diff --git a/wpilibc/athena/src/Vision/BaeUtilities.cpp b/wpilibc/athena/src/Vision/BaeUtilities.cpp index 3d625f1329..eda5923d72 100644 --- a/wpilibc/athena/src/Vision/BaeUtilities.cpp +++ b/wpilibc/athena/src/Vision/BaeUtilities.cpp @@ -5,11 +5,10 @@ /* the project. */ /*----------------------------------------------------------------------------*/ -#include -#include -#include -#include -#include +#include +#include +#include + #include #include #include @@ -199,12 +198,12 @@ void ShowActivity(char* fmt, ...) { va_start(args, fmt); - vsprintf(text, fmt, args); + std::vsprintf(text, fmt, args); ai = ai == 3 ? 0 : ai + 1; - printf("%c %s \r", activity_indication_string[ai], text); - fflush(stdout); + std::printf("%c %s \r", activity_indication_string[ai], text); + std::fflush(stdout); va_end(args); } @@ -238,7 +237,7 @@ double SinPosition(double* period, double sinStart) { // Adding sinStart to the part multiplied by PI, but not by 2, allows it to // work as described in the comments. sinArg = PI * ((2.0 * (GetTime() - timestamp)) + sinStart) / sinePeriod; - rtnVal = sin(sinArg); + rtnVal = std::sin(sinArg); return (rtnVal); } diff --git a/wpilibc/athena/src/Vision/BinaryImage.cpp b/wpilibc/athena/src/Vision/BinaryImage.cpp index 3104586cf0..de6f651041 100644 --- a/wpilibc/athena/src/Vision/BinaryImage.cpp +++ b/wpilibc/athena/src/Vision/BinaryImage.cpp @@ -7,12 +7,10 @@ #include "Vision/BinaryImage.h" -#include +#include #include "WPIErrors.h" -using namespace std; - /** * Get then number of particles for the image. * @@ -109,9 +107,9 @@ void BinaryImage::GetParticleAnalysisReport(int particleNumber, * @return a pointer to the vector of particle analysis reports. The caller * must delete the vector when finished using it. */ -vector* +std::vector* BinaryImage::GetOrderedParticleAnalysisReports() { - auto particles = new vector; + auto particles = new std::vector; int particleCount = GetNumberParticles(); for (int particleIndex = 0; particleIndex < particleCount; particleIndex++) { particles->push_back(GetParticleAnalysisReport(particleIndex)); @@ -120,7 +118,7 @@ BinaryImage::GetOrderedParticleAnalysisReports() { // both reports being compared... do it manually instead... while we're // at it, we should provide a version that allows a preallocated buffer of // ParticleAnalysisReport structures - sort(particles->begin(), particles->end(), CompareParticleSizes); + std::sort(particles->begin(), particles->end(), CompareParticleSizes); return particles; } @@ -133,7 +131,7 @@ BinaryImage::GetOrderedParticleAnalysisReports() { */ void BinaryImage::Write(const char* fileName) { RGBValue colorTable[256]; - memset(colorTable, 0, sizeof(colorTable)); + std::memset(colorTable, 0, sizeof(colorTable)); colorTable[0].R = 0; colorTable[1].R = 255; colorTable[0].G = colorTable[1].G = 0; diff --git a/wpilibc/athena/src/Vision/FrcError.cpp b/wpilibc/athena/src/Vision/FrcError.cpp index 0e867bee29..4e5b384f80 100644 --- a/wpilibc/athena/src/Vision/FrcError.cpp +++ b/wpilibc/athena/src/Vision/FrcError.cpp @@ -12,12 +12,7 @@ * Get the error code returned from the NI Vision library * @return The last error code. */ -int GetLastVisionError() { - // int errorCode = imaqGetLastVisionError(); // error code: 0 = no error - // char* errorText = GetVisionErrorText(errorCode); - // dprintf (LOG_DEBUG, "Error = %i %s ", errorCode, errorText); - return imaqGetLastError(); -} +int GetLastVisionError() { return imaqGetLastError(); } /** * Get the error text for an NI Vision error code. diff --git a/wpilibc/athena/src/Vision/MonoImage.cpp b/wpilibc/athena/src/Vision/MonoImage.cpp index 7f0e872031..0a2ee08f00 100644 --- a/wpilibc/athena/src/Vision/MonoImage.cpp +++ b/wpilibc/athena/src/Vision/MonoImage.cpp @@ -8,8 +8,6 @@ #include "Vision/MonoImage.h" #include "nivision.h" -using namespace std; - MonoImage::MonoImage() : ImageBase(IMAQ_IMAGE_U8) {} /** @@ -23,14 +21,14 @@ MonoImage::MonoImage() : ImageBase(IMAQ_IMAGE_U8) {} * @param roi Region of Interest * @returns a vector of EllipseMatch structures (0 length vector on no match) */ -vector* MonoImage::DetectEllipses( +std::vector* MonoImage::DetectEllipses( EllipseDescriptor* ellipseDescriptor, CurveOptions* curveOptions, ShapeDetectionOptions* shapeDetectionOptions, ROI* roi) { int numberOfMatches; EllipseMatch* e = imaqDetectEllipses(m_imaqImage, ellipseDescriptor, curveOptions, shapeDetectionOptions, roi, &numberOfMatches); - auto ellipses = new vector; + auto ellipses = new std::vector; if (e == nullptr) { return ellipses; } @@ -41,9 +39,9 @@ vector* MonoImage::DetectEllipses( return ellipses; } -vector* MonoImage::DetectEllipses( +std::vector* MonoImage::DetectEllipses( EllipseDescriptor* ellipseDescriptor) { - vector* ellipses = + std::vector* ellipses = DetectEllipses(ellipseDescriptor, nullptr, nullptr, nullptr); return ellipses; } diff --git a/wpilibc/athena/src/Vision/VisionAPI.cpp b/wpilibc/athena/src/Vision/VisionAPI.cpp index cdb38556de..9c1af736b2 100644 --- a/wpilibc/athena/src/Vision/VisionAPI.cpp +++ b/wpilibc/athena/src/Vision/VisionAPI.cpp @@ -5,8 +5,7 @@ /* the project. */ /*----------------------------------------------------------------------------*/ -#include -#include +#include #include "Vision/BaeUtilities.h" #include "Vision/FrcError.h" @@ -652,7 +651,7 @@ int frcSmartThreshold(Image* dest, const Image* source, * @param rangeMin The lower boundary of the range of pixel values to keep * @param rangeMax The upper boundary of the range of pixel values to keep. * - * @return int - error code: 0 = error. To get extended error information, call + * @return error code: 0 = error. To get extended error information, call * GetLastError(). */ int frcSimpleThreshold(Image* dest, const Image* source, float rangeMin, @@ -675,7 +674,7 @@ int frcSimpleThreshold(Image* dest, const Image* source, float rangeMin, * @param newValue The replacement value for pixels within the range. Use the * simplified call to leave the pixel values unchanged * - * @return int - error code: 0 = error. To get extended error information, call + * @return error code: 0 = error. To get extended error information, call * GetLastError(). */ int frcSimpleThreshold(Image* dest, const Image* source, float rangeMin, diff --git a/wpilibc/shared/include/Base.h b/wpilibc/shared/include/Base.h index 87c36a6e7a..71a8d1d9db 100644 --- a/wpilibc/shared/include/Base.h +++ b/wpilibc/shared/include/Base.h @@ -79,7 +79,8 @@ struct HasBeenMoved { // Define make_unique for C++11-only compilers #if __cplusplus == 201103L -#include +#include + #include #include #include diff --git a/wpilibc/shared/include/SensorBase.h b/wpilibc/shared/include/SensorBase.h index 1689012bd1..87c7abd856 100644 --- a/wpilibc/shared/include/SensorBase.h +++ b/wpilibc/shared/include/SensorBase.h @@ -7,7 +7,8 @@ #pragma once -#include +#include + #include "Base.h" #include "ErrorBase.h" diff --git a/wpilibc/shared/src/Error.cpp b/wpilibc/shared/src/Error.cpp index 725996c29c..188a44c748 100644 --- a/wpilibc/shared/src/Error.cpp +++ b/wpilibc/shared/src/Error.cpp @@ -7,10 +7,6 @@ #include "Error.h" -#include -#include - -#include #include #include "DriverStation.h" diff --git a/wpilibc/shared/src/ErrorBase.cpp b/wpilibc/shared/src/ErrorBase.cpp index 969a377f8b..2f9401056a 100644 --- a/wpilibc/shared/src/ErrorBase.cpp +++ b/wpilibc/shared/src/ErrorBase.cpp @@ -7,8 +7,7 @@ #include "ErrorBase.h" -#include - +#include #include #include diff --git a/wpilibc/shared/src/SmartDashboard/SendableChooser.cpp b/wpilibc/shared/src/SmartDashboard/SendableChooser.cpp index 6e7cd0f04a..f76018696e 100644 --- a/wpilibc/shared/src/SmartDashboard/SendableChooser.cpp +++ b/wpilibc/shared/src/SmartDashboard/SendableChooser.cpp @@ -7,8 +7,6 @@ #include "SmartDashboard/SendableChooser.h" -#include - static const std::string kDefault = "default"; static const std::string kOptions = "options"; static const std::string kSelected = "selected"; diff --git a/wpilibc/sim/include/RobotDrive.h b/wpilibc/sim/include/RobotDrive.h index 3081deb7d5..2008aa071b 100644 --- a/wpilibc/sim/include/RobotDrive.h +++ b/wpilibc/sim/include/RobotDrive.h @@ -7,7 +7,8 @@ #pragma once -#include +#include + #include #include "ErrorBase.h" #include "MotorSafety.h" diff --git a/wpilibc/sim/src/AnalogGyro.cpp b/wpilibc/sim/src/AnalogGyro.cpp index 9063f2c162..9c92032fbf 100644 --- a/wpilibc/sim/src/AnalogGyro.cpp +++ b/wpilibc/sim/src/AnalogGyro.cpp @@ -6,6 +6,9 @@ /*----------------------------------------------------------------------------*/ #include "AnalogGyro.h" + +#include + #include "LiveWindow/LiveWindow.h" #include "Timer.h" #include "WPIErrors.h" diff --git a/wpilibc/sim/src/AnalogInput.cpp b/wpilibc/sim/src/AnalogInput.cpp index 5d74bf0f6b..e292ac22ad 100644 --- a/wpilibc/sim/src/AnalogInput.cpp +++ b/wpilibc/sim/src/AnalogInput.cpp @@ -6,6 +6,9 @@ /*----------------------------------------------------------------------------*/ #include "AnalogInput.h" + +#include + #include "LiveWindow/LiveWindow.h" #include "WPIErrors.h" diff --git a/wpilibc/sim/src/DigitalInput.cpp b/wpilibc/sim/src/DigitalInput.cpp index f59305fb2f..d3759cab72 100644 --- a/wpilibc/sim/src/DigitalInput.cpp +++ b/wpilibc/sim/src/DigitalInput.cpp @@ -6,6 +6,9 @@ /*----------------------------------------------------------------------------*/ #include "DigitalInput.h" + +#include + #include "WPIErrors.h" /** diff --git a/wpilibc/sim/src/Encoder.cpp b/wpilibc/sim/src/Encoder.cpp index 579d2cad48..23de59ba5f 100644 --- a/wpilibc/sim/src/Encoder.cpp +++ b/wpilibc/sim/src/Encoder.cpp @@ -6,6 +6,9 @@ /*----------------------------------------------------------------------------*/ #include "Encoder.h" + +#include + #include "LiveWindow/LiveWindow.h" #include "Resource.h" #include "WPIErrors.h" @@ -27,8 +30,8 @@ * value will either exactly match the spec'd count or * be double (2x) the spec'd count. */ -void Encoder::InitEncoder(int channelA, int channelB, bool reverseDirection, - EncodingType encodingType) { +void Encoder::InitEncoder(int32_t channelA, int32_t channelB, + bool reverseDirection, EncodingType encodingType) { m_table = nullptr; this->channelA = channelA; this->channelB = channelB; diff --git a/wpilibc/sim/src/MotorSafetyHelper.cpp b/wpilibc/sim/src/MotorSafetyHelper.cpp index 14e3e271ff..c3f13388b3 100644 --- a/wpilibc/sim/src/MotorSafetyHelper.cpp +++ b/wpilibc/sim/src/MotorSafetyHelper.cpp @@ -12,7 +12,6 @@ #include "Timer.h" #include "WPIErrors.h" -#include #include std::set MotorSafetyHelper::m_helperList; diff --git a/wpilibc/sim/src/SampleRobot.cpp b/wpilibc/sim/src/SampleRobot.cpp index 3b282f25d5..d01ec69778 100644 --- a/wpilibc/sim/src/SampleRobot.cpp +++ b/wpilibc/sim/src/SampleRobot.cpp @@ -7,7 +7,8 @@ #include "SampleRobot.h" -#include +#include + #include "LiveWindow/LiveWindow.h" #include "SmartDashboard/SmartDashboard.h" #include "Timer.h" @@ -29,7 +30,7 @@ SampleRobot::SampleRobot() : m_robotMainOverridden(true) {} * which will be called each time the robot enters the disabled state. */ void SampleRobot::RobotInit() { - printf("Default %s() method... Override me!\n", __FUNCTION__); + std::printf("Default %s() method... Override me!\n", __FUNCTION__); } /** @@ -39,7 +40,7 @@ void SampleRobot::RobotInit() { * field is disabled. */ void SampleRobot::Disabled() { - printf("Default %s() method... Override me!\n", __FUNCTION__); + std::printf("Default %s() method... Override me!\n", __FUNCTION__); } /** @@ -50,7 +51,7 @@ void SampleRobot::Disabled() { * robot enters the autonomous state. */ void SampleRobot::Autonomous() { - printf("Default %s() method... Override me!\n", __FUNCTION__); + std::printf("Default %s() method... Override me!\n", __FUNCTION__); } /** @@ -61,7 +62,7 @@ void SampleRobot::Autonomous() { * each time the robot enters the teleop state. */ void SampleRobot::OperatorControl() { - printf("Default %s() method... Override me!\n", __FUNCTION__); + std::printf("Default %s() method... Override me!\n", __FUNCTION__); } /** @@ -72,7 +73,7 @@ void SampleRobot::OperatorControl() { * test mode. */ void SampleRobot::Test() { - printf("Default %s() method... Override me!\n", __FUNCTION__); + std::printf("Default %s() method... Override me!\n", __FUNCTION__); } /** diff --git a/wpilibc/sim/src/Solenoid.cpp b/wpilibc/sim/src/Solenoid.cpp index 9086d18464..5bc63cd4ed 100644 --- a/wpilibc/sim/src/Solenoid.cpp +++ b/wpilibc/sim/src/Solenoid.cpp @@ -6,6 +6,9 @@ /*----------------------------------------------------------------------------*/ #include "Solenoid.h" + +#include + #include "LiveWindow/LiveWindow.h" #include "WPIErrors.h" #include "simulation/simTime.h" diff --git a/wpilibc/sim/src/Timer.cpp b/wpilibc/sim/src/Timer.cpp index db09a471e4..46d36cad2d 100644 --- a/wpilibc/sim/src/Timer.cpp +++ b/wpilibc/sim/src/Timer.cpp @@ -86,7 +86,7 @@ Timer::Timer() : m_startTime(0.0), m_accumulatedTime(0.0), m_running(false) { * start time stored in the timer class. If the clock is not running, then * return the time when it was last stopped. * - * @return unsigned Current time value for this timer in seconds + * @return Current time value for this timer in seconds */ double Timer::Get() const { double result; diff --git a/wpilibc/sim/src/Utility.cpp b/wpilibc/sim/src/Utility.cpp index c272d3ec96..d296784777 100644 --- a/wpilibc/sim/src/Utility.cpp +++ b/wpilibc/sim/src/Utility.cpp @@ -7,10 +7,7 @@ #include "Utility.h" -#include -#include -#include - +#include #include #include #if not defined(_WIN32) @@ -43,10 +40,10 @@ void wpi_suspendOnAssertEnabled(bool enabled) { static void wpi_handleTracing() { // if (stackTraceEnabled) // { - // printf("\n---------------------------\n"); + // std::printf("\n---------------------------\n"); // printCurrentStackTrace(); // } - printf("\n"); + std::printf("\n"); } /**