Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-07-04 03:11:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Deprecated PIDController::SetTolerance() (#764)

Browse Source 
PIDController::SetPercentTolerance() behaves identically to it, so removing
SetTolerance() leaves one obvious way to do absolute or percent tolerance.
This commit is contained in:
Tyler Veness
2017-11-23 01:21:36 -08:00
committed by Peter Johnson
parent d36d72bd4f
commit 5c659fdcdf
2 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
wpilibc/src/main/native/include/PIDController.h
View File

@@ -75,6 +75,7 @@ class PIDController : public LiveWindowSendable, public PIDInterface {
virtual void SetPIDSourceType(PIDSourceType pidSource);
virtual PIDSourceType GetPIDSourceType() const;
WPI_DEPRECATED("Use SetPercentTolerance() instead.")
virtual void SetTolerance(double percent);
virtual void SetAbsoluteTolerance(double absValue);
virtual void SetPercentTolerance(double percentValue);

4
wpilibj/src/main/java/edu/wpi/first/wpilibj/PIDController.java
View File

@@ -554,9 +554,11 @@ public class PIDController implements PIDInterface, LiveWindowSendable, Controll
* object. Use it by creating the type of tolerance that you want to use: setTolerance(new
* PIDController.AbsoluteTolerance(0.1))
*
* @param tolerance a tolerance object of the right type, e.g. PercentTolerance or
* @deprecated Use setPercentTolerance() instead.
* @param tolerance A tolerance object of the right type, e.g. PercentTolerance or
* AbsoluteTolerance
*/
@Deprecated
public void setTolerance(Tolerance tolerance) {
m_tolerance = tolerance;
}