[oldcommands] Deprecate PIDWrappers, since they use deprecated interfaces (#3868)

This commit is contained in:
sciencewhiz
2022-01-06 18:05:24 -08:00
committed by GitHub
parent b6f44f98be
commit 5ccfc4adbd
14 changed files with 90 additions and 13 deletions

View File

@@ -9,7 +9,13 @@ import edu.wpi.first.wpilibj.AnalogInput;
import edu.wpi.first.wpilibj.PIDSource;
import edu.wpi.first.wpilibj.PIDSourceType;
/** Wrapper so that PIDSource is implemented for AnalogAccelerometer for old PIDController. */
/**
* Wrapper so that PIDSource is implemented for AnalogAccelerometer for old PIDController.
*
* @deprecated Use {@link edu.wpi.first.math.controller.PIDController} which doesn't require this
* wrapper.
*/
@Deprecated(since = "2022", forRemoval = true)
public class PIDAnalogAccelerometer extends AnalogAccelerometer implements PIDSource {
protected PIDSourceType m_pidSource = PIDSourceType.kDisplacement;

View File

@@ -9,7 +9,13 @@ import edu.wpi.first.wpilibj.AnalogInput;
import edu.wpi.first.wpilibj.PIDSource;
import edu.wpi.first.wpilibj.PIDSourceType;
/** Wrapper so that PIDSource is implemented for AnalogGyro for old PIDController. */
/**
* Wrapper so that PIDSource is implemented for AnalogGyro for old PIDController.
*
* @deprecated Use {@link edu.wpi.first.math.controller.PIDController} which doesn't require this
* wrapper.
*/
@Deprecated(since = "2022", forRemoval = true)
public class PIDAnalogGyro extends AnalogGyro implements PIDSource {
private PIDSourceType m_pidSource = PIDSourceType.kDisplacement;

View File

@@ -8,7 +8,13 @@ import edu.wpi.first.wpilibj.AnalogInput;
import edu.wpi.first.wpilibj.PIDSource;
import edu.wpi.first.wpilibj.PIDSourceType;
/** Wrapper so that PIDSource is implemented for AnalogInput for old PIDController. */
/**
* Wrapper so that PIDSource is implemented for AnalogInput for old PIDController.
*
* @deprecated Use {@link edu.wpi.first.math.controller.PIDController} which doesn't require this
* wrapper.
*/
@Deprecated(since = "2022", forRemoval = true)
public class PIDAnalogInput extends AnalogInput implements PIDSource {
protected PIDSourceType m_pidSource = PIDSourceType.kDisplacement;

View File

@@ -9,7 +9,13 @@ import edu.wpi.first.wpilibj.AnalogPotentiometer;
import edu.wpi.first.wpilibj.PIDSource;
import edu.wpi.first.wpilibj.PIDSourceType;
/** Wrapper so that PIDSource is implemented for AnalogPotentiometer for old PIDController. */
/**
* Wrapper so that PIDSource is implemented for AnalogPotentiometer for old PIDController.
*
* @deprecated Use {@link edu.wpi.first.math.controller.PIDController} which doesn't require this
* wrapper.
*/
@Deprecated(since = "2022", forRemoval = true)
public class PIDAnalogPotentiometer extends AnalogPotentiometer implements PIDSource {
protected PIDSourceType m_pidSource = PIDSourceType.kDisplacement;

View File

@@ -9,7 +9,13 @@ import edu.wpi.first.wpilibj.Encoder;
import edu.wpi.first.wpilibj.PIDSource;
import edu.wpi.first.wpilibj.PIDSourceType;
/** Wrapper so that PIDSource is implemented for Encoder for old PIDController. */
/**
* Wrapper so that PIDSource is implemented for Encoder for old PIDController.
*
* @deprecated Use {@link edu.wpi.first.math.controller.PIDController} which doesn't require this
* wrapper.
*/
@Deprecated(since = "2022", forRemoval = true)
public class PIDEncoder extends Encoder implements PIDSource {
private PIDSourceType m_pidSource = PIDSourceType.kDisplacement;

View File

@@ -9,7 +9,13 @@ import edu.wpi.first.util.sendable.SendableBuilder;
import edu.wpi.first.wpilibj.PIDOutput;
import edu.wpi.first.wpilibj.motorcontrol.MotorController;
/** Wrapper so that PIDOutput is implemented for MotorController for old PIDController. */
/**
* Wrapper so that PIDOutput is implemented for MotorController for old PIDController.
*
* @deprecated Use {@link edu.wpi.first.math.controller.PIDController} which doesn't require this
* wrapper.
*/
@Deprecated(since = "2022", forRemoval = true)
public class PIDMotorController implements PIDOutput, MotorController, Sendable {
private final MotorController m_motorController;

View File

@@ -10,7 +10,13 @@ import edu.wpi.first.wpilibj.PIDSource;
import edu.wpi.first.wpilibj.PIDSourceType;
import edu.wpi.first.wpilibj.Ultrasonic;
/** Wrapper so that PIDSource is implemented for Ultrasonic for old PIDController. */
/**
* Wrapper so that PIDSource is implemented for Ultrasonic for old PIDController.
*
* @deprecated Use {@link edu.wpi.first.math.controller.PIDController} which doesn't require this
* wrapper.
*/
@Deprecated(since = "2022", forRemoval = true)
public class PIDUltrasonic extends Ultrasonic implements PIDSource {
protected PIDSourceType m_pidSource = PIDSourceType.kDisplacement;

View File

@@ -12,8 +12,13 @@ namespace frc {
/**
* Wrapper so that PIDSource is implemented for AnalogAccelerometer for old
* PIDController
*
* @deprecated Use frc2::PIDController class instead which doesn't require this
* wrapper.
*/
class PIDAnalogAccelerometer : public PIDSource, public AnalogAccelerometer {
class WPI_DEPRECATED("Use frc2::PIDController class instead.")
PIDAnalogAccelerometer : public PIDSource,
public AnalogAccelerometer {
using AnalogAccelerometer::AnalogAccelerometer;
public:

View File

@@ -11,8 +11,13 @@ namespace frc {
/**
* Wrapper so that PIDSource is implemented for AnalogGyro for old PIDController
*
* @deprecated Use frc2::PIDController class instead which doesn't require this
* wrapper.
*/
class PIDAnalogGyro : public PIDSource, public AnalogGyro {
class WPI_DEPRECATED("Use frc2::PIDController class instead.") PIDAnalogGyro
: public PIDSource,
public AnalogGyro {
using AnalogGyro::AnalogGyro;
public:

View File

@@ -12,8 +12,13 @@ namespace frc {
/**
* Wrapper so that PIDSource is implemented for AnalogInput for old
* PIDController
*
* @deprecated Use frc2::PIDController class instead which doesn't require this
* wrapper.
*/
class PIDAnalogInput : public PIDSource, public AnalogInput {
class WPI_DEPRECATED("Use frc2::PIDController class instead.") PIDAnalogInput
: public PIDSource,
public AnalogInput {
using AnalogInput::AnalogInput;
public:

View File

@@ -12,8 +12,14 @@ namespace frc {
/**
* Wrapper so that PIDSource is implemented for AnalogPotentiometer for old
* PIDController
*
*
* @deprecated Use frc2::PIDController class instead which doesn't require this
* wrapper.
*/
class PIDAnalogPotentiometer : public PIDSource, public AnalogPotentiometer {
class WPI_DEPRECATED("Use frc2::PIDController class instead.")
PIDAnalogPotentiometer : public PIDSource,
public AnalogPotentiometer {
using AnalogPotentiometer::AnalogPotentiometer;
public:

View File

@@ -11,8 +11,13 @@ namespace frc {
/**
* Wrapper so that PIDSource is implemented for Encoder for old PIDController
*
* @deprecated Use frc2::PIDController class instead which doesn't require this
* wrapper.
*/
class PIDEncoder : public PIDSource, public Encoder {
class WPI_DEPRECATED("Use frc2::PIDController class instead.") PIDEncoder
: public PIDSource,
public Encoder {
using Encoder::Encoder;
public:

View File

@@ -15,11 +15,15 @@ namespace frc {
/**
* Wrapper so that PIDOutput is implemented for MotorController for old
* PIDController
*
* @deprecated Use frc2::PIDController class instead which doesn't require this
* wrapper.
*/
class PIDMotorController : public PIDOutput,
public MotorController,
public wpi::Sendable {
public:
WPI_DEPRECATED("Use frc2::PIDController class instead.")
explicit PIDMotorController(MotorController& motorController);
/**

View File

@@ -11,8 +11,13 @@ namespace frc {
/**
* Wrapper so that PIDSource is implemented for Ultrasonic for old PIDController
*
* @deprecated Use frc2::PIDController class instead which doesn't require this
* wrapper.
*/
class PIDUltrasonic : public PIDSource, public Ultrasonic {
class WPI_DEPRECATED("Use frc2::PIDController class instead.") PIDUltrasonic
: public PIDSource,
public Ultrasonic {
using Ultrasonic::Ultrasonic;
public: