Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-25 01:41:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Storage: Disable use of update queue by default.

Browse Source 
This ensures we don't "leak" memory for local use when the dispatch thread
is not running.
This commit is contained in:
Peter Johnson
2015-07-20 22:24:47 -07:00
parent 0979c1c9ca
commit 5df62ac172
3 changed files with 26 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/Storage.h
View File

@@ -91,8 +91,12 @@ class Storage {
std::shared_ptr<StorageEntry> FindEntry(StringRef name) const;
std::shared_ptr<StorageEntry> GetEntry(StringRef name);
// Accessors required by Dispatcher.
void EnableUpdates() { m_updates_enabled = true; }
void DisableUpdates() { m_updates_enabled = false; }
UpdateQueue& updates() { return m_updates; }
// User functions
std::shared_ptr<Value> GetEntryValue(StringRef name) const;
bool SetEntryValue(StringRef name, std::shared_ptr<Value> value);
void SetEntryTypeValue(StringRef name, std::shared_ptr<Value> value);
@@ -112,11 +116,17 @@ class Storage {
Storage(const Storage&) = delete;
Storage& operator=(const Storage&) = delete;
void AddUpdate(std::shared_ptr<StorageEntry> entry, Update::Kind kind) {
if (m_updates_enabled)
m_updates.push(Update{entry, kind});
}
typedef llvm::StringMap<std::shared_ptr<StorageEntry>> EntriesMap;
mutable std::mutex m_mutex;
EntriesMap m_entries;
UpdateQueue m_updates;
std::atomic_bool m_updates_enabled;
static std::unique_ptr<Storage> m_instance;
};