mirror of
https://github.com/wpilibsuite/allwpilib
synced 2026-06-20 00:51:42 +00:00
Replace std::lock_guard and std::lock with std::scoped_lock (#1758)
std::scoped_lock was introduced in C++17 and is strictly better than std::lock_guard as it supports locking any number of mutexes safely. It's also easier to use than std::lock for locking multiple mutexes at once.
This commit is contained in:
committed by
Peter Johnson
parent
24d31df55a
commit
62be0392b6
@@ -41,7 +41,7 @@ PIDController::~PIDController() {
|
||||
|
||||
void PIDController::Enable() {
|
||||
{
|
||||
std::lock_guard lock(m_thisMutex);
|
||||
std::scoped_lock lock(m_thisMutex);
|
||||
m_enabled = true;
|
||||
}
|
||||
}
|
||||
@@ -49,9 +49,9 @@ void PIDController::Enable() {
|
||||
void PIDController::Disable() {
|
||||
{
|
||||
// Ensures m_enabled modification and PIDWrite() call occur atomically
|
||||
std::lock_guard pidWriteLock(m_pidWriteMutex);
|
||||
std::scoped_lock pidWriteLock(m_pidWriteMutex);
|
||||
{
|
||||
std::lock_guard mainLock(m_thisMutex);
|
||||
std::scoped_lock mainLock(m_thisMutex);
|
||||
m_enabled = false;
|
||||
}
|
||||
|
||||
@@ -68,7 +68,7 @@ void PIDController::SetEnabled(bool enable) {
|
||||
}
|
||||
|
||||
bool PIDController::IsEnabled() const {
|
||||
std::lock_guard lock(m_thisMutex);
|
||||
std::scoped_lock lock(m_thisMutex);
|
||||
return m_enabled;
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user