Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-22 01:11:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

[commands] Remove unsafe default command isFinished check (#4411)

Browse Source
This commit is contained in:
Starlight220
2022-11-15 00:28:30 +02:00
committed by GitHub
parent 1269d2b901
commit 64838e6367
3 changed files with 0 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
wpilibNewCommands/src/main/native/include/frc2/command/CommandScheduler.h
View File

@@ -182,10 +182,6 @@ class CommandScheduler final : public nt::NTSendable,
throw FRC_MakeError(frc::err::CommandIllegalUse,
"Default commands must require their subsystem!");
}
if (defaultCommand.IsFinished()) {
throw FRC_MakeError(frc::err::CommandIllegalUse,
"Default commands should not end!");
}
SetDefaultCommandImpl(subsystem,
std::make_unique<std::remove_reference_t<T>>(
std::forward<T>(defaultCommand)));