From 65797caa7bffa5f25712e0c03a64beac727de15a Mon Sep 17 00:00:00 2001 From: Tyler Veness Date: Tue, 14 Sep 2021 20:49:02 -0700 Subject: [PATCH] [sim] Fix halsim_ds_socket stringop overflow warning from GCC 10 (#3568) Fixes #3567. --- .../halsim_ds_socket/src/main/native/cpp/DSCommPacket.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/simulation/halsim_ds_socket/src/main/native/cpp/DSCommPacket.cpp b/simulation/halsim_ds_socket/src/main/native/cpp/DSCommPacket.cpp index 9088bd7ee8..1aff98843e 100644 --- a/simulation/halsim_ds_socket/src/main/native/cpp/DSCommPacket.cpp +++ b/simulation/halsim_ds_socket/src/main/native/cpp/DSCommPacket.cpp @@ -239,7 +239,9 @@ void DSCommPacket::ReadJoystickDescriptionTag(wpi::span data) { packet.descriptor.name[nameLength] = '\0'; int axesCount = data[0]; packet.descriptor.axisCount = axesCount; - for (int i = 0; i < axesCount; i++) { + for (int i = 0, + len = std::min(axesCount, sizeof(packet.descriptor.axisTypes)); + i < len; i++) { packet.descriptor.axisTypes[i] = data[1 + i]; } data = data.subspan(1 + axesCount);