[python] Improve robotpy generation (#8867)

The initial build file generation for robotpy projects was relatively
naive and purpose built to get `allwpilib` compiling, without supporting
all the available features.

This modifies the generation scripts to be able to support multiple
embedded libraries, which will be necessary for #8858, since `mrclib.so`
will need to be bundled along with the hal libraries. In addition some
cleanup was done to get the wheels looking more like what is in pypi.

shared/bazel/rules/robotpy/generate_native_build_file.py

@@ -3,12 +3,14 @@ import json
 
 import tomli
 from jinja2 import BaseLoader, Environment
+from packaging.markers import Marker
 
 from shared.bazel.rules.robotpy.generation_utils import (
     fixup_python_dep_name,
     fixup_root_package_name,
-    fixup_shared_lib_name,
 )
+from shared.bazel.rules.robotpy.hatchlib_native_port.config import PcFileConfig
+from shared.bazel.rules.robotpy.hatchlib_native_port.validate import parse_input
 
 
 def main():
@@ -40,20 +42,48 @@ def main():
     env.filters["double_quotes"] = double_quotes
     env.filters["get_pc_dep"] = get_pc_dep
     env.filters["get_python_dep"] = get_python_dep
+    env.filters["strip_src_prefix"] = lambda x: str(x).removeprefix("src/")
     template = env.from_string(BUILD_FILE_TEMPLATE)
 
     nativelib_config = raw_config["tool"]["hatch"]["build"]["hooks"]["nativelib"]
-    project_name = nativelib_config["pcfile"][0]["name"]
+    project_name = raw_config["project"]["name"].replace("robotpy-native-", "")
     root_package = fixup_root_package_name(project_name)
-    shared_library_name = fixup_shared_lib_name(project_name)
+    pc_files = []
+
+    local_pc_names = set()
+    for i, raw_pc in enumerate(nativelib_config.get("pcfile", [])):
+        pcfile = parse_input(
+            raw_pc,
+            PcFileConfig,
+            "pyproject.toml",
+            f"tool.hatch.build.hooks.nativelib.pcfile[{i}]",
+        )
+        if pcfile.enable_if and not Marker(pcfile.enable_if).evaluate():
+            continue
+        pc_files.append(pcfile)
+        local_pc_names.add(pcfile.get_pc_path().name[:-3])
+
+    requires = set()
+    for pcfile in pc_files:
+        if pcfile.requires:
+            for dep in pcfile.requires:
+                if dep not in local_pc_names:
+                    requires.add(dep)
+
+    maven_downloads = raw_config["tool"]["hatch"]["build"]["hooks"]["robotpy"][
+        "maven_lib_download"
+    ]
     with open(args.output_file, "w") as f:
         f.write(
             template.render(
                 raw_project_config=raw_config["project"],
                 nativelib_config=nativelib_config,
                 root_package=root_package,
-                shared_library_name=shared_library_name,
+                maven_downloads=maven_downloads,
                 third_party_dirs=args.third_party_dirs or [],
+                pc_files=pc_files,
+                requires=requires,
+                project_name=project_name,
             )
         )
 
@@ -61,9 +91,11 @@ def main():
 BUILD_FILE_TEMPLATE = """# THIS FILE IS AUTO GENERATED
 
 load("@aspect_bazel_lib//lib:copy_to_directory.bzl", "copy_to_directory")
-load("//shared/bazel/rules/robotpy:pybind_rules.bzl", "native_wrappery_library")
+load("//shared/bazel/rules/robotpy:robotpy_rules.bzl", "copy_native_file", "generate_native_files", "robotpy_library")
 
 def define_native_wrapper(name, pyproject_toml = None):
+    pyproject_toml = pyproject_toml or "src/main/python/native-pyproject.toml"
+
     copy_to_directory(
         name = "{}.copy_headers".format(name),
         srcs = native.glob(["src/main/native/include/**"]) + native.glob(["src/generated/main/native/include/**"], allow_empty = True){% if third_party_dirs %} + native.glob([
@@ -71,7 +103,7 @@ def define_native_wrapper(name, pyproject_toml = None):
             "src/main/native/thirdparty/{{dir}}/include/**",
         {%- endfor %}
         ]){%- endif %},
-        out = "native/{{nativelib_config.pcfile[0].name}}/include",
+        out = "native/{{project_name}}/include",
         root_paths = ["src/main/native/include/"],
         replace_prefixes = {
             "{{root_package}}/src/generated/main/native/include": "",
@@ -84,30 +116,57 @@ def define_native_wrapper(name, pyproject_toml = None):
         visibility = ["//visibility:public"],
     )
 
-    native_wrappery_library(
+    libinit_files = [{% for pcfile in pc_files %}"{{pcfile.get_init_module_path() | strip_src_prefix}}"{% if not loop.last %}, {% endif %}{%- endfor %}]
+
+    generate_native_files(
         name = name,
-        pyproject_toml = pyproject_toml or "src/main/python/native-pyproject.toml",
-        libinit_file = "native/{{nativelib_config.pcfile[0].name}}/_init_{{raw_project_config.name.replace("-", "_")}}.py",
-        pc_file = "native/{{nativelib_config.pcfile[0].name}}/{{raw_project_config.name}}.pc",
+        pyproject_toml = pyproject_toml,
         pc_deps = [
-        {%- for dep in nativelib_config.pcfile[0].requires | sort %}
+        {%- for dep in requires | sort %}
             "{{dep | get_pc_dep}}",
         {%- endfor %}
         ],
+        libinit_files = libinit_files,
+        pc_files = [{% for pcfile in pc_files %}"{{pcfile.pcfile | strip_src_prefix}}"{% if not loop.last %}, {% endif %}{%- endfor %}],
+    )
+    {%- for maven_info in maven_downloads %}
+    {%- for lib in maven_info["libs"] %}
+
+    copy_native_file(
+        name = "{{lib}}",
+        library = "shared/{{lib}}",
+        base_path = "native/{{project_name}}/",
+    )
+    {%- endfor %}
+    {%- endfor %}
+
+    robotpy_library(
+        name = name,
+        distribution = "{{raw_project_config.name}}",
+        srcs = libinit_files,
+        data = [
+            name + ".pc_wrapper",
+    {%- for maven_info in maven_downloads %}
+    {%- for lib in maven_info["libs"] %}
+            ":{{lib}}.copy_lib",
+    {%- endfor %}
+    {%- endfor %}
+            "{}.copy_headers".format(name),
+        ],
         deps = [
-        {%- for dep in nativelib_config.pcfile[0].requires | sort %}
+        {%- for dep in requires | sort %}
             "{{dep | get_python_dep}}",
         {%- endfor %}
         ],
-        headers = "{}.copy_headers".format(name),
-        native_shared_library = "shared/{{shared_library_name}}",
-        install_path = "native/{{nativelib_config.pcfile[0].name}}/",
-        strip_path_prefixes = ["{{root_package}}"],
-        requires = {{raw_project_config.dependencies | double_quotes}},
         summary = "{{raw_project_config.description}}",
+        requires = {{raw_project_config.dependencies | double_quotes}},
+        python_requires = "{{raw_project_config["requires-python"]}}",
+        strip_path_prefixes = ["{{root_package}}"],
         entry_points = {
             "pkg_config": [
-                "{{nativelib_config.pcfile[0].name}} = native.{{nativelib_config.pcfile[0].name}}",
+            {%- for pcfile in pc_files %}
+                "{{pcfile.name}} = native.{{pcfile.name}}",
+            {%- endfor %}
             ],
         },
     )