diff --git a/hal/src/main/java/edu/wpi/first/hal/DIOJNI.java b/hal/src/main/java/edu/wpi/first/hal/DIOJNI.java index a62d8dd377..dab1aaf7b5 100644 --- a/hal/src/main/java/edu/wpi/first/hal/DIOJNI.java +++ b/hal/src/main/java/edu/wpi/first/hal/DIOJNI.java @@ -14,8 +14,7 @@ public class DIOJNI extends JNIWrapper { public static native void setDIOSimDevice(int handle, int device); - // TODO(Thad): Switch this to use boolean - public static native void setDIO(int dioPortHandle, short value); + public static native void setDIO(int dioPortHandle, boolean value); public static native void setDIODirection(int dioPortHandle, boolean input); diff --git a/hal/src/main/native/cpp/jni/DIOJNI.cpp b/hal/src/main/native/cpp/jni/DIOJNI.cpp index 236754169e..5cd6c2e9df 100644 --- a/hal/src/main/native/cpp/jni/DIOJNI.cpp +++ b/hal/src/main/native/cpp/jni/DIOJNI.cpp @@ -75,11 +75,11 @@ Java_edu_wpi_first_hal_DIOJNI_setDIOSimDevice /* * Class: edu_wpi_first_hal_DIOJNI * Method: setDIO - * Signature: (IS)V + * Signature: (IZ)V */ JNIEXPORT void JNICALL Java_edu_wpi_first_hal_DIOJNI_setDIO - (JNIEnv* env, jclass, jint id, jshort value) + (JNIEnv* env, jclass, jint id, jboolean value) { int32_t status = 0; HAL_SetDIO((HAL_DigitalHandle)id, value, &status); diff --git a/wpilibj/src/main/java/edu/wpi/first/wpilibj/DigitalOutput.java b/wpilibj/src/main/java/edu/wpi/first/wpilibj/DigitalOutput.java index eb07d8bfee..2c87df577d 100644 --- a/wpilibj/src/main/java/edu/wpi/first/wpilibj/DigitalOutput.java +++ b/wpilibj/src/main/java/edu/wpi/first/wpilibj/DigitalOutput.java @@ -57,7 +57,7 @@ public class DigitalOutput extends DigitalSource implements Sendable { * @param value true is on, off is false */ public void set(boolean value) { - DIOJNI.setDIO(m_handle, (short) (value ? 1 : 0)); + DIOJNI.setDIO(m_handle, value); } /**