Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-23 01:21:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

[build] Bring naming checkstyle rules up to date with Google Style guide (#1781)

Browse Source 
Also update Checkstyle to 8.38.

Google changed their style guide from the last time we imported it. This PR brings in those naming changes. The change they made is allowing single letter member, parameter, and local variable names. They also added a lambda naming scheme and I thought it would be good to bring that in too.
This commit is contained in:
Austin Shalit
2020-12-29 09:27:48 -08:00
committed by GitHub
parent 8c8ec5e63e
commit 6e1919414e
70 changed files with 224 additions and 285 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
hal/src/main/java/edu/wpi/first/hal/HAL.java
View File

@@ -95,7 +95,7 @@ public final class HAL extends JNIWrapper {
public static native int nativeGetControlWord();
@SuppressWarnings("JavadocMethod")
@SuppressWarnings("MissingJavadocMethod")
public static void getControlWord(ControlWord controlWord) {
int word = nativeGetControlWord();
controlWord.update((word & 1) != 0, ((word >> 1) & 1) != 0, ((word >> 2) & 1) != 0,
@@ -104,7 +104,7 @@ public final class HAL extends JNIWrapper {
private static native int nativeGetAllianceStation();
@SuppressWarnings("JavadocMethod")
@SuppressWarnings("MissingJavadocMethod")
public static AllianceStationID getAllianceStation() {
switch (nativeGetAllianceStation()) {
case 0:
@@ -124,13 +124,13 @@ public final class HAL extends JNIWrapper {
}
}
@SuppressWarnings("JavadocMethod")
@SuppressWarnings("MissingJavadocMethod")
public static native boolean isNewControlData();
@SuppressWarnings("JavadocMethod")
@SuppressWarnings("MissingJavadocMethod")
public static native void releaseDSMutex();
@SuppressWarnings("JavadocMethod")
@SuppressWarnings("MissingJavadocMethod")
public static native boolean waitForDSDataTimeout(double timeout);
public static int kMaxJoystickAxes = 12;

2
hal/src/main/java/edu/wpi/first/hal/MatchInfoData.java
View File

@@ -41,7 +41,7 @@ public class MatchInfoData {
/**
* Called from JNI to set the structure data.
*/
@SuppressWarnings("JavadocMethod")
@SuppressWarnings("MissingJavadocMethod")
public void setData(String eventName, String gameSpecificMessage,
int matchNumber, int replayNumber, int matchType) {
this.eventName = eventName;

2
hal/src/main/java/edu/wpi/first/hal/can/CANExceptionFactory.java
View File

@@ -14,7 +14,7 @@ public final class CANExceptionFactory {
static final int ERR_CANSessionMux_NotAllowed = -44088;
static final int ERR_CANSessionMux_NotInitialized = -44089;
@SuppressWarnings({"JavadocMethod", "PMD.CyclomaticComplexity"})
@SuppressWarnings({"MissingJavadocMethod", "PMD.CyclomaticComplexity"})
public static void checkStatus(int status, int messageID) throws CANInvalidBufferException,
CANMessageNotAllowedException, CANNotInitializedException, UncleanStatusException {
switch (status) {

2
hal/src/main/java/edu/wpi/first/hal/can/CANStatus.java
View File

@@ -38,7 +38,7 @@ public class CANStatus {
@SuppressWarnings("MemberName")
public int transmitErrorCount;
@SuppressWarnings("JavadocMethod")
@SuppressWarnings("MissingJavadocMethod")
public void setStatus(double percentBusUtilization, int busOffCount, int txFullCount,
int receiveErrorCount, int transmitErrorCount) {
this.percentBusUtilization = percentBusUtilization;