Team2890/allwpilib
4
0
Fork 0
mirror of https://github.com/wpilibsuite/allwpilib synced 2026-06-20 00:51:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

[build] Bring naming checkstyle rules up to date with Google Style guide (#1781)

Browse Source 
Also update Checkstyle to 8.38.

Google changed their style guide from the last time we imported it. This PR brings in those naming changes. The change they made is allowing single letter member, parameter, and local variable names. They also added a lambda naming scheme and I thought it would be good to bring that in too.
This commit is contained in:
Austin Shalit
2020-12-29 09:27:48 -08:00
committed by GitHub
parent 8c8ec5e63e
commit 6e1919414e
70 changed files with 224 additions and 285 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/MockDS.java
View File

@@ -22,7 +22,7 @@ public class MockDS {
data[5] = 0x00; // red 1 station
}
@SuppressWarnings("JavadocMethod")
@SuppressWarnings("MissingJavadocMethod")
public void start() {
m_thread = new Thread(() -> {
DatagramSocket socket;
@@ -65,7 +65,7 @@ public class MockDS {
m_thread.start();
}
@SuppressWarnings("JavadocMethod")
@SuppressWarnings("MissingJavadocMethod")
public void stop() {
if (m_thread == null) {
return;

2
wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/PDPTest.java
View File

@@ -50,7 +50,7 @@ public class PDPTest extends AbstractComsSetup {
}
@SuppressWarnings("JavadocMethod")
@SuppressWarnings("MissingJavadocMethod")
public PDPTest(MotorEncoderFixture<?> mef, Double expectedCurrentDraw) {
logger.fine("Constructor with: " + mef.getType());
if (me != null && !me.equals(mef)) {

2
wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/PIDTest.java
View File

@@ -56,7 +56,7 @@ public class PIDTest extends AbstractComsSetup {
}
@SuppressWarnings({"ParameterName", "JavadocMethod"})
@SuppressWarnings({"ParameterName", "MissingJavadocMethod"})
public PIDTest(Double p, Double i, Double d, MotorEncoderFixture<?> mef) {
logger.fine("Constructor with: " + mef.getType());
if (PIDTest.me != null && !PIDTest.me.equals(mef)) {

4
wpilibjIntegrationTests/src/main/java/edu/wpi/first/wpilibj/test/TestBench.java
View File

@@ -218,7 +218,7 @@ public final class TestBench {
return pairs;
}
@SuppressWarnings("JavadocMethod")
@SuppressWarnings("MissingJavadocMethod")
public static AnalogCrossConnectFixture getAnalogCrossConnectFixture() {
return new AnalogCrossConnectFixture() {
@Override
@@ -233,7 +233,7 @@ public final class TestBench {
};
}
@SuppressWarnings("JavadocMethod")
@SuppressWarnings("MissingJavadocMethod")
public static RelayCrossConnectFixture getRelayCrossConnectFixture() {
return new RelayCrossConnectFixture() {
@Override